From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F893361DA7 for ; Tue, 24 Mar 2026 22:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774392395; cv=none; b=eeNgRdZB7jYrH4ivxiVsoomnkrMS6u8nNacdl4e8+7hhx6rchW4yCLD7TbJzBKlrlComQyX3jfYsflH/zoagWygdC4owDSywx8zaGP4ZKNa1G0q8uiK2YJ8N/Er51ckb0tHKIHHnoOuT8bMTSDeVABzRO1eR7aZP76Yxuq+olW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774392395; c=relaxed/simple; bh=3YDYe+eKvpUXHiyvLACVGcDJXT1eIj28IFAVn7VoE+4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K8bGT8WHBeNgOBU52P6j4jhEnijtNy865bibOe781vdEiMfXqnl8KsVMl8X0zkeECR+S/GPMzAdQJ9RnQ2+KQcggbWMjpW6vnZbABs5IEMYrg4/2Mtjr1a0P51koOZqhyLmxH0nDGjVoIN+uO/40p6NEiwZJheUrE3t3SJcAwnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a27c329e98so5751240e87.3 for ; Tue, 24 Mar 2026 15:46:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774392393; x=1774997193; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cwV/BjEvjB+2xLn3P/yF4TbYfG+FKFLU/kxsrZgmYEA=; b=UYa27jx+V6s4wucthW3bx+bBuZdicwxd4TkTmVoJPehhYCrDQtg9GOsRax+JiXmDyY Sv/KDkG26igwq8Q1BfEfZKBqV7hwiGNeQlPxYF81Yx8ruz/Y3NAYM+FHPLG3y39bByGi crt7+f3D/pd02y3OO4dThtP3MLCgJ+KLaUxZ46mpI4/DRSoNFBN8bpwiJAMmX11SAFfp Kh+JdtY7jP+HWDzMC2Z2qjqdgxWXpxgQ2WJKLbI3MxOmo4MuOM3q5DwJsn2tVJL8ZLma X5cbkcJ+GHTmP3YVqLXQKHskdlcVDqC5MsGfReF1WAykbRIyR/b3tOL6C/NGxZl9E7Oo OzQQ== X-Forwarded-Encrypted: i=1; AJvYcCUd5i3t1phdp5oHQpugAMo4nOZqAj0v0bL2azpmIcwL2cXvqqsN7HsAdVslq5tZtL+ihVrDZPs=@vger.kernel.org X-Gm-Message-State: AOJu0YwI3F86ZaqMBMp6RM6RWrmSBN6oR5c9waQokas0WcSfO5sj7PU/ e+xypTfeMkRf36HngfSl0QM0FqhPqTTElH5ZR3NYX9PtAB3YuZFIpNWJ X-Gm-Gg: ATEYQzyDll8ZbHtSOplZrsnEzqXqXx1FFp6lfo4/oZV7C7YpukErMKl3ib5VQUBJJhm Bi6aKf7fJeZfGhBAfUGxUgg/bG/MRYgpj3EZS0KSwBjQlmAj4v3LmK4FZb/INF5d2iMmGAlFYV6 XQG626ddeUNLLatv6Q5Kbxg11jvM5XsTh6hQYjlMseMPjeApuaRSQ72fRF2WiW9bql2RHmd1f3J GqiVPgfImiF7lhWcs0MQzBYujXqqE0+EOljj+H4QvT+/0I8M5dZqiRHPGwpx5x2jzh/LnV29Oli yRSx0y16zDkR2UkGXFHR17zqwE+aG60ACttpGsrw+LJ03edzqpyDUmVxisOa1zCweK73W6whsNp sFgIbynBo+VQ4e7+6uNtATUcnp+LsqM0rPw3GA0Mbpe3zE0a9OQ1EEKsjuQ87/hMl4Nnp/kDxga WJSqzmmFB1MWsh8rdhFcbp X-Received: by 2002:a05:6512:1250:b0:5a2:86bf:28cf with SMTP id 2adb3069b0e04-5a29b990918mr350145e87.29.1774392392094; Tue, 24 Mar 2026 15:46:32 -0700 (PDT) Received: from hackbase ([213.87.129.220]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a298fe3383sm626971e87.9.2026.03.24.15.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:46:30 -0700 (PDT) From: Alexander Popov To: Andrew Lunn , Jakub Kicinski , David Miller , Eric Dumazet , Paolo Abeni , Simon Horman , Maxime Chevallier , Michal Kubecek , Gal Pressman , Kory Maincent , Oleksij Rempel , Ido Schimmel , Heiner Kallweit , Greg KH , Johannes Berg , James Guan , Kees Cook , Paul Moses , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Popov Cc: security@kernel.org, notify@kernel.org Subject: [PATCH] wifi: virt_wifi: remove SET_NETDEV_DEV to avoid use-after-free Date: Wed, 25 Mar 2026 01:46:02 +0300 Message-ID: <20260324224607.374327-1-alex.popov@linux.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently we execute `SET_NETDEV_DEV(dev, &priv->lowerdev->dev)` for the virt_wifi net devices. However, unregistering a virt_wifi device in netdev_run_todo() can happen together with the device referenced by SET_NETDEV_DEV(). It can result in use-after-free during the ethtool operations performed on a virt_wifi device that is currently being unregistered. Such a net device can have the `dev.parent` field pointing to the freed memory, but ethnl_ops_begin() calls `pm_runtime_get_sync(dev->dev.parent)`. Let's remove SET_NETDEV_DEV for virt_wifi to avoid bugs like this: ================================================================== BUG: KASAN: slab-use-after-free in __pm_runtime_resume+0xe2/0xf0 Read of size 2 at addr ffff88810cfc46f8 by task pm/606 Call Trace: dump_stack_lvl+0x4d/0x70 print_report+0x170/0x4f3 ? __pfx__raw_spin_lock_irqsave+0x10/0x10 kasan_report+0xda/0x110 ? __pm_runtime_resume+0xe2/0xf0 ? __pm_runtime_resume+0xe2/0xf0 __pm_runtime_resume+0xe2/0xf0 ethnl_ops_begin+0x49/0x270 ethnl_set_features+0x23c/0xab0 ? __pfx_ethnl_set_features+0x10/0x10 ? kvm_sched_clock_read+0x11/0x20 ? local_clock_noinstr+0xf/0xf0 ? local_clock+0x10/0x30 ? kasan_save_track+0x25/0x60 ? __kasan_kmalloc+0x7f/0x90 ? genl_family_rcv_msg_attrs_parse.isra.0+0x150/0x2c0 genl_family_rcv_msg_doit+0x1e7/0x2c0 ? __pfx_genl_family_rcv_msg_doit+0x10/0x10 ? __pfx_cred_has_capability.isra.0+0x10/0x10 ? stack_trace_save+0x8e/0xc0 genl_rcv_msg+0x411/0x660 ? __pfx_genl_rcv_msg+0x10/0x10 ? __pfx_ethnl_set_features+0x10/0x10 netlink_rcv_skb+0x121/0x380 ? __pfx_genl_rcv_msg+0x10/0x10 ? __pfx_netlink_rcv_skb+0x10/0x10 ? __pfx_down_read+0x10/0x10 genl_rcv+0x23/0x30 netlink_unicast+0x60f/0x830 ? __pfx_netlink_unicast+0x10/0x10 ? __pfx___alloc_skb+0x10/0x10 netlink_sendmsg+0x6ea/0xbc0 ? __pfx_netlink_sendmsg+0x10/0x10 ? __futex_queue+0x10b/0x1f0 ____sys_sendmsg+0x7a2/0x950 ? copy_msghdr_from_user+0x26b/0x430 ? __pfx_____sys_sendmsg+0x10/0x10 ? __pfx_copy_msghdr_from_user+0x10/0x10 ___sys_sendmsg+0xf8/0x180 ? __pfx____sys_sendmsg+0x10/0x10 ? __pfx_futex_wait+0x10/0x10 ? fdget+0x2e4/0x4a0 __sys_sendmsg+0x11f/0x1c0 ? __pfx___sys_sendmsg+0x10/0x10 do_syscall_64+0xe2/0x570 ? exc_page_fault+0x66/0xb0 entry_SYSCALL_64_after_hwframe+0x77/0x7f This fix may be combined with another one in the ethtool subsystem: https://lore.kernel.org/all/20260322075917.254874-1-alex.popov@linux.com/T/#u Fixes: d43c65b05b848e0b ("ethtool: runtime-resume netdev parent in ethnl_ops_begin") Cc: stable@vger.kernel.org Signed-off-by: Alexander Popov --- drivers/net/wireless/virtual/virt_wifi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/virtual/virt_wifi.c b/drivers/net/wireless/virtual/virt_wifi.c index 885dc7243e8d..97bd39d89e98 100644 --- a/drivers/net/wireless/virtual/virt_wifi.c +++ b/drivers/net/wireless/virtual/virt_wifi.c @@ -557,7 +557,6 @@ static int virt_wifi_newlink(struct net_device *dev, eth_hw_addr_inherit(dev, priv->lowerdev); netif_stacked_transfer_operstate(priv->lowerdev, dev); - SET_NETDEV_DEV(dev, &priv->lowerdev->dev); dev->ieee80211_ptr = kzalloc_obj(*dev->ieee80211_ptr); if (!dev->ieee80211_ptr) { -- 2.53.0