public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, Simon Horman <horms@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Martin KaFai Lau <martin.lau@kernel.org>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v4 net-next] tcp: add cwnd_event_tx_start to tcp_congestion_ops
Date: Wed, 25 Mar 2026 14:32:47 +0800	[thread overview]
Message-ID: <202603251430.gQ3VuiKV-lkp@intel.com> (raw)
In-Reply-To: <20260323234920.1097858-1-edumazet@google.com>

Hi Eric,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/tcp-add-cwnd_event_tx_start-to-tcp_congestion_ops/20260325-042334
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260323234920.1097858-1-edumazet%40google.com
patch subject: [PATCH v4 net-next] tcp: add cwnd_event_tx_start to tcp_congestion_ops
config: i386-randconfig-141-20260325 (https://download.01.org/0day-ci/archive/20260325/202603251430.gQ3VuiKV-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603251430.gQ3VuiKV-lkp@intel.com/

New smatch warnings:
include/net/tcp.h:1449 tcp_ca_event() warn: inconsistent indenting
include/net/tcp.h:1449 tcp_ca_event() warn: inconsistent indenting

Old smatch warnings:
net/ipv4/tcp_output.c:779 tcp_options_write() error: we previously assumed 'tp' could be null (see line 747)

vim +1449 include/net/tcp.h

  1441	
  1442	static inline void tcp_ca_event(struct sock *sk, const enum tcp_ca_event event)
  1443	{
  1444		const struct inet_connection_sock *icsk = inet_csk(sk);
  1445	
  1446		if (event == CA_EVENT_TX_START) {
  1447		    if (icsk->icsk_ca_ops->cwnd_event_tx_start)
  1448				icsk->icsk_ca_ops->cwnd_event_tx_start(sk);
> 1449			return;
  1450		}
  1451		if (icsk->icsk_ca_ops->cwnd_event)
  1452			icsk->icsk_ca_ops->cwnd_event(sk, event);
  1453	}
  1454	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2026-03-25  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 23:49 [PATCH v4 net-next] tcp: add cwnd_event_tx_start to tcp_congestion_ops Eric Dumazet
2026-03-25  4:10 ` patchwork-bot+netdevbpf
2026-03-25  6:32 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603251430.gQ3VuiKV-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=martin.lau@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox