From: Simon Horman <horms@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Alexander Wilhelm <alexander.wilhelm@westermo.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: qrtr: fix endian handling of confirm_rx field
Date: Wed, 25 Mar 2026 18:07:37 +0000 [thread overview]
Message-ID: <20260325180737.GM111839@horms.kernel.org> (raw)
In-Reply-To: <jwqcbxfhnzbxn3iwvoe3shtfttio2pjsah3pkwknzqvjx4xfp5@nmfkkgrjxkhk>
On Tue, Mar 24, 2026 at 01:28:32PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Mar 24, 2026 at 08:50:33AM +0100, Alexander Wilhelm wrote:
> > Convert confirm_rx to little endian when enqueueing and convert it back on
> > receive. This fixes control flow on big endian hosts, little endian is
> > unaffected.
> >
> > On transmit, store confirm_rx as __le32 using cpu_to_le32(). On receive,
> > apply le32_to_cpu() before using the value. !! ensures the value is 0 or 1
> > in native endianness, so the conversion isn’t strictly required here, but
> > it is kept for consistency and clarity.
> >
> > Fixes: 5fdeb0d372ab ("net: qrtr: Implement outgoing flow control")
> > Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Sorry if this contradicts my review of v1.
But as this isn't strictly necessary let's target net-next
and drop the Fixes tag.
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2026-03-25 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 7:50 [PATCH net v2] net: qrtr: fix endian handling of confirm_rx field Alexander Wilhelm
2026-03-24 7:58 ` Manivannan Sadhasivam
2026-03-25 18:07 ` Simon Horman [this message]
2026-03-26 6:45 ` Alexander Wilhelm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325180737.GM111839@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexander.wilhelm@westermo.com \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox