From: Chris J Arges <carges@cloudflare.com>
To: netdev@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, davem@davemloft.net, joe@dama.to,
gospo@broadcom.com, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: andrew+netdev@lunn.ch, horms@kernel.org, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
sdf@fomichev.me, shuah@kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, kernel-team@cloudflare.com,
Chris J Arges <carges@cloudflare.com>
Subject: [PATCH net-next v5 3/6] bnxt_en: Move bnxt_rss_ext_op into header
Date: Wed, 25 Mar 2026 15:09:49 -0500 [thread overview]
Message-ID: <20260325201139.2501937-4-carges@cloudflare.com> (raw)
In-Reply-To: <20260325201139.2501937-1-carges@cloudflare.com>
This allows bnxt_rss_ext_op to be used by other functions. In addition this
modifies the rxcmp argument to be const since the function only reads from
this structure.
Reviewed-by: Joe Damato <joe@dama.to>
Signed-off-by: Chris J Arges <carges@cloudflare.com>
---
v5: no changes
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 -----------------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 17 +++++++++++++++++
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index d15548dfd4a3..8ec611bc01ee 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2077,23 +2077,6 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type,
return NULL;
}
-static enum pkt_hash_types bnxt_rss_ext_op(struct bnxt *bp,
- struct rx_cmp *rxcmp)
-{
- u8 ext_op;
-
- ext_op = RX_CMP_V3_HASH_TYPE(bp, rxcmp);
- switch (ext_op) {
- case EXT_OP_INNER_4:
- case EXT_OP_OUTER_4:
- case EXT_OP_INNFL_3:
- case EXT_OP_OUTFL_3:
- return PKT_HASH_TYPE_L4;
- default:
- return PKT_HASH_TYPE_L3;
- }
-}
-
/* returns the following:
* 1 - 1 packet successfully received
* 0 - successful TPA_START, packet not completed yet
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 99f45686ed09..30efcfbb4791 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -2902,6 +2902,23 @@ static inline bool bnxt_sriov_cfg(struct bnxt *bp)
#endif
}
+static inline enum pkt_hash_types bnxt_rss_ext_op(struct bnxt *bp,
+ const struct rx_cmp *rxcmp)
+{
+ u8 ext_op;
+
+ ext_op = RX_CMP_V3_HASH_TYPE(bp, rxcmp);
+ switch (ext_op) {
+ case EXT_OP_INNER_4:
+ case EXT_OP_OUTER_4:
+ case EXT_OP_INNFL_3:
+ case EXT_OP_OUTFL_3:
+ return PKT_HASH_TYPE_L4;
+ default:
+ return PKT_HASH_TYPE_L3;
+ }
+}
+
extern const u16 bnxt_bstore_to_trace[];
extern const u16 bnxt_lhint_arr[];
--
2.43.0
next prev parent reply other threads:[~2026-03-25 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 20:09 [PATCH net-next v5 0/6] bnxt_en: Add XDP RSS hash metadata support Chris J Arges
2026-03-25 20:09 ` [PATCH net-next v5 1/6] bnxt_en: use bnxt_xdp_buff for xdp context Chris J Arges
2026-03-25 20:09 ` [PATCH net-next v5 2/6] bnxt_en: Implement XDP RSS hash metadata extraction Chris J Arges
2026-03-25 20:09 ` Chris J Arges [this message]
2026-03-25 20:09 ` [PATCH net-next v5 4/6] bnxt_en: Implement XDP RSS hash metadata extraction for V3_CMP Chris J Arges
2026-03-25 20:09 ` [PATCH net-next v5 5/6] selftests: net: move common xdp.py functions into lib Chris J Arges
2026-03-25 20:09 ` [PATCH net-next v5 6/6] selftests: drv-net: xdp: Add rss_hash metadata tests Chris J Arges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325201139.2501937-4-carges@cloudflare.com \
--to=carges@cloudflare.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox