From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DEC3F0777 for ; Thu, 26 Mar 2026 12:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528354; cv=none; b=LmmmD79aeOmKQYKqvSkJRwVDGJY4eWlP4lP9aa9ilUruu1e1gICG8erAsLQkCKyeJxlhzCBMuXN5zgMHstGBDxAITKxfF9d5824EVMQ9DOf6Vk1qZM9C60fNCzvdRtY6pvbGOP6c1dyGdV4N14k2RU8k50WQdHtvewhqvc7b4+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528354; c=relaxed/simple; bh=KwQq7eyM0mQVqNtiIXpVpzQjQ6XV2ioWYBG3yYG4oHY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fTGDQvMxRWagcVGTJ6m1uyo8PPxaN1hyA0QOk+bsL3nFpwhDbLM2NUlNXZIyOC3eRbK0Txg0FHJJUiBU1qhyZIolmsJiQ0IwJ0cr5ypKNVknEsVtRflfnWNKbddtP2aNTsivKzRm1vvteuS8QHsxAxRIlVFuwxJojdIAbIblXAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WkvMDT6F; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WkvMDT6F" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4871f6712ebso3975725e9.1 for ; Thu, 26 Mar 2026 05:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774528351; x=1775133151; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=44Rl4IuwAjVXDZrVO8Bc7181pdJEclCn1gduNsTGsBw=; b=WkvMDT6FM6g78nvUCCW0ixzCThO9ULWO+hAvxbSxOcBfbNFYP1vABG+uHqzUDTNXiQ X4xmESgvzfCFvM2Y9Bz3IUP6BRyRFJj5kiHpOyU2LCMVVdLLkueByWK15jGCGOUk88pj jcLZ5zbGCe2TMy7opOt3Un9K5A90PA/G7bgaTmKciN3ycS+YGifji3TjCIvkmR7Bf7ww OaxverDdMf5+mF/E0xJSCCEKVzuAKYHyu3URDH121PhGgvWtZVbCBk7bE00xa8709Xbw GVxyo4TEmoCY+IN+5tSKrIlZFXn21YIPtOyYYyvQ7q/lYMgo2jX/VcObp0YuFdctYWOA l6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774528351; x=1775133151; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=44Rl4IuwAjVXDZrVO8Bc7181pdJEclCn1gduNsTGsBw=; b=D7tbLKaoJCz7Lnk7IbCg0jf7hfcuzCYC6kLMnDquKyhpia4EmPh4GWUi+V5nEUvekT 1jhSf9Vs++evVnVxt8+//lszQjctF3zP2wjKj4P4QyEVZzMXoMA9FOW3XB870heqPAcl NrPjpBVWmQEexO85VGCeM5avI+xLgBkmIEpzBTCiywB+nWJzHoIi3AwGeFOIaP9J6QLT eZIGbL5jYzAzRsxoqhem0rLgeaRvYaS7OP6KTWZJtcDMEka71LPWW8qc4s3In0Rerrj5 mrGzQNLdYjYafJNggZMVag0vIoPZtd2fMaWESyR0jpK9QJKugYPM9CgpswlkRN/p3kWx kq7g== X-Forwarded-Encrypted: i=1; AJvYcCVdN6Kcx4RYvFq0hsUjblPqLSPfWQDbWNlU0rx0H605c+rUVvEmSZIQ3WPSN8mP6NbVoISwguM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx35FY/rUNBkZT00ZrXKeDxxBnL9e0Z9H/rYtREQ6E4Ki0HYNJX qNEPms48/rCphz7vOEnmnpMpSnz8OcCB73KJugq1R5gbNL6THSqCZWYr8mVwUwoRikNn/+7RFpv LQtCwUsJN+2E5tQ== X-Received: from wmcq12.prod.google.com ([2002:a05:600c:c10c:b0:487:247f:cb9e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5296:b0:483:7783:537b with SMTP id 5b1f17b1804b1-4871605bde7mr108915255e9.24.1774528351509; Thu, 26 Mar 2026 05:32:31 -0700 (PDT) Date: Thu, 26 Mar 2026 12:31:58 +0000 In-Reply-To: <20260326-gfp64-v2-0-d916021cecdf@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260326-gfp64-v2-0-d916021cecdf@google.com> X-Mailer: b4 0.14.3 Message-ID: <20260326-gfp64-v2-2-d916021cecdf@google.com> Subject: [PATCH v2 2/4] iwlegacy: 3945-mac: Fixup allocation failure log From: Brendan Jackman To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Stanislaw Gruszka , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Allison Henderson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, Brendan Jackman Content-Type: text/plain; charset="utf-8" Fix 2 issues spotted by AI[0]: 1. Missing space after the full stop. 2. Wrong GFP flags are printed. And also switch to %pGg for the GFP flags. This produces nice readable output and decouples the format string from the size of gfp_t. [0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com Signed-off-by: Brendan Jackman --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c index c148654aa9533..88b31e0b9568c 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c @@ -1002,9 +1002,9 @@ il3945_rx_allocate(struct il_priv *il, gfp_t priority) D_INFO("Failed to allocate SKB buffer.\n"); if (rxq->free_count <= RX_LOW_WATERMARK && net_ratelimit()) - IL_ERR("Failed to allocate SKB buffer with %0x." + IL_ERR("Failed to allocate SKB buffer with %pGg. " "Only %u free buffers remaining.\n", - priority, rxq->free_count); + &gfp_mask, rxq->free_count); /* We don't reschedule replenish work here -- we will * call the restock method and if it still needs * more buffers it will schedule replenish */ -- 2.51.2