From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332F938BF91 for ; Thu, 26 Mar 2026 06:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774506445; cv=none; b=GQQJ+rBQgagMXcQnyC7qGwrU+s1m4uuDwT74ZqNmOB2xB8rjzsnNUiwQ3YuA0lrv9bLW1zHhuwTayhf5hkkpsvXC7uwZ9clqbEycu0fQCDk6p6SKn+QKDfGes3WW8U/lONXwRLuIINPEv8cB8ZoF4PYSJcDs7+bM8JcaCkaE1FI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774506445; c=relaxed/simple; bh=GlyVI328UZrCnzmU5KHsALeteWXWSWoXTaaeXlzCh34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JGxxLCPg0ITFFkI/0oKcL4fgYKffavdt/6av5xU/FO2dm7MjWZU9Qlr1qcguQsWJrEMtAymUjIwBPMxba+fOYMusZ6mFzIcBL2WxcbOcoY4SM+LHSmjmj8NlkeNU8J58ijLCRQS+1/qcDRqnNsPiE2IlV8uEkGwAWwUOjc4ObyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ayzh/g0A; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ayzh/g0A" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774506442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VydxBtB0UN61er6jnHwkE260xpfMKjvzxeAl/0WONPI=; b=ayzh/g0Ap3QmlZslSySNQr9ALP9KyXtZzZ5ipPGRjHCMcmk3ItbWpjj8NkuA8dcD7StEJM d59LEHkrTrcFUEQTFSm3RWE8h8ZkzKv2kf/7RUvw9d+uUIhdCmJA13wp1jcq5n8amXfVNz BqNRb6hNUmmtgZnqwI92OpgRyba8a3o= From: Jiayuan Chen To: netdev@vger.kernel.org Cc: Jiayuan Chen , Jiayuan Chen , Kuniyuki Iwashima , Martin KaFai Lau , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf v2 1/2] bpf: tcp: Reject non-TCP skb in bpf_sk_assign_tcp_reqsk() Date: Thu, 26 Mar 2026 14:26:35 +0800 Message-ID: <20260326062657.88446-2-jiayuan.chen@linux.dev> In-Reply-To: <20260326062657.88446-1-jiayuan.chen@linux.dev> References: <20260326062657.88446-1-jiayuan.chen@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Jiayuan Chen bpf_sk_assign_tcp_reqsk() only validates skb->protocol (L3) but does not check the L4 protocol in the IP header. A BPF program can call this kfunc on a UDP skb with a valid TCP listener socket, which will succeed and attach a TCP reqsk to the UDP skb. When the UDP skb enters the UDP receive path, skb_steal_sock() returns the TCP listener from the reqsk. The UDP code then passes this TCP socket to udp_unicast_rcv_skb() -> __udp_enqueue_schedule_skb(), which casts it to udp_sock and accesses UDP-specific fields at invalid offsets, causing a null pointer dereference and kernel panic: BUG: KASAN: null-ptr-deref in __udp_enqueue_schedule_skb+0x19d/0x1df0 Read of size 4 at addr 0000000000000008 by task test_progs/537 CPU: 1 UID: 0 PID: 537 Comm: test_progs Not tainted 7.0.0-rc4+ #46 PREEMPT Call Trace: dump_stack_lvl (lib/dump_stack.c:123) print_report (mm/kasan/report.c:487) kasan_report (mm/kasan/report.c:597) __kasan_check_read (mm/kasan/shadow.c:32) __udp_enqueue_schedule_skb (net/ipv4/udp.c:1719) udp_queue_rcv_one_skb (net/ipv4/udp.c:2370 net/ipv4/udp.c:2500) udp_queue_rcv_skb (net/ipv4/udp.c:2532) udp_unicast_rcv_skb (net/ipv4/udp.c:2684) __udp4_lib_rcv (net/ipv4/udp.c:2742) udp_rcv (net/ipv4/udp.c:2937) ip_protocol_deliver_rcu (net/ipv4/ip_input.c:209) ip_local_deliver_finish (./include/linux/rcupdate.h:879 net/ipv4/ip_input.c:242) ip_local_deliver (net/ipv4/ip_input.c:265) __netif_receive_skb_one_core (net/core/dev.c:6164 (discriminator 4)) __netif_receive_skb (net/core/dev.c:6280) Fix this by checking the IP header's protocol field in bpf_sk_assign_tcp_reqsk() and rejecting non-TCP skbs with -EINVAL. Fixes: e472f88891ab ("bpf: tcp: Support arbitrary SYN Cookie.") Cc: Jiayuan Chen Reviewed-by: Kuniyuki Iwashima Signed-off-by: Jiayuan Chen --- net/core/filter.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index 78b548158fb0..fb975bcce804 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -12248,11 +12248,17 @@ __bpf_kfunc int bpf_sk_assign_tcp_reqsk(struct __sk_buff *s, struct sock *sk, switch (skb->protocol) { case htons(ETH_P_IP): + if (ip_hdr(skb)->protocol != IPPROTO_TCP) + return -EINVAL; + ops = &tcp_request_sock_ops; min_mss = 536; break; #if IS_BUILTIN(CONFIG_IPV6) case htons(ETH_P_IPV6): + if (ipv6_hdr(skb)->nexthdr != IPPROTO_TCP) + return -EINVAL; + ops = &tcp6_request_sock_ops; min_mss = IPV6_MIN_MTU - 60; break; -- 2.43.0