From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013026.outbound.protection.outlook.com [40.93.201.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8213C212FB9; Thu, 26 Mar 2026 07:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.26 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774508468; cv=fail; b=chGhM5u89BrOCYUprrjrhcCUfcudBgsL5aPgCoUSV5VbGT/jBemfDeF+NfeCj65ofXLqmrt4NJxLyvLqwtNdJnfwnkomBnE2qHCGz/m0p7eFqNrxOoYTh6aZ4RLN8vdencrg+SCygjzZNJ4Noke0jOg3bQJd198PVuT+/PsiL4g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774508468; c=relaxed/simple; bh=rVg+TMWTFvd84MmL6AgZ1GR7mtWchw28kpPxxvTO9J0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KttSCB6HaoAmA1WKltlwa4U+bKWnNyRobAmzBeUrNdphl9C0O07rwJx0kMKqEzBN3FU9kV7GM8LHwajDYIspATpv59dwc6XvZFzy3Ss2DNUQkHCBS08gwfC1qAhPl50LaG0K6d53SD4tIXTmHOfaSDXYmtQzfnIoCH1LJR0w710= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=M4uQe63W; arc=fail smtp.client-ip=40.93.201.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="M4uQe63W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nBYjneiJ8zNlh3N/+pihEd6ePnZh6EWEXYdeUDsnx1KD5SlDGEET/st1uBPZD7i+DAhnVg+cRxxwDzJ7pOzKDywsw3oTVD3qFdpM6L/lwxDqyQ5BB7uh78ylXukMpTA9iMQUAu4gs5Wt+YM0Q9rKymcB2xKe22BMxtrS4QNu5hcE8Y1sILWE6t+BhINXv7v4iPJTlMHk8zK5yhqrprq789Qx3ccYB+aWJbXOQJnVau0SV07ikPR7N1QE+oQFCSsMfQek2Qch18stmQCcfiZHGJSSI/Kl1TMFYpWGrmsk+lH0kqy2fsyz0yUgvc6FM5r/w5tmg0WFG27RSYmv2fm2XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWsTYEXkESQDWpVGX2UqaFDMCn/DNM1NXLnY74SaiD4=; b=bTesCjkx587LVi2ekqtixda1ggMqzpGA8FqzqBupol9I3mqJ6JaeAXye3ZOU2TjZhRQnSHuF3qwBg3iUrjXQaItWaYdG16mWCyiTxEDTMRrymZrkpgpo3qytRuBDOkLHmAtSjsItSsvRqLEg7O6mMMgnT7C0x8kqXCTrD8xQO6tm/JZcWNH7vVXzYd4agcnhkRPf2aHDeMnUJWfrRwpVcQ0Gfh65/OE1WfEpUFzyJRzeoJMhbUwdWsO/1fL506rTcvBBjWBNPbVVPEoa57cm+IWD8ii5CWI3PqC/iVQaQe37Ro2Z2rNMU3TKRCKGtxbqS2JgODVYn9jDkr0gsLY9CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWsTYEXkESQDWpVGX2UqaFDMCn/DNM1NXLnY74SaiD4=; b=M4uQe63WQrwpgWqZ4QVU651c9mxdOsShIBxP3E7/hV4XJuN0t/Tji3TeWTiM5I/rMDf+ZhgRIaXbIOQ+8OAEIFUCDwL25uLDkEAnvwinuHneaXnbgAOCsBYHAsFegpVbMgK9W01eDYoobdl1ST6nLyqj9AsQTCBIvDSB7pdHMLRMknsyIb/uM+l0kXlX2CkRD+ELU/KoJMsWieK3cfkFu5HD3aIPXnM+ONPY1BXyIfD776pFAEMS792tGy+JZkBzJPFWbcG6hIDgRU9e3jqrZvofRQ28Uz47+bcTcSubTTqx4iDfUGvWiJ0yqgwD3DwHpiVCLUYyQoiTgpLxY4wkWw== Received: from MN0PR04CA0014.namprd04.prod.outlook.com (2603:10b6:208:52d::20) by MN2PR12MB4047.namprd12.prod.outlook.com (2603:10b6:208:1de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Thu, 26 Mar 2026 07:01:02 +0000 Received: from BN2PEPF00004FBC.namprd04.prod.outlook.com (2603:10b6:208:52d:cafe::f2) by MN0PR04CA0014.outlook.office365.com (2603:10b6:208:52d::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.32 via Frontend Transport; Thu, 26 Mar 2026 07:01:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN2PEPF00004FBC.mail.protection.outlook.com (10.167.243.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Thu, 26 Mar 2026 07:01:02 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 26 Mar 2026 00:00:41 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 26 Mar 2026 00:00:40 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 26 Mar 2026 00:00:30 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Donald Hunter , Simon Horman , Jiri Pirko , Jonathan Corbet , Shuah Khan , Saeed Mahameed , "Leon Romanovsky" , Tariq Toukan , Mark Bloch , Shuah Khan , Chuck Lever , "Matthieu Baerts (NGI0)" , Carolina Jubran , Cosmin Ratiu , Dragos Tatulea , Jacob Keller , Shahar Shitrit , "Daniel Zahka" , Parav Pandit , "Adithya Jayachandran" , Kees Cook , "Shay Drori" , Daniel Jurgens , Moshe Shemesh , Willem de Bruijn , David Wei , Petr Machata , Stanislav Fomichev , Daniel Borkmann , Joe Damato , Nikolay Aleksandrov , Vadim Fedorenko , "Michael S. Tsirkin" , "Antonio Quartulli" , Allison Henderson , Bui Quang Minh , Nimrod Oren , , , , , , Gal Pressman , Jiri Pirko Subject: [PATCH net-next V9 02/14] devlink: Add helpers to lock nested-in instances Date: Thu, 26 Mar 2026 08:59:37 +0200 Message-ID: <20260326065949.44058-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260326065949.44058-1-tariqt@nvidia.com> References: <20260326065949.44058-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBC:EE_|MN2PR12MB4047:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b23a9e6-93bb-433d-7af2-08de8b057129 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700016|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: E/vxr0zipJkBL8rf+LL4AWJRjfsWXtqMJzsobAth50Rbjpshl3UeW11Vp4Cy2EsIep/pz/UGumKLWcjAMKLZj60+s0Z26Rcg3aFRA/SUbbUVPwo3bujZ32Ok3QAh1X9QbOQq2AQPeSre+FPV5Xc4nEWpj+rH6PSNj439ClUZ1pfvh9u6EjLANUb8cxtBn1wLkDnuN0rzZ2HW517735gAIsYXFEJ5ZyEAvX28oMmor5TX1HC7yDBJjFdIh5MMCXHP2QWUSL/JbNa75HVUU7ZcloKt/Bet2fkVdcmH4lwQxLU+VmQzp3RYenWI498smePRzIxLv5IZfdZoyijLcH6evHSRMafrmrpfGwKChOh8nEbZ24SP0A+trFW4tVhHy9LCf8zyPnewrVg+XQ8fw8uzXnpc2N5k3USmXKsJDdoU24+aFzpvV6wfuAU7ap4N6u0QQG8nc3bwgXibxtfD2p+aesguZrSDm+HsInjHJe9UlWm2RIMGW9W9O9SBuXxTTu61lIrg9EAEQ6F9Q7Oh7XbqmEOCDwID1PHQNc/sznNNxKRT1/lW/JA0ITmb6h7NV82nuwixgpLXSaaC1IFWVkv2c5kZlrMiw0/VuvH9rz+mQasU1zk+5vjfqvJP7ZjKDx+TLUEz1mxfDv6BJxvZOeRcwjw717Vlc2xtp7hovxsU7FjWreik6VpK0DsCOxO9KV3a1LHf7up0xtLrZmuxEmZkPG/YLXnUTk+t+QsuguejEoWsZzpvlMYxhknZOqfK7S81FINjo6sKJ4EwqMLCp7xcxg== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CnoUN3kSjCN3/sJAs966NkCpVWBSTedw5XB4Cribo+l2uroOViM7L9RLNZrq7bN8u2Q6G97ku8VV+LVzRAmT+P6mmO8AX3+QZpJIBTjWhq9ML1qREXjPNJCcn7XpDvlUJ8kS7Vx2QQ7lO8fcrmTrnEmidycY8Kp3A2Sa7FbG7+x9p0d9adgulRFkAPpJ8Q+GduP+rn6euYCbZ4VMHaVCDUStjmmG1d50KODDD5hcSyRAZTJZXYmbd5sjWUPkR5/XOmkz1iN7EenzqBnCkZ+7Zd2OD9CqkRCnfUz9GoPLLOGrRZmuYQjHvb/J1FJuzyC3jKqs7np1pQ044atPYFaYmWEkSIu+3h39kYIQaiFcaXCNqysKWyTejawDlZxgqTBL+AzYTtuFzC+9C9wUUQ7KuOD4fg17GgR+9htMIVYAyGZIEhu+eZ2Min81lcQ0Efxl X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 07:01:02.1208 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b23a9e6-93bb-433d-7af2-08de8b057129 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4047 From: Cosmin Ratiu Upcoming code will need to obtain a reference to locked nested-in devlink instances. Add helpers to lock, obtain an already locked reference and unlock/unref the nested-in instance. Signed-off-by: Cosmin Ratiu Reviewed-by: Carolina Jubran Reviewed-by: Jiri Pirko Signed-off-by: Tariq Toukan --- net/devlink/core.c | 42 +++++++++++++++++++++++++++++++++++++ net/devlink/devl_internal.h | 3 +++ 2 files changed, 45 insertions(+) diff --git a/net/devlink/core.c b/net/devlink/core.c index eeb6a71f5f56..db11248df712 100644 --- a/net/devlink/core.c +++ b/net/devlink/core.c @@ -67,6 +67,48 @@ static void __devlink_rel_put(struct devlink_rel *rel) devlink_rel_free(rel); } +struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel) +{ + struct devlink *devlink; + + if (!rel) + return NULL; + devlink = devlinks_xa_get(rel->nested_in.devlink_index); + if (!devlink) + return NULL; + devl_lock(devlink); + if (devl_is_registered(devlink)) + return devlink; + devl_unlock(devlink); + devlink_put(devlink); + return NULL; +} + +/* Returns the nested in devlink object and validates its lock is held. */ +struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel) +{ + struct devlink *devlink; + unsigned long index; + + if (!rel) + return NULL; + index = rel->nested_in.devlink_index; + devlink = xa_find(&devlinks, &index, index, DEVLINK_REGISTERED); + if (devlink) + devl_assert_locked(devlink); + return devlink; +} + +void devlink_nested_in_put_unlock(struct devlink_rel *rel) +{ + struct devlink *devlink = devlink_nested_in_get_locked(rel); + + if (devlink) { + devl_unlock(devlink); + devlink_put(devlink); + } +} + static void devlink_rel_nested_in_notify_work(struct work_struct *work) { struct devlink_rel *rel = container_of(work, struct devlink_rel, diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h index 7dfb7cdd2d23..3b4364677b18 100644 --- a/net/devlink/devl_internal.h +++ b/net/devlink/devl_internal.h @@ -136,6 +136,9 @@ typedef void devlink_rel_notify_cb_t(struct devlink *devlink, u32 obj_index); typedef void devlink_rel_cleanup_cb_t(struct devlink *devlink, u32 obj_index, u32 rel_index); +struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel); +struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel); +void devlink_nested_in_put_unlock(struct devlink_rel *rel); void devlink_rel_nested_in_clear(u32 rel_index); int devlink_rel_nested_in_add(u32 *rel_index, u32 devlink_index, u32 obj_index, devlink_rel_notify_cb_t *notify_cb, -- 2.44.0