public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Chih Kai Hsu <hsu.chih.kai@realtek.com>
To: <kuba@kernel.org>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<edumazet@google.com>, <bjorn@mork.no>, <pabeni@redhat.com>,
	Chih Kai Hsu <hsu.chih.kai@realtek.com>
Subject: [PATCH net-next v4 0/3] r8152: add helper functions for PLA/USB/PHY OCP registers
Date: Thu, 26 Mar 2026 15:39:22 +0800	[thread overview]
Message-ID: <20260326073925.32976-453-nic_swsd@realtek.com> (raw)

v4:
- Add a new patch for original #1. We need to fix a typo first before
  original #1 patch.

- For patch #2, replace redundant ocp_word_set_bits() with ocp_word_w0w1().

v3:
- For patch #1, fix the issue identified by the AI review.
  In v2, ocp_byte_set_bits() was used to update the USB_LPM_CTRL register.
  However, since its function only perform a bitwise OR operaion, it fails
  to clear the old bits when updating a multi-bit field like LPM_TIMER.
  Therefore, use ocp_write_byte() to maintain the original direct-write 
  semantics.

- For patch #2, fix the line length exceeding 80 columns

v2:
For patch #2, remove variable set but not used from r8153_init(),
r8153b_init() and r8153c_init()

v1:
Add bitwise operaion functions for PLA/USB/PHY OCP registers 
to simplify the code.

Chih Kai Hsu (3):
  r8152: fix incorrect register write to USB_UPHY_XTAL
  r8152: add helper functions for PLA/USB OCP registers
  r8152: add helper functions for PHY OCP registers

 drivers/net/usb/r8152.c | 1800 ++++++++++++++-------------------------
 1 file changed, 634 insertions(+), 1166 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-03-26  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  7:39 Chih Kai Hsu [this message]
2026-03-26  7:39 ` [PATCH net-next v4 1/3] r8152: fix incorrect register write to USB_UPHY_XTAL Chih Kai Hsu
2026-03-26 13:18   ` Hayes Wang
2026-03-26  7:39 ` [PATCH net-next v4 2/3] r8152: add helper functions for PLA/USB OCP registers Chih Kai Hsu
2026-03-26 13:19   ` Hayes Wang
2026-03-26  7:39 ` [PATCH net-next v4 3/3] r8152: add helper functions for PHY " Chih Kai Hsu
2026-03-26 13:19   ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326073925.32976-453-nic_swsd@realtek.com \
    --to=hsu.chih.kai@realtek.com \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox