From: Wei Fang <wei.fang@nxp.com>
To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
xiaoning.wang@nxp.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, alexandru.marginean@nxp.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: [PATCH v2 net 0/2] net: enetc: add more checks to enetc_set_rxfh()
Date: Thu, 26 Mar 2026 15:52:31 +0800 [thread overview]
Message-ID: <20260326075233.3628047-1-wei.fang@nxp.com> (raw)
ENETC only supports Toeplitz algorithm, and VFs do not support setting
the RSS key, but enetc_set_rxfh() does not check these constraints and
silently accepts unsupported configurations. This may mislead users or
tools into believing that the requested RSS settings have been
successfully applied. So add checks to reject unsupported hash functions
and RSS key updates on VFs, and return "-EOPNOTSUPP" to user space.
---
v2:
1. Fix a typo in the commit message of patch 2.
2. Collect Reviewed-by tag.
---
Wei Fang (2):
net: enetc: check whether the RSS algorithm is Toeplitz
net: enetc: do not allow VF to configure the RSS key
drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--
2.34.1
next reply other threads:[~2026-03-26 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 7:52 Wei Fang [this message]
2026-03-26 7:52 ` [PATCH v2 net 1/2] net: enetc: check whether the RSS algorithm is Toeplitz Wei Fang
2026-03-26 10:32 ` Claudiu Manoil
2026-03-26 7:52 ` [PATCH v2 net 2/2] net: enetc: do not allow VF to configure the RSS key Wei Fang
2026-03-26 10:32 ` Claudiu Manoil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326075233.3628047-1-wei.fang@nxp.com \
--to=wei.fang@nxp.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox