Re: [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes

[Vladimir Oltean <olteanv@gmail.com>]

On Thu, Mar 26, 2026 at 10:57:31AM +0100, Linus Walleij wrote:
> This fixes some glearing issues in the Micrel KS8995 driver
> pointed out by Vladimir.
> 
> This patch series implements some required functionality
> and strips the driver down to just KS8995 deeming the other
> "micrel" variants to be actually handled by the Microchip
> KSZ driver.
> 
> If the KS8995 should actually *also* be managed by the Microchip
> driver and this driver deleted remains to be seen. It is clearly
> the origin chip for that hardware: it is very close to the
> "KSZ8 family" but there are differences.
> 
> It definitely has a different custom tag format for proper DSA
> tagging, but I have implemented that: I now have to figure out
> whether to do that on top of this driver or the KSZ driver before
> continuing.
> 
> In the meantime, this patch series makes the situation better.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
> Changes in v4:
> - Drop the final "port isolation" (should be better named "port separation")
>   patch, due to lack of time to revise the patch. Let's keep this one
>   for later.
> - Hope we can merge this first round of fixups so the driver is in some
>   reasonable state.
> - Link to v3: https://lore.kernel.org/r/20260219-ks8995-fixups-v3-0-a7fc63fe1916@kernel.org
> 
> Changes in v3:
> - Re-tag the series for net since they are fixes.
> - Implement mutual exclusion between .remove() and .shutdown()
>   as found by the AI reviewer.
> - Fix a typo in the patch dropping the KSZ chips support, 8955->8995,
>   found by the AI reviewer.
> - Add fallback compatibles for the deleted chips to the KSZ
>   SPI driver.
> - Implement port isolation.
> - Link to v2: https://lore.kernel.org/r/20260119-ks8995-fixups-v2-0-98bd034a0d12@kernel.org
> 
> Changes in v2:
> - Do port_bitmask in another way and fix a bug where BIT(port_bitmask)
>   was used instead of just port_bitmask.
> - Link to v1: https://lore.kernel.org/r/20260118-ks8995-fixups-v1-0-10a493f0339d@kernel.org
> 
> ---
> Linus Walleij (4):
>       net: dsa: ks8995: Add shutdown callback
>       net: dsa: microchip: Add fallback Micrel compatibles
>       net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support
>       net: dsa: ks8995: Add stub bridge join/leave
> 
>  drivers/net/dsa/ks8995.c            | 198 ++++++++++++------------------------
>  drivers/net/dsa/microchip/ksz_spi.c |  15 +++
>  2 files changed, 81 insertions(+), 132 deletions(-)
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260118-ks8995-fixups-84f25ac3f407
> 
> Best regards,
> -- 
> Linus Walleij <linusw@kernel.org>
> 

Bastien, would you mind also taking a look at this?