From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linusw@kernel.org>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Tristram Ha <Tristram.Ha@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes
Date: Thu, 26 Mar 2026 12:06:37 +0200 [thread overview]
Message-ID: <20260326100637.7xyd42yoop2faabf@skbuf> (raw)
In-Reply-To: <20260326100243.rxxmbiscjrbe3643@skbuf>
On Thu, Mar 26, 2026 at 12:02:43PM +0200, Vladimir Oltean wrote:
> On Thu, Mar 26, 2026 at 10:57:31AM +0100, Linus Walleij wrote:
> > This fixes some glearing issues in the Micrel KS8995 driver
> > pointed out by Vladimir.
> >
> > This patch series implements some required functionality
> > and strips the driver down to just KS8995 deeming the other
> > "micrel" variants to be actually handled by the Microchip
> > KSZ driver.
> >
> > If the KS8995 should actually *also* be managed by the Microchip
> > driver and this driver deleted remains to be seen. It is clearly
> > the origin chip for that hardware: it is very close to the
> > "KSZ8 family" but there are differences.
> >
> > It definitely has a different custom tag format for proper DSA
> > tagging, but I have implemented that: I now have to figure out
> > whether to do that on top of this driver or the KSZ driver before
> > continuing.
> >
> > In the meantime, this patch series makes the situation better.
> >
> > Signed-off-by: Linus Walleij <linusw@kernel.org>
> > ---
> > Changes in v4:
> > - Drop the final "port isolation" (should be better named "port separation")
> > patch, due to lack of time to revise the patch. Let's keep this one
> > for later.
> > - Hope we can merge this first round of fixups so the driver is in some
> > reasonable state.
> > - Link to v3: https://lore.kernel.org/r/20260219-ks8995-fixups-v3-0-a7fc63fe1916@kernel.org
> >
> > Changes in v3:
> > - Re-tag the series for net since they are fixes.
> > - Implement mutual exclusion between .remove() and .shutdown()
> > as found by the AI reviewer.
> > - Fix a typo in the patch dropping the KSZ chips support, 8955->8995,
> > found by the AI reviewer.
> > - Add fallback compatibles for the deleted chips to the KSZ
> > SPI driver.
> > - Implement port isolation.
> > - Link to v2: https://lore.kernel.org/r/20260119-ks8995-fixups-v2-0-98bd034a0d12@kernel.org
> >
> > Changes in v2:
> > - Do port_bitmask in another way and fix a bug where BIT(port_bitmask)
> > was used instead of just port_bitmask.
> > - Link to v1: https://lore.kernel.org/r/20260118-ks8995-fixups-v1-0-10a493f0339d@kernel.org
> >
> > ---
> > Linus Walleij (4):
> > net: dsa: ks8995: Add shutdown callback
> > net: dsa: microchip: Add fallback Micrel compatibles
> > net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support
> > net: dsa: ks8995: Add stub bridge join/leave
> >
> > drivers/net/dsa/ks8995.c | 198 ++++++++++++------------------------
> > drivers/net/dsa/microchip/ksz_spi.c | 15 +++
> > 2 files changed, 81 insertions(+), 132 deletions(-)
> > ---
> > base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> > change-id: 20260118-ks8995-fixups-84f25ac3f407
> >
> > Best regards,
> > --
> > Linus Walleij <linusw@kernel.org>
> >
>
> Bastien, would you mind also taking a look at this?
And also Tristram Ha. I didn't realize he is not a KSZ maintainer.
It's been a year since Woojung last sent a reply to the mailing lists.
next prev parent reply other threads:[~2026-03-26 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:57 [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes Linus Walleij
2026-03-26 9:57 ` [PATCH net v4 1/4] net: dsa: ks8995: Add shutdown callback Linus Walleij
2026-03-26 10:03 ` Vladimir Oltean
2026-03-26 9:57 ` [PATCH net v4 2/4] net: dsa: microchip: Add fallback Micrel compatibles Linus Walleij
2026-03-26 10:11 ` Vladimir Oltean
2026-03-26 9:57 ` [PATCH net v4 3/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support Linus Walleij
2026-03-26 10:21 ` Vladimir Oltean
2026-03-26 9:57 ` [PATCH net v4 4/4] net: dsa: ks8995: Add stub bridge join/leave Linus Walleij
2026-03-26 10:26 ` Vladimir Oltean
2026-03-26 10:02 ` [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes Vladimir Oltean
2026-03-26 10:06 ` Vladimir Oltean [this message]
2026-03-26 10:33 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326100637.7xyd42yoop2faabf@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bastien.curutchet@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox