public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linusw@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v4 3/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support
Date: Thu, 26 Mar 2026 12:21:43 +0200	[thread overview]
Message-ID: <20260326102143.hh3g6oo2jp22i6ps@skbuf> (raw)
In-Reply-To: <20260326-ks8995-fixups-v4-3-989abba8f077@kernel.org> <20260326-ks8995-fixups-v4-3-989abba8f077@kernel.org>

On Thu, Mar 26, 2026 at 10:57:34AM +0100, Linus Walleij wrote:
> After studying the datasheets for a bit, I can conclude that
> the register maps for the two KSZ variants explicitly said to
> be supported by this driver are fully supported by the newer
> Micrel KSZ driver, including full VLAN support and a different
> custom tag than what the KS8995 is using.

And more importantly: support for the internal PHYs? Tristram pointed
out here that this is is missing
https://lore.kernel.org/netdev/DM3PR11MB87361761E911D6EAA0311DF2EC44A@DM3PR11MB8736.namprd11.prod.outlook.com/
I was curious how you are avoiding that issue?

> 
> Delete this support, users should be using the KSZ driver
> CONFIG_NET_DSA_MICROCHIP_KSZ_SPI and any new device trees should
> use:
> micrel,ksz8864 -> microchip,ksz8864
> micrel,ksz8795 -> microchip,ksz8795
> 
> Apparently Microchip acquired Micrel at some point and this
> created the confusion.
> 
> Fixes: a7fe8b266f65 ("net: dsa: ks8995: Add basic switch set-up")
> Reported-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

  reply	other threads:[~2026-03-26 10:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  9:57 [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes Linus Walleij
2026-03-26  9:57 ` [PATCH net v4 1/4] net: dsa: ks8995: Add shutdown callback Linus Walleij
2026-03-26 10:03   ` Vladimir Oltean
2026-03-26  9:57 ` [PATCH net v4 2/4] net: dsa: microchip: Add fallback Micrel compatibles Linus Walleij
2026-03-26 10:11   ` Vladimir Oltean
2026-03-26  9:57 ` [PATCH net v4 3/4] net: dsa: ks8955: Delete KSZ8864 and KSZ8795 support Linus Walleij
2026-03-26 10:21   ` Vladimir Oltean [this message]
2026-03-26  9:57 ` [PATCH net v4 4/4] net: dsa: ks8995: Add stub bridge join/leave Linus Walleij
2026-03-26 10:26   ` Vladimir Oltean
2026-03-26 10:02 ` [PATCH net v4 0/4] net: dsa: ks8995: Post-move fixes Vladimir Oltean
2026-03-26 10:06   ` Vladimir Oltean
2026-03-26 10:33 ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326102143.hh3g6oo2jp22i6ps@skbuf \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox