From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v3 00/11] rxrpc: Miscellaneous fixes
Date: Thu, 26 Mar 2026 13:18:25 +0000 [thread overview]
Message-ID: <20260326131838.634095-1-dhowells@redhat.com> (raw)
Here are some fixes for rxrpc:
(1) Fix key quota calculation.
(2) Fix a memory leak.
(3) Fix rxrpc_new_client_call_for_sendmsg() to substitute NULL for an
empty key.
Might want to remove this substitution entirely or handle it in
rxrpc_init_client_call_security() instead.
(4) Not strictly a fix, but move on_list_rcu() from apparmor to list.h so
that (5) can use it as list_empty() is not sufficient. Also add an
on_list() function.
(5) Fix deletion of call->link to be RCU safe.
(6) Fix missing bounds checks when parsing RxGK tickets.
(7) Fix use of wrong skbuff to get challenge serial number. Also actually
substitute the newer response skbuff and release the older one.
(8) Fix unexpected RACK timer warning to report old mode.
(9) Fix server keyring refcount leak.
(10) Fix call key refcount leak.
(11) Fix the interaction of jumbograms with Tx window space, setting the
request-ack flag when the window space is getting low, typically because
each jumbogram take a big bite out of the window and fewer UDP packets
get traded.
David
The patches can be found here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes
Changes
=======
ver #3)
- Rename the dwc2's on_list() to dwc2_on_list() to free up the name.
- Added a patch to fix the interaction of jumbograms with window space.
ver #2)
- AI review[1]:
- Added a patch to fix key quota calculation.
- Added a patch to fix a memory leak.
- Added a patch to use NULL instead of an empty key in rxrpc_sengmsg().
- Added a patch to use RCU-safe deletion on call->link.
- Modified the response packet selection patch to select the newer
response when there's an older response - and to release the older
response skbuff.
- Move on_list_rcu() and add on_list().
Link: https://sashiko.dev/#/patchset/20260319150150.4189381-1-dhowells%40redhat.com [1]
Alok Tiwari (2):
rxrpc: Fix use of wrong skb when comparing queued RESP challenge
serial
rxrpc: Fix rack timer warning to report unexpected mode
Anderson Nascimento (2):
rxrpc: Fix keyring reference count leak in rxrpc_setsockopt()
rxrpc: Fix key reference count leak from call->key
David Howells (5):
rxrpc: Fix key quota calculation for multitoken keys
rxrpc: Fix key parsing memleak
rxrpc: Fix anonymous key handling
list: Move on_list_rcu() to list.h and add on_list() also
rxrpc: Fix call removal to use RCU safe deletion
Marc Dionne (1):
rxrpc: Fix to request an ack if window is limited
Oleh Konko (1):
rxrpc: Fix RxGK token loading to check bounds
drivers/usb/dwc2/gadget.c | 6 ++---
include/linux/list.h | 26 ++++++++++++++++++++
include/trace/events/rxrpc.h | 2 ++
net/rxrpc/af_rxrpc.c | 2 +-
net/rxrpc/ar-internal.h | 2 +-
net/rxrpc/call_object.c | 7 +++---
net/rxrpc/conn_event.c | 5 ++--
net/rxrpc/input_rack.c | 2 +-
net/rxrpc/key.c | 38 +++++++++++++++++-------------
net/rxrpc/output.c | 2 ++
net/rxrpc/proc.c | 5 ++--
net/rxrpc/sendmsg.c | 2 +-
security/apparmor/include/policy.h | 2 --
13 files changed, 69 insertions(+), 32 deletions(-)
next reply other threads:[~2026-03-26 13:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 13:18 David Howells [this message]
2026-03-26 13:18 ` [PATCH net v3 01/11] rxrpc: Fix key quota calculation for multitoken keys David Howells
2026-03-26 13:18 ` [PATCH net v3 02/11] rxrpc: Fix key parsing memleak David Howells
2026-03-26 13:18 ` [PATCH net v3 03/11] rxrpc: Fix anonymous key handling David Howells
2026-03-26 13:18 ` [PATCH net v3 04/11] list: Move on_list_rcu() to list.h and add on_list() also David Howells
2026-03-26 13:18 ` [PATCH net v3 05/11] rxrpc: Fix call removal to use RCU safe deletion David Howells
2026-03-26 13:18 ` [PATCH net v3 06/11] rxrpc: Fix RxGK token loading to check bounds David Howells
2026-03-26 13:18 ` [PATCH net v3 07/11] rxrpc: Fix use of wrong skb when comparing queued RESP challenge serial David Howells
2026-03-26 13:18 ` [PATCH net v3 08/11] rxrpc: Fix rack timer warning to report unexpected mode David Howells
2026-03-26 13:18 ` [PATCH net v3 09/11] rxrpc: Fix keyring reference count leak in rxrpc_setsockopt() David Howells
2026-03-26 13:18 ` [PATCH net v3 10/11] rxrpc: Fix key reference count leak from call->key David Howells
2026-03-26 13:18 ` [PATCH net v3 11/11] rxrpc: Fix to request an ack if window is limited David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326131838.634095-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox