From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] ipv6: move IFA_F_PERMANENT percpu allocation in process scope
Date: Thu, 26 Mar 2026 18:35:59 -0700 [thread overview]
Message-ID: <20260326183559.6e7965f3@kernel.org> (raw)
In-Reply-To: <8c8bfe2e1a324e501f0e15fef404a77443fd8caf.1774365668.git.pabeni@redhat.com>
On Tue, 24 Mar 2026 16:22:08 +0100 Paolo Abeni wrote:
> + while (!list_empty(&tmp_addr_list)) {
> + ifp = list_first_entry(&tmp_addr_list,
> + struct inet6_ifaddr, if_list_aux);
> + list_del(&ifp->if_list_aux);
> +
> + if (fixup_permanent_addr(net, idev, ifp) < 0) {
> in6_ifa_hold(ifp);
> ipv6_del_addr(ifp);
> - write_lock_bh(&idev->lock);
>
> net_info_ratelimited("%s: Failed to add prefix route for address %pI6c; dropping\n",
> idev->dev->name, &ifp->addr);
> }
Sashiko points out that there's a UAF on the ifp->addr in the print
statement. Could you reorder these in net first, to avoid the conflict?
--
pw-bot: cr
prev parent reply other threads:[~2026-03-27 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:22 [PATCH net-next] ipv6: move IFA_F_PERMANENT percpu allocation in process scope Paolo Abeni
2026-03-26 17:26 ` David Ahern
2026-03-27 1:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326183559.6e7965f3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox