From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A3C332604; Thu, 26 Mar 2026 20:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774555667; cv=none; b=PiyPSSMMi5AWOrleRw6X87FBKBdkb3OM/Q8ywh3gWYRzLi/L29TLtK25p2tFnET12MPmA9AUefA9VO8Yvk7cw3I25JWb5W2FEnUhB4gR3lFmptIrODKJbtJioBSuDxmj1SH18UzisrppSucFWYf+qFCBcNen12wTcb4pvDHqEz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774555667; c=relaxed/simple; bh=bp1iEoeqeUWKYCv7HTMg7A+5K8IQRL9BXMemdoAYYT4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aUvVhCpfYQglziK/gQ4ZzlKURHus1plPKduLtge4lmEIeZCJ8AYPc79oJLtp0fMBmwmAmXKka8ko0CssCzzvsRThsHXuU36AJ4SNR5w7i2TpaIPl2DOI7Z+CyGRpR8bnfUwxR+BVWfuvSLblvHE7wotI0FZ31FoWaEIhDBNo2jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FgcZD9KR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FgcZD9KR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58AF4C19423; Thu, 26 Mar 2026 20:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774555666; bh=bp1iEoeqeUWKYCv7HTMg7A+5K8IQRL9BXMemdoAYYT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FgcZD9KRl1ruYV0QQ45A33vgyq9qWjiTVHx3mE961Jym2mBaccT89Sz9ZFKm3X+cm sj67BdmhcWHr/0kV8jUDV6pcamMrsCcc2sngCsKRKNpUb2r7vmrVX7HX9bXNv9xtjj /RAcdBlJ9A+M8VNuwAkapSphCmv31Xld/vDyeU6nQ2cJSdipPZIqHqhCL+4oJ4YbJv qF6MgqpNSW22oMcMV2E8GIUq91k95q5Gafvq+ojg7JgbXKlXL1161KlRnYEOO9VYsV 4Nx9ogTtUxzmjgzXYlIxnQmXHpuPg4AEoStmsbc0sgvKv98EBZjSJGLRqwIyKyiIOp I1J1W+/QnJwYA== Date: Thu, 26 Mar 2026 20:07:40 +0000 From: Simon Horman To: Erni Sri Satya Vennela Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shradhagupta@linux.microsoft.com, kotaranov@microsoft.com, dipayanroy@linux.microsoft.com, yury.norov@gmail.com, kees@kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: mana: Use at least SZ_4K in doorbell ID range check Message-ID: <20260326200740.GY111839@horms.kernel.org> References: <20260325180423.1923060-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325180423.1923060-1-ernis@linux.microsoft.com> On Wed, Mar 25, 2026 at 11:04:17AM -0700, Erni Sri Satya Vennela wrote: > mana_gd_ring_doorbell() accesses offsets up to DOORBELL_OFFSET_EQ > (0xFF8) + 8 bytes = 4KB within each doorbell page. A db_page_size > smaller than SZ_4K is fundamentally incompatible with the driver: > doorbell pages would overlap and the device cannot function correctly. > > Validate db_page_size at the source and fail the > probe early if the value is below SZ_4K. This ensures the doorbell ID > range check in mana_gd_register_device() can rely on db_page_size > being valid. > > Fixes: 89fe91c65992 ("net: mana: hardening: Validate doorbell ID from GDMA_REGISTER_DEVICE response") > Signed-off-by: Erni Sri Satya Vennela > --- > Changes in v2: > * Remove "db_page_sz = max_t(u64, SZ_4K, gc->db_page_size)" in > mana_gd_register_device and validate db_page_sz at the source > mana_gf_init_pf_regs and mana_gd_init_vf_regs. > * Update commit message. Thanks for the update. Reviewed-by: Simon Horman