From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA93F3BFE3B for ; Fri, 27 Mar 2026 06:48:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774594153; cv=none; b=Z4UMgVGJjxpUg9c9864OeOj2xFVJlzLulUkwcLWYPX60uRis9E4JygDOsUVmETeWnLioiiYQvbNpWVP+sc0uu+XXtKjNcAV+2Tudonm4aBXH+kRSsaQ43EHe8DWM9ZEiXPQN7AxJmC9bEDlKPULWfOW0jHQrp6MnlUp3bcb8BNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774594153; c=relaxed/simple; bh=pcDAlfcW3JXhOWCYWTqgaH2kuIhBNKZX7wqVsnTEG+Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=b39EYeaG2PJA5s7FrrjiiYR1Tsql/ATJ6Ah30nvHVdGzHkeIpoXDPeEpXuC2/1lEoF/kThzfccJq6VV2bcW2CCUIkWfsZ23ulNfkxumdAGFHBtne6/R8VCSDSQExd8r9luBIK2f6WhYWJjfbm/8N0dHOpgbtnwV4WJbArXyXXuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gA8juHA2; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gA8juHA2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774594140; x=1806130140; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pcDAlfcW3JXhOWCYWTqgaH2kuIhBNKZX7wqVsnTEG+Y=; b=gA8juHA29fVjqx++Ovbr9EpDs2XTRFZuoNpXf0z3+jTAPvOo1qZXlLEN e+KLz++TmFOFO72/feZUkCI6pDtNUWF1uIgjPxj10Y1yo36n9AB9092Li uG0F1/m/rEOSy+Kk0H/AiliDido1nqIuFijlwa4mGtTST8tVSL6fs2jEe ads9ZTKHd5CDCleOZgR0B0H2lvtEyZzSppjHRMpLNxHAEpYE5hautM2HG sua+Sd9Qo0Z8aaOgY6TZ70I/9rtrrklcUHkBAG4s+Yn9TzYbNA8IIgeGf irXz9BGgJNM8eLZOPbbCZiYNWHvGmO01KqW3xdqvLXTbMidixOqVR3MDw w==; X-CSE-ConnectionGUID: otsuOaHfR9q40VpUw/Vo3A== X-CSE-MsgGUID: MWgouRB9StG9aqPhR4rrIg== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="93245250" X-IronPort-AV: E=Sophos;i="6.23,143,1770624000"; d="scan'208";a="93245250" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 23:48:58 -0700 X-CSE-ConnectionGUID: Srtd+vGeS4a5cBtq8yPYDA== X-CSE-MsgGUID: PwVm5LFURgmmlMPpmEwwVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,143,1770624000"; d="scan'208";a="229699860" Received: from amlin-019-225.igk.intel.com ([10.102.19.225]) by orviesa004.jf.intel.com with ESMTP; 26 Mar 2026 23:48:56 -0700 From: Aleksandr Loktionov To: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com Cc: netdev@vger.kernel.org, Marcin Szycik , Joe Damato Subject: [PATCH iwl-next v4] ice: remove excessive memory allocation in ice_create_lag_recipe() Date: Fri, 27 Mar 2026 07:48:55 +0100 Message-ID: <20260327064855.112786-1-aleksandr.loktionov@intel.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Marcin Szycik For some reason ice_create_lag_recipe() allocates an array of 64 struct ice_aqc_recipe_data_elem elements, while it only needs one (1). Fix it, while also using kzalloc_obj(). Signed-off-by: Marcin Szycik Signed-off-by: Aleksandr Loktionov Reviewed-by: Joe Damato --- v3 -> v4 corrected misspeled RB from Joe v2 -> v3 use sizeof(*new_rcp) in memcpy() to match the allocation (Joe) v1 -> v2 remove 'Fixes' from commit message because it's not a critical bug --- drivers/net/ethernet/intel/ice/ice_lag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c index 310e8fe..9ad19c3 100644 --- a/drivers/net/ethernet/intel/ice/ice_lag.c +++ b/drivers/net/ethernet/intel/ice/ice_lag.c @@ -2418,11 +2418,11 @@ static int ice_create_lag_recipe(struct ice_hw *hw, u16 *rid, if (err) return err; - new_rcp = kzalloc(ICE_RECIPE_LEN * ICE_MAX_NUM_RECIPES, GFP_KERNEL); + new_rcp = kzalloc_obj(*new_rcp, GFP_KERNEL); if (!new_rcp) return -ENOMEM; - memcpy(new_rcp, base_recipe, ICE_RECIPE_LEN); + memcpy(new_rcp, base_recipe, sizeof(*new_rcp)); new_rcp->content.act_ctrl_fwd_priority = prio; new_rcp->content.rid = *rid | ICE_AQ_RECIPE_ID_IS_ROOT; new_rcp->recipe_indx = *rid;