From: Jakub Kicinski <kuba@kernel.org>
To: fffsqian@163.com
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH v3] selftests: net: broadcast_pmtu: Fix false failure from incorrect ping exit code logic
Date: Fri, 27 Mar 2026 07:47:23 -0700 [thread overview]
Message-ID: <20260327074723.26e086d8@kernel.org> (raw)
In-Reply-To: <20260327012705.2389814-1-fffsqian@163.com>
On Fri, 27 Mar 2026 09:27:05 +0800 fffsqian@163.com wrote:
> The broadcast_pmtu.sh test verifies that broadcast route MTU is respected,
> but it uses an incorrect criteria for test success: it relies solely on
> the ping command's exit code, which leads to false failures.
>
> When the kernel correctly blocks oversized broadcast packets due to the
> configured MTU limit (1500), ping fails to transmit any packets and returns
> exit code 1. The original script interprets this as a test failure, even
> though the kernel is properly enforcing the MTU (the core goal of the test).
>
> Fix this by checking ping's output for "0 packets transmitted" or
> "message too long" instead of relying on exit code.
Still failing, are you testing this locally before you repost it?
Does it pass for you?
Please do not post another version until someone asks for it.
prev parent reply other threads:[~2026-03-27 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 1:27 [PATCH v3] selftests: net: broadcast_pmtu: Fix false failure from incorrect ping exit code logic fffsqian
2026-03-27 14:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327074723.26e086d8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fffsqian@163.com \
--cc=fuqingshuang@kylinos.cn \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox