From: Jakub Kicinski <kuba@kernel.org>
To: Martin Schiller <ms@dev.tdt.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Yiming Qian <yimingqian591@gmail.com>,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH net] net/x25: Fix overflow when accumulating packets
Date: Fri, 27 Mar 2026 17:33:23 -0700 [thread overview]
Message-ID: <20260327173323.4f4783df@kernel.org> (raw)
In-Reply-To: <b2099069e5dce49a0bc068a8d318f3a2@dev.tdt.de>
On Fri, 27 Mar 2026 09:36:00 +0100 Martin Schiller wrote:
> > + /* make sure we don't overflow */
> > + if (x25->fraglen + skb->len > sizeof(x25->fraglen)) {
>
> Please ignore this patch. I'll send a V2 without that
> "sizeof()" nonsense in a moment.
We ask that submitters wait 24h before reposting:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
--
pv-bot: 24h
prev parent reply other threads:[~2026-03-28 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 8:30 [PATCH net] net/x25: Fix overflow when accumulating packets Martin Schiller
2026-03-27 8:36 ` Martin Schiller
2026-03-28 0:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327173323.4f4783df@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=security@kernel.org \
--cc=yimingqian591@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox