From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A409B249EB; Sun, 29 Mar 2026 22:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774822352; cv=none; b=Rpn/id/9dG4ryRas9U+FDHckiiz26zbW2GmoCg18JR0m4zVy88q/pS/8Bu6t0Sq5Qwaefy9cXmd7V36pgknAKF+GRnI0L+JbKHp0uNmLnqMikLoKuDNr6UlrswbozIC7DqzRvRgCRNm31pmQ+z9ky2hbbTQfbjENecPE/kXIwg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774822352; c=relaxed/simple; bh=7gR/RhLuywXK4z4Yd7rCJo6vYLWYlNMRRVny8ORRdmE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sEZlh23Ct0XACvl0VXRK8261AHXyvFkS9dB/TRC9aK3MFCNyArpoq9FLxSBDD7kqtwoxgtBNh914MNsUDJBDILlbWQM6Jaf5K9NLyOAS5vveoh2FAVl16cE3LHDBBC4lFfdRDnu05ubOJwVRJcE06xtKEXvn9rc1/6IwCG7A5qw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h5IAqs9a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h5IAqs9a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88472C116C6; Sun, 29 Mar 2026 22:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774822352; bh=7gR/RhLuywXK4z4Yd7rCJo6vYLWYlNMRRVny8ORRdmE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h5IAqs9aCMRjB/2oTjfgQE8t6j2fyW3/y1ZVHXTY7wP7YvgmgSwDKhka2H7txuDg3 wdsUP2tFb55Vts1gih6NRtIQsbi2462x9+pKUx0OUSpMLYLRjM8yhu9hPSpq5rKEU0 KP03EQSTMvivYq7c+q7NCZZa7LQVh3efCvwXC82WIFxZzgqAF3cmFwlyCAKlVyc+vO q1MqVx2yBwtko2leztRX0NY4sAbEowbq5C0o9KeR3YmdO/qPwFOEG8qpD6LW3k5Fxp GFC+W6q+iEmn3xmVSIYXQbi2fgZo4o9dYrXXMFC50z7IcooaqfOLF8nNWEwVIooc41 hz8/onyrdBuTA== Date: Sun, 29 Mar 2026 15:12:30 -0700 From: Jakub Kicinski To: Joe Damato Cc: netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, bpf@vger.kernel.org Subject: Re: [net-next v6 07/12] net: bnxt: Add boilerplate GSO code Message-ID: <20260329151230.7acacbb9@kernel.org> In-Reply-To: <20260326235238.2940471-8-joe@dama.to> References: <20260326235238.2940471-1-joe@dama.to> <20260326235238.2940471-8-joe@dama.to> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 26 Mar 2026 16:52:26 -0700 Joe Damato wrote: > @@ -891,6 +891,7 @@ struct bnxt_sw_tx_bd { > u8 is_ts_pkt; > u8 is_push; > u8 action; > + u8 is_sw_gso; > unsigned short nr_frags; nit: maybe group the is_* together, IOW move new fields before @action?