From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <joe@dama.to>
Cc: netdev@vger.kernel.org, Michael Chan <michael.chan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
andrew+netdev@lunn.ch, horms@kernel.org,
pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org,
leon@kernel.org
Subject: Re: [net-next v6 08/12] net: bnxt: Implement software USO
Date: Sun, 29 Mar 2026 15:20:16 -0700 [thread overview]
Message-ID: <20260329152016.27646fab@kernel.org> (raw)
In-Reply-To: <20260326235238.2940471-9-joe@dama.to>
On Thu, 26 Mar 2026 16:52:27 -0700 Joe Damato wrote:
> + /* Upper bound on the number of descriptors needed.
> + *
> + * Each segment uses 1 long BD + 1 ext BD + payload BDs, which is
> + * at most num_segs + nr_frags (each frag boundary crossing adds at
> + * most 1 extra BD).
> + */
> + bds_needed = 3 * num_segs + skb_shinfo(skb)->nr_frags + 1;
> +
> + if (unlikely(bnxt_tx_avail(bp, txr) < bds_needed)) {
> + netif_txq_try_stop(txq, bnxt_tx_avail(bp, txr),
> + bp->tx_wake_thresh);
> + return NETDEV_TX_BUSY;
> + }
> +
> + slots = BNXT_SW_USO_MAX_SEGS - (txr->tx_inline_prod - txr->tx_inline_cons);
> +
> + if (unlikely(slots < num_segs)) {
> + netif_txq_try_stop(txq, bnxt_tx_avail(bp, txr),
This looks sus, try_stop() will evaluate the bnxt_tx_avail(bp, txr)
and leave the ring running.
> + bp->tx_wake_thresh);
Is tx_wake_thresh larger than the max USO even for smallest ring size?
next prev parent reply other threads:[~2026-03-29 22:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 23:52 [net-next v6 00/12] Add TSO map-once DMA helpers and bnxt SW USO support Joe Damato
2026-03-26 23:52 ` [net-next v6 01/12] net: tso: Introduce tso_dma_map Joe Damato
2026-03-29 22:11 ` Jakub Kicinski
2026-03-26 23:52 ` [net-next v6 02/12] net: tso: Add tso_dma_map helpers Joe Damato
2026-03-26 23:52 ` [net-next v6 03/12] net: bnxt: Export bnxt_xmit_get_cfa_action Joe Damato
2026-03-26 23:52 ` [net-next v6 04/12] net: bnxt: Add a helper for tx_bd_ext Joe Damato
2026-03-26 23:52 ` [net-next v6 05/12] net: bnxt: Use dma_unmap_len for TX completion unmapping Joe Damato
2026-03-26 23:52 ` [net-next v6 06/12] net: bnxt: Add TX inline buffer infrastructure Joe Damato
2026-03-26 23:52 ` [net-next v6 07/12] net: bnxt: Add boilerplate GSO code Joe Damato
2026-03-29 22:12 ` Jakub Kicinski
2026-03-26 23:52 ` [net-next v6 08/12] net: bnxt: Implement software USO Joe Damato
2026-03-29 22:20 ` Jakub Kicinski [this message]
2026-03-26 23:52 ` [net-next v6 09/12] net: bnxt: Add SW GSO completion and teardown support Joe Damato
2026-03-29 22:22 ` Jakub Kicinski
2026-03-26 23:52 ` [net-next v6 10/12] net: bnxt: Dispatch to SW USO Joe Damato
2026-03-26 23:52 ` [net-next v6 11/12] net: netdevsim: Add support for " Joe Damato
2026-03-29 22:26 ` Jakub Kicinski
2026-03-26 23:52 ` [net-next v6 12/12] selftests: drv-net: Add USO test Joe Damato
2026-03-29 22:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260329152016.27646fab@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox