From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7E773E557C for ; Mon, 30 Mar 2026 23:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774911782; cv=none; b=BvgxXt8JI5u0XZ3WXZR7hgcj4L1WgHLFoPYrfVYxnEVlGtYtvR7jIDWCvcxBdTsDWO158dA3rjz/zTSKwpwI8+Gqyindhm7Prfn59cC6fCUZdNd0ac2MXsektFpC24IrkfsTALBRShIDH1aZQelN58qAhOmvuBGIqs8WAMGJnRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774911782; c=relaxed/simple; bh=vq+z8ImethqaZptbUjYXswqoBYsbAhgZEkNr+xaCQ50=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BMc0peOD/WhOz5nhrL2SAp2pM0OWfJSK4LsmriJuFIh8owMrUgXYLMk/1XFz2X/qoDBZVzh5uycHx6gD32sOuEz8rCR97sMcqGyeIfnxX27FiNfX9QJfVdCxjFrgrzsyITlIq9KbQD/E5OoYbl3NCXIR6asl7lXWWmvmGFNiYU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WSMygijK; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WSMygijK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774911782; x=1806447782; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vq+z8ImethqaZptbUjYXswqoBYsbAhgZEkNr+xaCQ50=; b=WSMygijK1sAaB2ihNyaYD9mZUHf0cz5CCXZT0J7fAqnqnLQ7KBKGMgEH 0rtZlKMJxKkHdIfLIMXGF6BlAx9dtAmklsRn9vJkKkghji6uivnISrDBp GbVVn9dilMkWePYXtDIsXpkuEAu4oNXzoTP1vIZ8Y2A6zRrS+764HHaJQ DAlEgt0cHfw2Io+idHCvN+prdVe+aidPkJeiWHV/w4d+Z1Z2HpVde/mYA uKyzyMbrYeNBTK9mJwsHckLsTGFsQgDxT4jBMjmL++GqXvzpd9FVRmnst xR007Ck/+q89D6Ekh0om/N3eVr3T3hgNXZevoFo4uXZeFNIyq+yG9nZGY w==; X-CSE-ConnectionGUID: aC5feQEWQQWoSFZgkcswwQ== X-CSE-MsgGUID: 1VPVi64NTKSfICqdjMDjrA== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="93297658" X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="93297658" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 16:02:54 -0700 X-CSE-ConnectionGUID: JNCkhAZNSFiCULbm1A8trA== X-CSE-MsgGUID: Y1TBDN6xRwO6baWBNANQXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="256687750" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa002.jf.intel.com with ESMTP; 30 Mar 2026 16:02:54 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Jacob Keller , anthony.l.nguyen@intel.com, Aleksandr Loktionov , Przemek Kitszel , Simon Horman Subject: [PATCH net-next 14/15] ice: mention fw_activate action along with devlink reload Date: Mon, 30 Mar 2026 16:02:43 -0700 Message-ID: <20260330230248.646900-15-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260330230248.646900-1-anthony.l.nguyen@intel.com> References: <20260330230248.646900-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jacob Keller The ice driver reports a helpful status message when updating firmware indicating what action is necessary to enable the new firmware. This is done because some updates require power cycling or rebooting the machine but some can be activated via devlink. The ice driver only supports activating firmware with the specific action of "fw_activate" a bare "devlink dev reload" will *not* update the firmware, and will only perform driver reinitialization. Update the status message to explicitly reflect that the reload must use the fw_activate action. I considered modifying the text to spell out the full command, but felt that was both overkill and something that would belong better as part of the user space program and not hard coded into the kernel driver output. Signed-off-by: Jacob Keller Reviewed-by: Aleksandr Loktionov Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/net/ethernet/intel/ice/ice_fw_update.c index c143e546dd8c..36314610927b 100644 --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c @@ -726,7 +726,7 @@ static int ice_finalize_update(struct pldmfw *context) switch (priv->reset_level) { case ICE_AQC_NVM_EMPR_FLAG: devlink_flash_update_status_notify(devlink, - "Activate new firmware by devlink reload", + "Activate new firmware by devlink reload action fw_activate", NULL, 0, 0); break; case ICE_AQC_NVM_PERST_FLAG: -- 2.47.1