From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch,
netdev@vger.kernel.org
Cc: Takashi Kozu <takkozu@amazon.com>,
anthony.l.nguyen@intel.com, horms@kernel.org, enjuk@amazon.com,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Rinitha S <sx.rinitha@intel.com>
Subject: [PATCH net-next 08/15] igb: expose RSS key via ethtool get_rxfh
Date: Mon, 30 Mar 2026 16:02:37 -0700 [thread overview]
Message-ID: <20260330230248.646900-9-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20260330230248.646900-1-anthony.l.nguyen@intel.com>
From: Takashi Kozu <takkozu@amazon.com>
Implement igb_get_rxfh_key_size() and extend
igb_get_rxfh() to return the RSS key to userspace.
This can be tested using `ethtool -x <dev>`.
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Takashi Kozu <takkozu@amazon.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 9a105e59f432..47fc620026a9 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -3297,10 +3297,12 @@ static int igb_get_rxfh(struct net_device *netdev,
int i;
rxfh->hfunc = ETH_RSS_HASH_TOP;
- if (!rxfh->indir)
- return 0;
- for (i = 0; i < IGB_RETA_SIZE; i++)
- rxfh->indir[i] = adapter->rss_indir_tbl[i];
+ if (rxfh->indir)
+ for (i = 0; i < IGB_RETA_SIZE; i++)
+ rxfh->indir[i] = adapter->rss_indir_tbl[i];
+
+ if (rxfh->key)
+ memcpy(rxfh->key, adapter->rss_key, sizeof(adapter->rss_key));
return 0;
}
@@ -3340,6 +3342,11 @@ void igb_write_rss_indir_tbl(struct igb_adapter *adapter)
}
}
+static u32 igb_get_rxfh_key_size(struct net_device *netdev)
+{
+ return IGB_RSS_KEY_SIZE;
+}
+
static int igb_set_rxfh(struct net_device *netdev,
struct ethtool_rxfh_param *rxfh,
struct netlink_ext_ack *extack)
@@ -3504,6 +3511,7 @@ static const struct ethtool_ops igb_ethtool_ops = {
.get_module_eeprom = igb_get_module_eeprom,
.get_rxfh_indir_size = igb_get_rxfh_indir_size,
.get_rxfh = igb_get_rxfh,
+ .get_rxfh_key_size = igb_get_rxfh_key_size,
.set_rxfh = igb_set_rxfh,
.get_rxfh_fields = igb_get_rxfh_fields,
.set_rxfh_fields = igb_set_rxfh_fields,
--
2.47.1
next prev parent reply other threads:[~2026-03-30 23:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 23:02 [PATCH net-next 00/15][pull request] Intel Wired LAN Driver Updates 2026-03-30 (igc, igb, ice) Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 01/15] igc: Call netif_queue_set_napi() with rtnl locked Tony Nguyen
2026-03-31 17:37 ` Bjorn Helgaas
2026-04-02 10:29 ` Paolo Abeni
2026-03-30 23:02 ` [PATCH net-next 02/15] igc: Let the PCI core deal with the PM resume flow Tony Nguyen
2026-03-31 17:34 ` Bjorn Helgaas
2026-03-30 23:02 ` [PATCH net-next 03/15] igc: Don't reset the hardware on suspend path Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 04/15] igc: prepare for RSS key get/set support Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 05/15] igc: expose RSS key via ethtool get_rxfh Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 06/15] igc: allow configuring RSS key via ethtool set_rxfh Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 07/15] igb: prepare for RSS key get/set support Tony Nguyen
2026-03-30 23:02 ` Tony Nguyen [this message]
2026-03-30 23:02 ` [PATCH net-next 09/15] igb: allow configuring RSS key via ethtool set_rxfh Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 10/15] igb: set skb hash type from RSS_TYPE Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 11/15] igb: fix typos in comments Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 12/15] igc: " Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 13/15] ice: add support for unmanaged DPLL on E830 NIC Tony Nguyen
2026-04-02 10:26 ` [net-next,13/15] " Paolo Abeni
2026-04-03 15:44 ` Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 14/15] ice: mention fw_activate action along with devlink reload Tony Nguyen
2026-03-30 23:02 ` [PATCH net-next 15/15] ice: dpll: Fix compilation warning Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330230248.646900-9-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sx.rinitha@intel.com \
--cc=takkozu@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox