[PATCH net-next] pppoe: update Kconfig URLs

[PATCH net-next] pppoe: update Kconfig URLs

[Qingfang Deng]

Both links are no longer valid. Update them to the correct URLs.

Signed-off-by: Qingfang Deng <dqfext@gmail.com>
---
 drivers/net/ppp/Kconfig | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
index a1806b4b84be..c751959c53a1 100644
--- a/drivers/net/ppp/Kconfig
+++ b/drivers/net/ppp/Kconfig
@@ -122,11 +122,10 @@ config PPPOE
 	help
 	  Support for PPP over Ethernet.
 
-	  This driver requires the latest version of pppd from the CVS
-	  repository at cvs.samba.org.  Alternatively, see the
-	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
-	  which contains instruction on how to use this driver (under
-	  the heading "Kernel mode PPPoE").
+	  This driver requires the latest version of pppd at
+	  <https://ppp.samba.org>.
+	  Alternatively, see the out-of-tree RP-PPPoE plugin at
+	  <https://dianne.skoll.ca/projects/rp-pppoe/>.
 
 choice
 	prompt "Number of PPPoE hash bits"
-- 
2.43.0

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Jaco Kroon]

Hi,

On 2026/03/31 05:33, Qingfang Deng wrote:
> Both links are no longer valid. Update them to the correct URLs.
>
> Signed-off-by: Qingfang Deng <dqfext@gmail.com>
> ---
>   drivers/net/ppp/Kconfig | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
> index a1806b4b84be..c751959c53a1 100644
> --- a/drivers/net/ppp/Kconfig
> +++ b/drivers/net/ppp/Kconfig
> @@ -122,11 +122,10 @@ config PPPOE
>   	help
>   	  Support for PPP over Ethernet.
>   
> -	  This driver requires the latest version of pppd from the CVS
> -	  repository at cvs.samba.org.  Alternatively, see the
> -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
> -	  which contains instruction on how to use this driver (under
> -	  the heading "Kernel mode PPPoE").
> +	  This driver requires the latest version of pppd at
> +	  <https://ppp.samba.org>.
> +	  Alternatively, see the out-of-tree RP-PPPoE plugin at
> +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.

ppp now exclusively has the plugin code (originally from roaring penguin 
I believe).  Latest version is no longer relevant, that plugin has been 
available since at least a few versions back already (at least a decade, 
probably closer to two).

That same code has recently been dropped from rp-pppoe, which now 
primarily focusses on pppoe-server, and relies on the plugin now part of 
ppp package itself. rp-pppoe is only required if you're running a 
pppoe-server, and I don't think rp-pppoe at this stage will function 
without ppp.

Most people will never need rp-pppoe.

Kind regards,
Jaco


>   
>   choice
>   	prompt "Number of PPPoE hash bits"

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Qingfang Deng]

Hi,

On Tue, 31 Mar 2026 08:21:40 +0200, Jaco Kroon wrote:
>
> On 2026/03/31 05:33, Qingfang Deng wrote:
> >
> > --- a/drivers/net/ppp/Kconfig
> > +++ b/drivers/net/ppp/Kconfig
> > @@ -122,11 +122,10 @@ config PPPOE
> >   	help
> >   	  Support for PPP over Ethernet.
> >   
> > -	  This driver requires the latest version of pppd from the CVS
> > -	  repository at cvs.samba.org.  Alternatively, see the
> > -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
> > -	  which contains instruction on how to use this driver (under
> > -	  the heading "Kernel mode PPPoE").
> > +	  This driver requires the latest version of pppd at
> > +	  <https://ppp.samba.org>.
> > +	  Alternatively, see the out-of-tree RP-PPPoE plugin at
> > +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.
> 
> ppp now exclusively has the plugin code (originally from roaring penguin 
> I believe).  Latest version is no longer relevant, that plugin has been 
> available since at least a few versions back already (at least a decade, 
> probably closer to two).
>
> That same code has recently been dropped from rp-pppoe, which now 
> primarily focusses on pppoe-server, and relies on the plugin now part of 
> ppp package itself. rp-pppoe is only required if you're running a 
> pppoe-server, and I don't think rp-pppoe at this stage will function 
> without ppp.
> 
> Most people will never need rp-pppoe.

Thanks for the information.

I just checked pppd's changelog: version 2.4.2 or later has the PPPoE
plugin.

I can update the help message accordingly:

	  To work in client mode, pppd version 2.4.2 or later is
	  required. To work in server mode, the pppoe-server command
	  from the RP-PPPoE package is also required, available at
	  <https://dianne.skoll.ca/projects/rp-pppoe/>.

What do you think?

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Jaco Kroon]

Hi,

On 2026/03/31 09:54, Qingfang Deng wrote:
> Hi,
>
> On Tue, 31 Mar 2026 08:21:40 +0200, Jaco Kroon wrote:
>> On 2026/03/31 05:33, Qingfang Deng wrote:
>>> --- a/drivers/net/ppp/Kconfig
>>> +++ b/drivers/net/ppp/Kconfig
>>> @@ -122,11 +122,10 @@ config PPPOE
>>>    	help
>>>    	  Support for PPP over Ethernet.
>>>    
>>> -	  This driver requires the latest version of pppd from the CVS
>>> -	  repository at cvs.samba.org.  Alternatively, see the
>>> -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
>>> -	  which contains instruction on how to use this driver (under
>>> -	  the heading "Kernel mode PPPoE").
>>> +	  This driver requires the latest version of pppd at
>>> +	  <https://ppp.samba.org>.
>>> +	  Alternatively, see the out-of-tree RP-PPPoE plugin at
>>> +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.
>> ppp now exclusively has the plugin code (originally from roaring penguin
>> I believe).  Latest version is no longer relevant, that plugin has been
>> available since at least a few versions back already (at least a decade,
>> probably closer to two).
>>
>> That same code has recently been dropped from rp-pppoe, which now
>> primarily focusses on pppoe-server, and relies on the plugin now part of
>> ppp package itself. rp-pppoe is only required if you're running a
>> pppoe-server, and I don't think rp-pppoe at this stage will function
>> without ppp.
>>
>> Most people will never need rp-pppoe.
> Thanks for the information.
>
> I just checked pppd's changelog: version 2.4.2 or later has the PPPoE
> plugin.
>
> I can update the help message accordingly:
>
> 	  To work in client mode, pppd version 2.4.2 or later is
> 	  required. To work in server mode, the pppoe-server command
> 	  from the RP-PPPoE package is also required, available at
> 	  <https://dianne.skoll.ca/projects/rp-pppoe/>.

I like this.  You have however dropped the ppp.samba.org link, just 
re-add that I reckon.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>

For what my sign-off is worth in this case :).

Kind regards,
Jaco

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Qingfang Deng]

Hi,

On Tue, 31 Mar 2026 10:08:46 +0200, Jaco Kroon wrote:
> 
> I like this.  You have however dropped the ppp.samba.org link, just 
> re-add that I reckon.

I think this link belongs in the PPP section:

diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
index f57fba84fe55..cf927bdc288f 100644
--- a/drivers/net/ppp/Kconfig
+++ b/drivers/net/ppp/Kconfig
@@ -13,10 +13,9 @@ config PPP
 	  otherwise you can't use it; most Internet access providers these
 	  days support PPP rather than SLIP.
 
-	  To use PPP, you need an additional program called pppd as described
-	  in the PPP-HOWTO, available at
-	  <http://www.tldp.org/docs.html#howto>.  Make sure that you have
-	  the version of pppd recommended in <file:Documentation/Changes>.
+	  To use PPP, you need an additional program called pppd, available at
+	  <https://ppp.samba.org>.  Make sure that you have the version of pppd
+	  recommended in <file:Documentation/Changes>.
 	  The PPP option enlarges your kernel by about 16 KB.
 
 	  There are actually two versions of PPP: the traditional PPP for


Your thoughts?

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Dianne Skoll]

On Tue, 31 Mar 2026 08:21:40 +0200
Jaco Kroon <jaco@uls.co.za> wrote:

> That same code has recently been dropped from rp-pppoe,

That is not the case.  I still ship all of the plugin code with rp-pppoe.

> Most people will never need rp-pppoe.

This is correct because the ppp project *also* ships the plugin code.

Regards,

Dianne.

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Jaco Kroon]

Hi Dianne,

On 2026/03/31 15:16, Dianne Skoll wrote:
> On Tue, 31 Mar 2026 08:21:40 +0200
> Jaco Kroon <jaco@uls.co.za> wrote:
>
>> That same code has recently been dropped from rp-pppoe,
> That is not the case.  I still ship all of the plugin code with rp-pppoe.
My bad, my apologies.  It was the userspace code you dropped then, which 
does NOT require the kernel options?  I do recall there was a huge 
debate around this though in the one ppp bug.
>> Most people will never need rp-pppoe.
> This is correct because the ppp project *also* ships the plugin code.
Kind regards,
Jaco

Re: [PATCH net-next] pppoe: update Kconfig URLs

[Dianne Skoll]

Hi, all,

> My bad, my apologies. It was the userspace code you dropped then, which 
> does NOT require the kernel options?

I was considering doing that, but I kept the userspace code.  The reason is
that on some platforms, such as uclinux on a processor without an MMU,
the dlopen() system call is not implemented, so there's no way to use
a plugin with pppd.  One user asked me to keep the userspace code, so I
did.

But you are correct in that 99.99% of Linux users will not need to download
rp-pppoe if all they want to do is connect to the Internet using a PPPoE
client.

Regards,

Dianne.