From: Ido Schimmel <idosch@nvidia.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, sdf@fomichev.me, petrm@nvidia.com,
razor@blackwall.org, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch
Subject: Re: [PATCH net-next] net: vxlan: check ipv6_mod_enabled() on neigh_reduce()
Date: Tue, 31 Mar 2026 08:56:37 +0300 [thread overview]
Message-ID: <20260331055637.GA1497954@shredder> (raw)
In-Reply-To: <20260330121033.4479-1-fmancera@suse.de>
On Mon, Mar 30, 2026 at 02:10:33PM +0200, Fernando Fernandez Mancera wrote:
> IPv6 must be enabled or otherwise neigh_reduce() might cause a kernel
> panic. This was prevented by a check on in6_dev. Use ipv6_mod_enabled()
> instead as it is cleaner and also consistent with the code at
> route_shortcircuit().
>
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
I believe the RCU read-side critical section could be reduced a bit, but
it's not critical, so:
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-03-31 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 12:10 [PATCH net-next] net: vxlan: check ipv6_mod_enabled() on neigh_reduce() Fernando Fernandez Mancera
2026-03-31 5:56 ` Ido Schimmel [this message]
2026-04-01 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331055637.GA1497954@shredder \
--to=idosch@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox