public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Marc Harvey <marcharvey@google.com>
Cc: jiri@resnulli.us, andrew+netdev@lunn.ch, willemb@google.com,
	maheshb@google.com, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver
Date: Tue, 31 Mar 2026 10:33:08 -0700	[thread overview]
Message-ID: <20260331103308.421aac59@kernel.org> (raw)
In-Reply-To: <20260331053353.2504254-1-marcharvey@google.com>

On Tue, 31 Mar 2026 05:33:46 +0000 Marc Harvey wrote:
> Allow independent control over receive and transmit enablement states
> for aggregated ports in the team driver.
> 
> The motivation is that IEE 802.3ad LACP "independent control" can't
> be implemented for the team driver currently. This was added to the
> bonding driver in commit 240fd405528b ("bonding: Add independent
> control state machine").
> 
> This series also has a few patches that add tests to show that the old
> coupled enablement still works and that the new decoupled enalbment
> works as intended (4, 5, and 7).
> 
> There are three patches with small fixes as well, with the goal of
> making the final decouplement patch clearer (1, 2, and 3).

The tests don't pass for us, any dependencies we should be aware of?

# selftests: drivers/net/team: teamd_activebackup.sh
# Setting up two-link aggregation for runner activebackup
# Conf files are /tmp/tmp.zYDeygAAcf and /tmp/tmp.y5dfmFapAj
# This program is not intended to be run as root.
# This program is not intended to be run as root.
# Created team devices
# PING fd00::2 (fd00::2) 56 data bytes
# 64 bytes from fd00::2: icmp_seq=1 ttl=64 time=233 ms
# 
# --- fd00::2 ping statistics ---
# 1 packets transmitted, 1 received, 0% packet loss, time 0ms
# rtt min/avg/max/mdev = 233.163/233.163/233.163/0.000 ms/bin/bash: line 1: pv: command not found
# Packet count for test_team2 was 0
# Packet count for eth0 was 0
# Packet count for eth1 was 0
# Packet count for eth0 was 0
# Packet count for eth1 was 0
# TEST: teamd active backup runner test                               [FAIL]
# Traffic did not reach team interface in NS2.
# ./team_lib.sh: line 87: kill: (597) - No such process
# Tearing down two-link aggregation
# Failed to kill daemon: Timer expired
-- 
pw-bot: defer

  parent reply	other threads:[~2026-03-31 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  5:33 [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 1/7] net: team: Annotate reads and writes for mixed lock accessed values Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 2/7] net: team: Remove unused team_mode_op, port_enabled Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 3/7] net: team: Rename port_disabled team mode op to port_tx_disabled Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 4/7] selftests: net: Add tests for failover of team-aggregated ports Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 5/7] selftests: net: Add test for enablement of ports with teamd Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 6/7] net: team: Decouple rx and tx enablement in the team driver Marc Harvey
2026-03-31  5:33 ` [PATCH net-next 7/7] selftests: net: Add tests for team driver decoupled tx and rx control Marc Harvey
2026-03-31 17:33 ` Jakub Kicinski [this message]
2026-04-01  1:42   ` [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver Marc Harvey
2026-04-01  1:53     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331103308.421aac59@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=jiri@resnulli.us \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maheshb@google.com \
    --cc=marcharvey@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox