* [PATCH iwl-next v1 0/2] igb/igc: use napi_schedule_irqoff() instead of napi_schedule() @ 2026-03-31 10:39 Daiki Harada 2026-03-31 10:39 ` [PATCH iwl-next v1 1/2] igb: " Daiki Harada 2026-03-31 10:39 ` [PATCH iwl-next v1 2/2] igc: " Daiki Harada 0 siblings, 2 replies; 6+ messages in thread From: Daiki Harada @ 2026-03-31 10:39 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Daiki Harada This patch set is meant to replace the calls to napi_schedule with napi_schedule_irqoff as this should help to reduce the interrupt overhead slightly by removing the unneeded call to local_irq_save and local_irq_restore. In the interrupt path, callers of napi_schedule() are invoked with local IRQ disabled, so napi_schedule_irqoff() can be used instead. This series applies the same optimization that was done for other drivers in [1] to the igb/igc driver. Link: https://lore.kernel.org/intel-wired-lan/20150929215117.3388.48642.stgit@ahduyck-vm-fedora22/ [1] Daiki Harada (2): igb: use napi_schedule_irqoff() instead of napi_schedule() igc: use napi_schedule_irqoff() instead of napi_schedule() drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- drivers/net/ethernet/intel/igc/igc_main.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.53.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH iwl-next v1 1/2] igb: use napi_schedule_irqoff() instead of napi_schedule() 2026-03-31 10:39 [PATCH iwl-next v1 0/2] igb/igc: use napi_schedule_irqoff() instead of napi_schedule() Daiki Harada @ 2026-03-31 10:39 ` Daiki Harada 2026-04-01 7:52 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-03-31 10:39 ` [PATCH iwl-next v1 2/2] igc: " Daiki Harada 1 sibling, 1 reply; 6+ messages in thread From: Daiki Harada @ 2026-03-31 10:39 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Daiki Harada, Kohei Enju Replace napi_schedule() with napi_schedule_irqoff() in the interrupt handler path in igb driver Tested on QEMU with igb NIC emulation (-nic user,model=igb) Suggested-by: Kohei Enju <kohei@enjuk.jp> Signed-off-by: Daiki Harada <daiky0325@gmail.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index ee99fd8fd513..d7a6ae938cc5 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -7158,7 +7158,7 @@ static irqreturn_t igb_msix_ring(int irq, void *data) /* Write the ITR value calculated from the previous interrupt. */ igb_write_itr(q_vector); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } @@ -8199,7 +8199,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data) if (icr & E1000_ICR_TS) igb_tsync_interrupt(adapter); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } @@ -8245,7 +8245,7 @@ static irqreturn_t igb_intr(int irq, void *data) if (icr & E1000_ICR_TS) igb_tsync_interrupt(adapter); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: use napi_schedule_irqoff() instead of napi_schedule() 2026-03-31 10:39 ` [PATCH iwl-next v1 1/2] igb: " Daiki Harada @ 2026-04-01 7:52 ` Loktionov, Aleksandr 0 siblings, 0 replies; 6+ messages in thread From: Loktionov, Aleksandr @ 2026-04-01 7:52 UTC (permalink / raw) To: Daiki Harada, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Kohei Enju > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Daiki Harada > Sent: Tuesday, March 31, 2026 12:39 PM > To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn > <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni <pabeni@redhat.com>; Daiki Harada <daiky0325@gmail.com>; Kohei > Enju <kohei@enjuk.jp> > Subject: [Intel-wired-lan] [PATCH iwl-next v1 1/2] igb: use > napi_schedule_irqoff() instead of napi_schedule() > > Replace napi_schedule() with napi_schedule_irqoff() in the interrupt > handler path in igb driver > > Tested on QEMU with igb NIC emulation (-nic user,model=igb) > > Suggested-by: Kohei Enju <kohei@enjuk.jp> > Signed-off-by: Daiki Harada <daiky0325@gmail.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > b/drivers/net/ethernet/intel/igb/igb_main.c > index ee99fd8fd513..d7a6ae938cc5 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -7158,7 +7158,7 @@ static irqreturn_t igb_msix_ring(int irq, void > *data) > /* Write the ITR value calculated from the previous interrupt. > */ > igb_write_itr(q_vector); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > @@ -8199,7 +8199,7 @@ static irqreturn_t igb_intr_msi(int irq, void > *data) > if (icr & E1000_ICR_TS) > igb_tsync_interrupt(adapter); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > @@ -8245,7 +8245,7 @@ static irqreturn_t igb_intr(int irq, void *data) > if (icr & E1000_ICR_TS) > igb_tsync_interrupt(adapter); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > -- > 2.53.0 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH iwl-next v1 2/2] igc: use napi_schedule_irqoff() instead of napi_schedule() 2026-03-31 10:39 [PATCH iwl-next v1 0/2] igb/igc: use napi_schedule_irqoff() instead of napi_schedule() Daiki Harada 2026-03-31 10:39 ` [PATCH iwl-next v1 1/2] igb: " Daiki Harada @ 2026-03-31 10:39 ` Daiki Harada 2026-04-01 7:53 ` [Intel-wired-lan] " Loktionov, Aleksandr 1 sibling, 1 reply; 6+ messages in thread From: Daiki Harada @ 2026-03-31 10:39 UTC (permalink / raw) To: intel-wired-lan, netdev, linux-kernel Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Daiki Harada, Kohei Enju Replace napi_schedule() with napi_schedule_irqoff() in the interrupt handler path in igc driver Tested on Intel Corporation Ethernet Controller I226-V. Suggested-by: Kohei Enju <kohei@enjuk.jp> Signed-off-by: Daiki Harada <daiky0325@gmail.com> --- drivers/net/ethernet/intel/igc/igc_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 72bc5128d8b8..712605886104 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -5688,7 +5688,7 @@ static irqreturn_t igc_msix_ring(int irq, void *data) /* Write the ITR value calculated from the previous interrupt. */ igc_write_itr(q_vector); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } @@ -6059,7 +6059,7 @@ static irqreturn_t igc_intr_msi(int irq, void *data) if (icr & IGC_ICR_TS) igc_tsync_interrupt(adapter); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } @@ -6105,7 +6105,7 @@ static irqreturn_t igc_intr(int irq, void *data) if (icr & IGC_ICR_TS) igc_tsync_interrupt(adapter); - napi_schedule(&q_vector->napi); + napi_schedule_irqoff(&q_vector->napi); return IRQ_HANDLED; } -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use napi_schedule_irqoff() instead of napi_schedule() 2026-03-31 10:39 ` [PATCH iwl-next v1 2/2] igc: " Daiki Harada @ 2026-04-01 7:53 ` Loktionov, Aleksandr 2026-04-05 8:21 ` Ruinskiy, Dima 0 siblings, 1 reply; 6+ messages in thread From: Loktionov, Aleksandr @ 2026-04-01 7:53 UTC (permalink / raw) To: Daiki Harada, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Kohei Enju > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Daiki Harada > Sent: Tuesday, March 31, 2026 12:39 PM > To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn > <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni <pabeni@redhat.com>; Daiki Harada <daiky0325@gmail.com>; Kohei > Enju <kohei@enjuk.jp> > Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use > napi_schedule_irqoff() instead of napi_schedule() > > Replace napi_schedule() with napi_schedule_irqoff() in the interrupt > handler path in igc driver Tested on Intel Corporation Ethernet > Controller I226-V. > > Suggested-by: Kohei Enju <kohei@enjuk.jp> > Signed-off-by: Daiki Harada <daiky0325@gmail.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c > b/drivers/net/ethernet/intel/igc/igc_main.c > index 72bc5128d8b8..712605886104 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -5688,7 +5688,7 @@ static irqreturn_t igc_msix_ring(int irq, void > *data) > /* Write the ITR value calculated from the previous interrupt. > */ > igc_write_itr(q_vector); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > @@ -6059,7 +6059,7 @@ static irqreturn_t igc_intr_msi(int irq, void > *data) > if (icr & IGC_ICR_TS) > igc_tsync_interrupt(adapter); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > @@ -6105,7 +6105,7 @@ static irqreturn_t igc_intr(int irq, void *data) > if (icr & IGC_ICR_TS) > igc_tsync_interrupt(adapter); > > - napi_schedule(&q_vector->napi); > + napi_schedule_irqoff(&q_vector->napi); > > return IRQ_HANDLED; > } > -- > 2.53.0 Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use napi_schedule_irqoff() instead of napi_schedule() 2026-04-01 7:53 ` [Intel-wired-lan] " Loktionov, Aleksandr @ 2026-04-05 8:21 ` Ruinskiy, Dima 0 siblings, 0 replies; 6+ messages in thread From: Ruinskiy, Dima @ 2026-04-05 8:21 UTC (permalink / raw) To: Loktionov, Aleksandr, Daiki Harada, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Kohei Enju On 01/04/2026 10:53, Loktionov, Aleksandr wrote: > > >> -----Original Message----- >> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf >> Of Daiki Harada >> Sent: Tuesday, March 31, 2026 12:39 PM >> To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, >> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn >> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric >> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo >> Abeni <pabeni@redhat.com>; Daiki Harada <daiky0325@gmail.com>; Kohei >> Enju <kohei@enjuk.jp> >> Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use >> napi_schedule_irqoff() instead of napi_schedule() >> >> Replace napi_schedule() with napi_schedule_irqoff() in the interrupt >> handler path in igc driver Tested on Intel Corporation Ethernet >> Controller I226-V. >> >> Suggested-by: Kohei Enju <kohei@enjuk.jp> >> Signed-off-by: Daiki Harada <daiky0325@gmail.com> >> --- >> drivers/net/ethernet/intel/igc/igc_main.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c >> b/drivers/net/ethernet/intel/igc/igc_main.c >> index 72bc5128d8b8..712605886104 100644 >> --- a/drivers/net/ethernet/intel/igc/igc_main.c >> +++ b/drivers/net/ethernet/intel/igc/igc_main.c >> @@ -5688,7 +5688,7 @@ static irqreturn_t igc_msix_ring(int irq, void >> *data) >> /* Write the ITR value calculated from the previous interrupt. >> */ >> igc_write_itr(q_vector); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> @@ -6059,7 +6059,7 @@ static irqreturn_t igc_intr_msi(int irq, void >> *data) >> if (icr & IGC_ICR_TS) >> igc_tsync_interrupt(adapter); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> @@ -6105,7 +6105,7 @@ static irqreturn_t igc_intr(int irq, void *data) >> if (icr & IGC_ICR_TS) >> igc_tsync_interrupt(adapter); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> -- >> 2.53.0 > > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> > Reviewed-by: Dima Ruinskiy <dima.ruinskiy@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-05 8:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-31 10:39 [PATCH iwl-next v1 0/2] igb/igc: use napi_schedule_irqoff() instead of napi_schedule() Daiki Harada 2026-03-31 10:39 ` [PATCH iwl-next v1 1/2] igb: " Daiki Harada 2026-04-01 7:52 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-03-31 10:39 ` [PATCH iwl-next v1 2/2] igc: " Daiki Harada 2026-04-01 7:53 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-04-05 8:21 ` Ruinskiy, Dima
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox