From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4263C40244F; Tue, 31 Mar 2026 15:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969373; cv=none; b=N4XtNC7V87HE4ACFl4GjrP23uXLp6zkxZ+GPXqqpqrg/shjw0cI+Os9apzjecJmejplrd5IQCTlUvynPlYiErFEJ6tOAxWWt3cat/HZBEFD8dJLrqlueTWq1ujzi55KwhJ00KQZE/sc9GV25BeHMOzBfewUcwpNNzpN7D0aiArw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969373; c=relaxed/simple; bh=WqEK/4h9ymztvrfhwLyCOfK1llcjY3+wVbom01OjhWA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ekgZNy2yQPnWvuR0Wmho6tf/Ip7n0EbWbRLG12w4cN1VbGhcQPqBhHYV7CmnM2LXw5BMIuer3SPPBrMdu4mCIihoOseaexkwgOdItU6HuL1RJzWlVxAaLwGRoPTj8go3m7aI6OTSfdTKnBklzJ0rdncCRYOKFx9kI4KRGwRKaj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ifdNMVYl; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ifdNMVYl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774969372; x=1806505372; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WqEK/4h9ymztvrfhwLyCOfK1llcjY3+wVbom01OjhWA=; b=ifdNMVYlBmPChxjfBNzW0AdeTOQCgZ5DoEmGY1UfXOMQU9Nw0fnB8MWl 2O1hLrotFal/DpmtGsPPOj9q1f3FgRZh//SgoD3EyiHvcI16If22z9VXR zrdSeJJHE7DWozHL5vUqV8eck7UY9r+hKPkjPsCPofSctbsD0lxX3zHi8 zt1YKxxL1rRChqDpGSRSw6GIA7oNYmYq5JuloiQPq072idEW5WhTu7ALt hGY/VfKPR1x8PyhviEefhWmaxgvDuXjz5+gFul17S5HCE+537wtn9i1nM hgyf/mau9uQJfF5QgXYS262z3ikt7hCYZWtpCBcwiiZnifhXA1Ew3lPJL A==; X-CSE-ConnectionGUID: 7tpYFmRUQJeaOmuRgJeFUQ== X-CSE-MsgGUID: nJF/krruSUCnCZpUpONG+g== X-IronPort-AV: E=McAfee;i="6800,10657,11745"; a="76046231" X-IronPort-AV: E=Sophos;i="6.23,152,1770624000"; d="scan'208";a="76046231" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 08:02:50 -0700 X-CSE-ConnectionGUID: 6YEBjkpgTju/NU7X8OgMlA== X-CSE-MsgGUID: AFDM/9i+TZGmB1fFNSof8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,152,1770624000"; d="scan'208";a="219735663" Received: from boxer.igk.intel.com ([10.102.20.173]) by fmviesa009.fm.intel.com with ESMTP; 31 Mar 2026 08:02:47 -0700 From: Maciej Fijalkowski To: netdev@vger.kernel.org Cc: bpf@vger.kernel.org, magnus.karlsson@intel.com, stfomichev@gmail.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, larysa.zaremba@intel.com, aleksander.lobakin@intel.com, bjorn@kernel.org, Maciej Fijalkowski , Joshua Washington Subject: [PATCH v5 net 11/11] gve: remove home-grown xsk's frame size validation Date: Tue, 31 Mar 2026 17:02:13 +0200 Message-Id: <20260331150213.550797-12-maciej.fijalkowski@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20260331150213.550797-1-maciej.fijalkowski@intel.com> References: <20260331150213.550797-1-maciej.fijalkowski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since this check is now present in core in xp_assign_dev(), remove redundant statement from gve_xsk_pool_enable(). Reviewed-by: Joshua Washington Reviewed-by: Björn Töpel Signed-off-by: Maciej Fijalkowski --- drivers/net/ethernet/google/gve/gve_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index 9eb4b3614c4f..b63e0a0459fb 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -1596,11 +1596,6 @@ static int gve_xsk_pool_enable(struct net_device *dev, dev_err(&priv->pdev->dev, "xsk pool invalid qid %d", qid); return -EINVAL; } - if (xsk_pool_get_rx_frame_size(pool) < - priv->dev->max_mtu + sizeof(struct ethhdr)) { - dev_err(&priv->pdev->dev, "xsk pool frame_len too small"); - return -EINVAL; - } err = xsk_pool_dma_map(pool, &priv->pdev->dev, DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING); -- 2.43.0