From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <joe@dama.to>
Cc: Wang Jun <1742789905@qq.com>,
Jes Sorensen <jes@trained-monkey.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-acenic@sunsite.dk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gszhai@bjtu.edu.cn,
25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn,
stable@vger.kernel.org
Subject: Re: [PATCH] net: alteon: Add missing DMA mapping error checks in ace_start_xmit
Date: Tue, 31 Mar 2026 18:41:44 -0700 [thread overview]
Message-ID: <20260331184144.7643062f@kernel.org> (raw)
In-Reply-To: <acxcGhzbNsHdK49W@devvm20253.cco0.facebook.com>
On Tue, 31 Mar 2026 16:43:22 -0700 Joe Damato wrote:
> On Tue, Mar 31, 2026 at 09:48:41AM +0800, Wang Jun wrote:
> > The ace_start_xmit function does not check the return value of
> > dma_map_page (via ace_map_tx_skb) and skb_frag_dma_map when building
> > transmit descriptors. If mapping fails, an invalid DMA address is
> > written to the descriptor, which may cause hardware to access
> > illegal memory, leading to system instability or crashes.
> >
> > Add proper dma_mapping_error() checks for all mapping calls. When
> > mapping fails, free the skb, increment the dropped packet counter,
> > and return NETDEV_TX_OK.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> Is this fixing a bug you've seen in the wild? If not, I'd probably drop the
> fixes tag and send this to net-next instead.
Either it's worth fixing in net or its not worth fixing at all.
My preference would be to try to delete this driver completely.
next prev parent reply other threads:[~2026-04-01 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 1:48 [PATCH] net: alteon: Add missing DMA mapping error checks in ace_start_xmit Wang Jun
2026-03-31 23:43 ` Joe Damato
2026-04-01 1:41 ` Jakub Kicinski [this message]
2026-04-01 19:15 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331184144.7643062f@kernel.org \
--to=kuba@kernel.org \
--cc=1742789905@qq.com \
--cc=23120469@bjtu.edu.cn \
--cc=25125283@bjtu.edu.cn \
--cc=25125332@bjtu.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gszhai@bjtu.edu.cn \
--cc=jes@trained-monkey.org \
--cc=joe@dama.to \
--cc=linux-acenic@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox