From: Jakub Kicinski <kuba@kernel.org>
To: Marc Harvey <marcharvey@google.com>
Cc: jiri@resnulli.us, andrew+netdev@lunn.ch, willemb@google.com,
maheshb@google.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver
Date: Tue, 31 Mar 2026 18:53:56 -0700 [thread overview]
Message-ID: <20260331185356.572493d5@kernel.org> (raw)
In-Reply-To: <CANkEMgkMRmyi3y-PdVTN66FHSrEO=neCp1N8PWbBrSA0yfDAzQ@mail.gmail.com>
On Tue, 31 Mar 2026 18:42:26 -0700 Marc Harvey wrote:
> On Tue, Mar 31, 2026 at 10:33 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 31 Mar 2026 05:33:46 +0000 Marc Harvey wrote:
> > > Allow independent control over receive and transmit enablement states
> > > for aggregated ports in the team driver.
> > >
> > > The motivation is that IEE 802.3ad LACP "independent control" can't
> > > be implemented for the team driver currently. This was added to the
> > > bonding driver in commit 240fd405528b ("bonding: Add independent
> > > control state machine").
> > >
> > > This series also has a few patches that add tests to show that the old
> > > coupled enablement still works and that the new decoupled enalbment
> > > works as intended (4, 5, and 7).
> > >
> > > There are three patches with small fixes as well, with the goal of
> > > making the final decouplement patch clearer (1, 2, and 3).
> >
> > The tests don't pass for us, any dependencies we should be aware of?
>
> Ah, I added a check for this using the `require_command` function, but
> it seems I used it incorrectly. I will fix this in v2, and probably
> remove the pv dependency altogether.
Instead of adding require_command - please use socat if you can?
pv is frankly highly unusual, most system images won't have it
installed. nc has multiple incompatible implementations so it's
a portability nightmare.
prev parent reply other threads:[~2026-04-01 1:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 5:33 [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 1/7] net: team: Annotate reads and writes for mixed lock accessed values Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 2/7] net: team: Remove unused team_mode_op, port_enabled Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 3/7] net: team: Rename port_disabled team mode op to port_tx_disabled Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 4/7] selftests: net: Add tests for failover of team-aggregated ports Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 5/7] selftests: net: Add test for enablement of ports with teamd Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 6/7] net: team: Decouple rx and tx enablement in the team driver Marc Harvey
2026-03-31 5:33 ` [PATCH net-next 7/7] selftests: net: Add tests for team driver decoupled tx and rx control Marc Harvey
2026-03-31 17:33 ` [PATCH net-next 0/7] Decouple receive and transmit enablement in team driver Jakub Kicinski
2026-04-01 1:42 ` Marc Harvey
2026-04-01 1:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331185356.572493d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=jiri@resnulli.us \
--cc=linux-kselftest@vger.kernel.org \
--cc=maheshb@google.com \
--cc=marcharvey@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox