From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: "Paolo Valerio" <pvalerio@redhat.com>,
"Conor Dooley" <conor@kernel.org>,
"Nicolai Buchwitz" <nb@tipi-net.de>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Théo Lebrun" <theo.lebrun@bootlin.com>
Subject: [PATCH net-next 11/11] net: macb: use context swapping in .ndo_change_mtu()
Date: Wed, 01 Apr 2026 18:39:14 +0200 [thread overview]
Message-ID: <20260401-macb-context-v1-11-9590c5ab7272@bootlin.com> (raw)
In-Reply-To: <20260401-macb-context-v1-0-9590c5ab7272@bootlin.com>
Use newly introduced context buffer management to implement
.ndo_change_mtu() as a context swap: allocate new context ->
reconfigure HW -> free old context.
This resists memory pressure well by failing without closing the
interface and it is much faster by avoiding PHY reinit.
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
drivers/net/ethernet/cadence/macb_main.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 543356554c11..e10791bf1f4d 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3438,11 +3438,25 @@ static int macb_close(struct net_device *netdev)
static int macb_change_mtu(struct net_device *netdev, int new_mtu)
{
- if (netif_running(netdev))
- return -EBUSY;
+ struct macb *bp = netdev_priv(netdev);
+ bool running = netif_running(netdev);
+ struct macb_context *new_ctx;
+
+ if (running) {
+ new_ctx = macb_context_alloc(bp, new_mtu,
+ bp->configured_rx_ring_size,
+ bp->configured_tx_ring_size);
+ if (IS_ERR(new_ctx))
+ return PTR_ERR(new_ctx);
+
+ macb_context_swap_start(bp);
+ }
WRITE_ONCE(netdev->mtu, new_mtu);
+ if (running)
+ macb_context_swap_end(bp, new_ctx);
+
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-01 16:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 16:39 [PATCH net-next 00/11] net: macb: implement context swapping Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 01/11] net: macb: unify device pointer naming convention Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 02/11] net: macb: unify `struct macb *` " Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 03/11] net: macb: unify queue index variable naming convention and types Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 04/11] net: macb: enforce reverse christmas tree (RCT) convention Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 05/11] net: macb: allocate tieoff descriptor once across device lifetime Théo Lebrun
2026-04-02 11:14 ` Nicolai Buchwitz
2026-04-02 13:57 ` Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 06/11] net: macb: introduce macb_context struct for buffer management Théo Lebrun
2026-04-02 11:22 ` Nicolai Buchwitz
2026-04-02 14:11 ` Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 07/11] net: macb: avoid macb_init_rx_buffer_size() modifying state Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 08/11] net: macb: make `struct macb` subset reachable from macb_context struct Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 09/11] net: macb: introduce macb_context_alloc() helper Théo Lebrun
2026-04-01 16:39 ` [PATCH net-next 10/11] net: macb: use context swapping in .set_ringparam() Théo Lebrun
2026-04-01 20:17 ` Maxime Chevallier
2026-04-02 16:34 ` Théo Lebrun
2026-04-02 11:29 ` Nicolai Buchwitz
2026-04-02 16:31 ` Théo Lebrun
2026-04-03 9:03 ` Théo Lebrun
2026-04-01 16:39 ` Théo Lebrun [this message]
2026-04-02 11:30 ` [PATCH net-next 11/11] net: macb: use context swapping in .ndo_change_mtu() Nicolai Buchwitz
2026-04-02 11:35 ` [PATCH net-next 00/11] net: macb: implement context swapping Nicolai Buchwitz
2026-04-02 13:46 ` Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401-macb-context-v1-11-9590c5ab7272@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pvalerio@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox