Re: [PATCH v25 09/11] sfc: obtain decoder and region if committed by firmware

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on 64584273dfb8a1e5fc7d78094ba22a93c204b44e]

url:    https://github.com/intel-lab-lkp/linux/commits/alejandro-lucero-palau-amd-com/sfc-add-cxl-support/20260331-055820
base:   64584273dfb8a1e5fc7d78094ba22a93c204b44e
patch link:    https://lore.kernel.org/r/20260330143827.1278677-10-alejandro.lucero-palau%40amd.com
patch subject: [PATCH v25 09/11] sfc: obtain decoder and region if committed by firmware
config: sparc-randconfig-002-20260331 (https://download.01.org/0day-ci/archive/20260401/202604010036.h2OVjfQU-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260401/202604010036.h2OVjfQU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604010036.h2OVjfQU-lkp@intel.com/

All errors (new ones prefixed by >>):

   sparc-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_init':
>> drivers/net/ethernet/sfc/efx_cxl.c:89:(.text+0x198): undefined reference to `cxl_get_region_range'
   sparc-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_exit':
>> drivers/net/ethernet/sfc/efx_cxl.c:120:(.text+0x234): undefined reference to `cxl_unregister_region'


vim +89 drivers/net/ethernet/sfc/efx_cxl.c

    16	
    17	int efx_cxl_init(struct efx_probe_data *probe_data)
    18	{
    19		struct efx_nic *efx = &probe_data->efx;
    20		struct pci_dev *pci_dev = efx->pci_dev;
    21		struct efx_cxl *cxl;
    22		struct range range;
    23		u16 dvsec;
    24		int rc;
    25	
    26		probe_data->cxl_pio_initialised = false;
    27	
    28		/* Is the device configured with and using CXL? */
    29		if (!pcie_is_cxl(pci_dev))
    30			return 0;
    31	
    32		dvsec = pci_find_dvsec_capability(pci_dev, PCI_VENDOR_ID_CXL,
    33						  PCI_DVSEC_CXL_DEVICE);
    34		if (!dvsec) {
    35			pci_info(pci_dev, "CXL_DVSEC_PCIE_DEVICE capability not found\n");
    36			return 0;
    37		}
    38	
    39		pci_dbg(pci_dev, "CXL_DVSEC_PCIE_DEVICE capability found\n");
    40	
    41		/* Create a cxl_dev_state embedded in the cxl struct using cxl core api
    42		 * specifying no mbox available.
    43		 */
    44		cxl = devm_cxl_dev_state_create(&pci_dev->dev, CXL_DEVTYPE_DEVMEM,
    45						pci_dev->dev.id, dvsec, struct efx_cxl,
    46						cxlds, false);
    47	
    48		if (!cxl)
    49			return -ENOMEM;
    50	
    51		rc = cxl_pci_setup_regs(pci_dev, CXL_REGLOC_RBI_COMPONENT,
    52					&cxl->cxlds.reg_map);
    53		if (rc) {
    54			pci_err(pci_dev, "No component registers\n");
    55			return rc;
    56		}
    57	
    58		if (!cxl->cxlds.reg_map.component_map.hdm_decoder.valid) {
    59			pci_err(pci_dev, "Expected HDM component register not found\n");
    60			return -ENODEV;
    61		}
    62	
    63		if (!cxl->cxlds.reg_map.component_map.ras.valid) {
    64			pci_err(pci_dev, "Expected RAS component register not found\n");
    65			return -ENODEV;
    66		}
    67	
    68		/* Set media ready explicitly as there are neither mailbox for checking
    69		 * this state nor the CXL register involved, both not mandatory for
    70		 * type2.
    71		 */
    72		cxl->cxlds.media_ready = true;
    73	
    74		if (cxl_set_capacity(&cxl->cxlds, EFX_CTPIO_BUFFER_SIZE)) {
    75			pci_err(pci_dev, "dpa capacity setup failed\n");
    76			return -ENODEV;
    77		}
    78	
    79		cxl->cxlmd = devm_cxl_add_memdev(&cxl->cxlds, NULL);
    80		if (IS_ERR(cxl->cxlmd)) {
    81			pci_err(pci_dev, "CXL accel memdev creation failed");
    82			return PTR_ERR(cxl->cxlmd);
    83		}
    84	
    85		cxl->efx_region = cxl_get_region_from_committed_decoder(cxl->cxlmd);
    86		if (!cxl->efx_region)
    87			return -ENODEV;
    88	
  > 89		rc = cxl_get_region_range(cxl->efx_region, &range);
    90		if (rc) {
    91			pci_err(pci_dev,
    92				"CXL getting regions params from a committed decoder failed");
    93			return rc;
    94		}
    95	
    96		cxl->ctpio_cxl = ioremap(range.start, range_len(&range));
    97		if (!cxl->ctpio_cxl) {
    98			pci_err(pci_dev, "CXL ioremap region (%pra) failed", &range);
    99			return -ENOMEM;
   100		}
   101	
   102	
   103		probe_data->cxl = cxl;
   104	
   105		return 0;
   106	}
   107	
   108	void efx_cxl_exit(struct efx_probe_data *probe_data)
   109	{
   110		if (!probe_data->cxl)
   111			return;
   112	
   113		iounmap(probe_data->cxl->ctpio_cxl);
   114	
   115		/* If the sfc cxl initialization was successful, it implies the
   116		 * endpoint decoder had an auto discover region which is the one
   117		 * we used and we need to remove now. Otherwise the region will
   118		 * be around until the root port is removed.
   119		 */
 > 120		cxl_unregister_region(probe_data->cxl->efx_region);
   121	}
   122	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki