Re: [PATCH v25 05/11] sfc: create type2 cxl memdev

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on 64584273dfb8a1e5fc7d78094ba22a93c204b44e]

url:    https://github.com/intel-lab-lkp/linux/commits/alejandro-lucero-palau-amd-com/sfc-add-cxl-support/20260331-055820
base:   64584273dfb8a1e5fc7d78094ba22a93c204b44e
patch link:    https://lore.kernel.org/r/20260330143827.1278677-6-alejandro.lucero-palau%40amd.com
patch subject: [PATCH v25 05/11] sfc: create type2 cxl memdev
config: x86_64-randconfig-003-20260331 (https://download.01.org/0day-ci/archive/20260401/202604010047.zovyb3Z0-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260401/202604010047.zovyb3Z0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604010047.zovyb3Z0-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `efx_cxl_init':
>> drivers/net/ethernet/sfc/efx_cxl.c:78:(.text+0xd33fcd): undefined reference to `devm_cxl_add_memdev'


vim +78 drivers/net/ethernet/sfc/efx_cxl.c

    16	
    17	int efx_cxl_init(struct efx_probe_data *probe_data)
    18	{
    19		struct efx_nic *efx = &probe_data->efx;
    20		struct pci_dev *pci_dev = efx->pci_dev;
    21		struct efx_cxl *cxl;
    22		u16 dvsec;
    23		int rc;
    24	
    25		probe_data->cxl_pio_initialised = false;
    26	
    27		/* Is the device configured with and using CXL? */
    28		if (!pcie_is_cxl(pci_dev))
    29			return 0;
    30	
    31		dvsec = pci_find_dvsec_capability(pci_dev, PCI_VENDOR_ID_CXL,
    32						  PCI_DVSEC_CXL_DEVICE);
    33		if (!dvsec) {
    34			pci_info(pci_dev, "CXL_DVSEC_PCIE_DEVICE capability not found\n");
    35			return 0;
    36		}
    37	
    38		pci_dbg(pci_dev, "CXL_DVSEC_PCIE_DEVICE capability found\n");
    39	
    40		/* Create a cxl_dev_state embedded in the cxl struct using cxl core api
    41		 * specifying no mbox available.
    42		 */
    43		cxl = devm_cxl_dev_state_create(&pci_dev->dev, CXL_DEVTYPE_DEVMEM,
    44						pci_dev->dev.id, dvsec, struct efx_cxl,
    45						cxlds, false);
    46	
    47		if (!cxl)
    48			return -ENOMEM;
    49	
    50		rc = cxl_pci_setup_regs(pci_dev, CXL_REGLOC_RBI_COMPONENT,
    51					&cxl->cxlds.reg_map);
    52		if (rc) {
    53			pci_err(pci_dev, "No component registers\n");
    54			return rc;
    55		}
    56	
    57		if (!cxl->cxlds.reg_map.component_map.hdm_decoder.valid) {
    58			pci_err(pci_dev, "Expected HDM component register not found\n");
    59			return -ENODEV;
    60		}
    61	
    62		if (!cxl->cxlds.reg_map.component_map.ras.valid) {
    63			pci_err(pci_dev, "Expected RAS component register not found\n");
    64			return -ENODEV;
    65		}
    66	
    67		/* Set media ready explicitly as there are neither mailbox for checking
    68		 * this state nor the CXL register involved, both not mandatory for
    69		 * type2.
    70		 */
    71		cxl->cxlds.media_ready = true;
    72	
    73		if (cxl_set_capacity(&cxl->cxlds, EFX_CTPIO_BUFFER_SIZE)) {
    74			pci_err(pci_dev, "dpa capacity setup failed\n");
    75			return -ENODEV;
    76		}
    77	
  > 78		cxl->cxlmd = devm_cxl_add_memdev(&cxl->cxlds, NULL);
    79		if (IS_ERR(cxl->cxlmd)) {
    80			pci_err(pci_dev, "CXL accel memdev creation failed");
    81			return PTR_ERR(cxl->cxlmd);
    82		}
    83	
    84		probe_data->cxl = cxl;
    85	
    86		return 0;
    87	}
    88	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki