From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A3D33A4F34 for ; Wed, 1 Apr 2026 08:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775031471; cv=none; b=GNqsgptd+TsVmrxJYwOkxN1yKvTSeG7Sjj7PPp+QMzcKXQDUImWxZTBKzZ+cO8kXkyhRlMeLEItV0ZEiRv4e8onEujrQTZQkN91icJpLhlmU60aBP9HQhIwtSH5LOpe4FdcEyuESoO9b5G4iDOXtYxnrjYOmbod2KhX4d/BdPXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775031471; c=relaxed/simple; bh=UIEa237z5KoVASskoiZkfFzSee0Icc3k/1v9+CFrHlA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=C6URYadZfF7K2H7tD5jkTYHTmocM8cZPgepbq/qR2exkSGZeD8zi8lkOaEdslxrqMdFcclsRwNdbAwToMLvmCnBAEOouvHeoyDLdYd9ltPGEEqD3M+N4qsgf8vMA28DoA21G9Kg8V2SplafLS1Z7npIMq/1h8yMO4wImdpVG/Cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OaBm4nOV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Jz+sW3aT; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OaBm4nOV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Jz+sW3aT; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OaBm4nOV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Jz+sW3aT"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OaBm4nOV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Jz+sW3aT" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 845E05BCDD; Wed, 1 Apr 2026 08:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775031468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NP0egGP4n7z1T94grPTVDKDrodrCqJJR2SBJLmpNaRY=; b=OaBm4nOV31zBZh4+baTWg00oceJfaWqntA4vycx6VTggcHCkGFQxQ4BFRFlhyX6Rh+BfDG h1Uo9Gq66fHBueDPem9Bx00fW2jX/46zKaCqpgTMPRx/Pnlq+iUKzF58yJc1PDHb+gjULD eXlEps31sKxYnHHlwuAY71S2evLoa10= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775031468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NP0egGP4n7z1T94grPTVDKDrodrCqJJR2SBJLmpNaRY=; b=Jz+sW3aToyJ+86KCxpl6gYirGIpYL9Syx3EtkDZRBsiKloVGJ0oOjcTlMMy4DMn3PO6HFX uU+cYddK9v31ZOAw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775031468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NP0egGP4n7z1T94grPTVDKDrodrCqJJR2SBJLmpNaRY=; b=OaBm4nOV31zBZh4+baTWg00oceJfaWqntA4vycx6VTggcHCkGFQxQ4BFRFlhyX6Rh+BfDG h1Uo9Gq66fHBueDPem9Bx00fW2jX/46zKaCqpgTMPRx/Pnlq+iUKzF58yJc1PDHb+gjULD eXlEps31sKxYnHHlwuAY71S2evLoa10= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775031468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NP0egGP4n7z1T94grPTVDKDrodrCqJJR2SBJLmpNaRY=; b=Jz+sW3aToyJ+86KCxpl6gYirGIpYL9Syx3EtkDZRBsiKloVGJ0oOjcTlMMy4DMn3PO6HFX uU+cYddK9v31ZOAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CF8B54A0B0; Wed, 1 Apr 2026 08:17:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uTSkL6vUzGlmegAAD6G6ig (envelope-from ); Wed, 01 Apr 2026 08:17:47 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: idosch@nvidia.com, petrm@nvidia.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, dsahern@kernel.org, kees@kernel.org, Fernando Fernandez Mancera Subject: [PATCH 1/2 net v2] ipv4: nexthop: avoid duplicate NHA_HW_STATS_ENABLE on nexthop group dump Date: Wed, 1 Apr 2026 10:17:40 +0200 Message-ID: <20260401081741.4273-1-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: Currently NHA_HW_STATS_ENABLE is included twice everytime a dump of nexthop group is performed with NHA_OP_FLAG_DUMP_STATS. As all the stats querying were moved to nla_put_nh_group_stats(), leave only that instance of the attribute querying. Fixes: 5072ae00aea4 ("net: nexthop: Expose nexthop group HW stats to user space") Signed-off-by: Fernando Fernandez Mancera --- v2: patch added on this revision --- net/ipv4/nexthop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c index c942f1282236..a0c694583299 100644 --- a/net/ipv4/nexthop.c +++ b/net/ipv4/nexthop.c @@ -902,8 +902,7 @@ static int nla_put_nh_group(struct sk_buff *skb, struct nexthop *nh, goto nla_put_failure; if (op_flags & NHA_OP_FLAG_DUMP_STATS && - (nla_put_u32(skb, NHA_HW_STATS_ENABLE, nhg->hw_stats) || - nla_put_nh_group_stats(skb, nh, op_flags))) + nla_put_nh_group_stats(skb, nh, op_flags)) goto nla_put_failure; return 0; -- 2.53.0