From: Nicolai Buchwitz <nb@tipi-net.de>
To: netdev@vger.kernel.org
Cc: Phil Elwell <phil@raspberrypi.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Nicolai Buchwitz <nb@tipi-net.de>
Subject: [PATCH net-next v3 0/2] net: phy: microchip: add downshift support for LAN88xx
Date: Wed, 1 Apr 2026 14:38:43 +0200 [thread overview]
Message-ID: <20260401123848.696766-1-nb@tipi-net.de> (raw)
In-Reply-To: <20260329224202.500229-1-nb@tipi-net.de>
Add standard ETHTOOL_PHY_DOWNSHIFT tunable support for the Microchip
LAN88xx PHY, following the same pattern used by Marvell and other PHY
drivers.
Ethernet cables with faulty or missing pairs (specifically C and D)
can successfully auto-negotiate 1000BASE-T but fail to establish a
stable link. The LAN88xx PHY supports automatic downshift to
100BASE-TX after a configurable number of failed attempts (2-5).
Patch 1 adds the get/set tunable implementation.
Patch 2 enables downshift by default with a count of 2. The setting is
stored in the driver's private data so that user changes via ethtool are
preserved across suspend/resume cycles.
Based on an earlier downstream implementation by Phil Elwell.
Tested on Raspberry Pi 3B+ (LAN7515/LAN88xx).
Changes since v2:
- Store downshift count in priv struct and restore in config_init to
preserve user settings across suspend/resume (Russell King)
Changes since v1:
- Replace switch statements with FIELD_GET()/FIELD_PREP() (Andrew Lunn)
- Drop unused per-count register defines from microchipphy.h
Nicolai Buchwitz (2):
net: phy: microchip: add downshift tunable support for LAN88xx
net: phy: microchip: enable downshift by default on LAN88xx
drivers/net/phy/microchip.c | 79 +++++++++++++++++++++++++++++++++++-
include/linux/microchipphy.h | 5 +++
2 files changed, 83 insertions(+), 1 deletion(-)
--
2.51.0
next prev parent reply other threads:[~2026-04-01 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 22:41 [PATCH net-next 0/2] net: phy: microchip: add downshift support for LAN88xx Nicolai Buchwitz
2026-03-29 22:41 ` [PATCH 1/2] net: phy: microchip: add downshift tunable " Nicolai Buchwitz
2026-03-30 13:01 ` Andrew Lunn
2026-03-30 14:57 ` Nicolai Buchwitz
2026-03-30 13:02 ` Andrew Lunn
2026-03-29 22:42 ` [PATCH 2/2] net: phy: microchip: enable downshift by default on LAN88xx Nicolai Buchwitz
2026-03-30 13:03 ` Andrew Lunn
2026-04-01 12:38 ` Nicolai Buchwitz [this message]
2026-04-01 12:38 ` [PATCH net-next v3 1/2] net: phy: microchip: add downshift tunable support for LAN88xx Nicolai Buchwitz
2026-04-01 12:38 ` [PATCH net-next v3 2/2] net: phy: microchip: enable downshift by default on LAN88xx Nicolai Buchwitz
2026-04-02 1:48 ` [PATCH net-next v3 0/2] net: phy: microchip: add downshift support for LAN88xx Jakub Kicinski
2026-04-02 7:11 ` Nicolai Buchwitz
2026-04-03 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401123848.696766-1-nb@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew@lunn.ch \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=phil@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox