* [PATCH net] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE
@ 2026-04-01 13:53 Eric Dumazet
2026-04-02 1:11 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2026-04-01 13:53 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, Andrew Lunn, netdev, eric.dumazet, Eric Dumazet,
syzbot+d8c285748fa7292580a9
lapbeth_data_transmit() expects the underlying device type
to be ARPHRD_ETHER.
Returning NOTIFY_BAD from lapbeth_device_event() makes sure
bonding driver can not break this expectation.
Fixes: 872254dd6b1f ("net/bonding: Enable bonding to enslave non ARPHRD_ETHER")
Reported-by: syzbot+d8c285748fa7292580a9@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/69cd22a1.050a0220.70c3a.0002.GAE@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
drivers/net/wan/lapbether.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index f357a7ac70ac4756967730fa61c07258b4b3ac00..5c91160dd68cc1dfa4308d38fb111032206fae75 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -473,6 +473,9 @@ static int lapbeth_device_event(struct notifier_block *this,
if (lapbeth)
lapbeth_free_device(lapbeth);
break;
+ case NETDEV_PRE_TYPE_CHANGE:
+ /* Our underlying device type must not change. */
+ return NOTIFY_BAD;
}
return NOTIFY_DONE;
--
2.53.0.1118.gaef5881109-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE
2026-04-01 13:53 [PATCH net] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE Eric Dumazet
@ 2026-04-02 1:11 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2026-04-02 1:11 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, Andrew Lunn, netdev, eric.dumazet,
syzbot+d8c285748fa7292580a9
On Wed, Apr 1, 2026 at 6:53 AM Eric Dumazet <edumazet@google.com> wrote:
>
> lapbeth_data_transmit() expects the underlying device type
> to be ARPHRD_ETHER.
>
> Returning NOTIFY_BAD from lapbeth_device_event() makes sure
> bonding driver can not break this expectation.
>
> Fixes: 872254dd6b1f ("net/bonding: Enable bonding to enslave non ARPHRD_ETHER")
> Reported-by: syzbot+d8c285748fa7292580a9@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/69cd22a1.050a0220.70c3a.0002.GAE@google.com/T/#u
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> drivers/net/wan/lapbether.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
> index f357a7ac70ac4756967730fa61c07258b4b3ac00..5c91160dd68cc1dfa4308d38fb111032206fae75 100644
> --- a/drivers/net/wan/lapbether.c
> +++ b/drivers/net/wan/lapbether.c
> @@ -473,6 +473,9 @@ static int lapbeth_device_event(struct notifier_block *this,
> if (lapbeth)
> lapbeth_free_device(lapbeth);
> break;
> + case NETDEV_PRE_TYPE_CHANGE:
> + /* Our underlying device type must not change. */
> + return NOTIFY_BAD;
I will send a v2, we need to guard this with lapbeth_get_x25_dev(dev)
pw-bot: changes-requested
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-02 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 13:53 [PATCH net] net: lapbether: handle NETDEV_PRE_TYPE_CHANGE Eric Dumazet
2026-04-02 1:11 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox