From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEE6430E84B; Thu, 2 Apr 2026 01:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775094237; cv=none; b=eRggZj938uT05QTwLvwwbyRqF0o5YzZzO2PDXABr9dCEVlXVljRxnVKJp2ud1ZkxvokxszLyfa1Gk6DpwhJZh2/1uf7HN3gUMXmUkwku/e9zKSm12fG0Uz/q7E1QOQ1Ra1FcHGJ00ywSMYiemT1KbdczVWF00xmswlsGUyd7hXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775094237; c=relaxed/simple; bh=4rhYRtEiCn0F4txmgoZwS63pOAIHvVvVsbvrbeFVWcU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JSTHUr8J10JnpgetIyuOyatYw87RUPurmiM/Mp03SRHAwpw2DxOo/EtC2UZ0EKd3LPjGfKSSOBBWxH4iP0CfVqaI0JoO25khvKH3sya4bmcLZpHhbmci1GnVitOlkwyRkb2/8EmVCn7ltWThrsAMs6rNSraUZ/kW920c1munjQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EVG7lgek; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EVG7lgek" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07CBAC4CEF7; Thu, 2 Apr 2026 01:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775094236; bh=4rhYRtEiCn0F4txmgoZwS63pOAIHvVvVsbvrbeFVWcU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EVG7lgeklIR2lk2B6psf2XuNf9uNZbvV9i4pIJd+9eHF1fyyk2I1ncDD55+Ij4EXx y8AHWSCEqSk5855V/Wq3pUlcSqax44Et5rvangQ493jfeBijNwE5Prl2HSdmU5ikAP YHEgMP68LdWmGYuXFxoK5seEnv092J4EzSbzF3LoyDwc4EI5cU697teafxZmNye69M L62ORXVzqF2tFPG3RSkVPNECJZM78SYLmFV4qHgo6EkP75HFxH4uiwZzoVHBOUFxiv X0xSkQ1gY2W8eGqtjTP/jW4fUa+DqvLAWltuiFkGPl19j8D7FWs64VNWKDtB3TrIRX M9xihwrUr0+bQ== Date: Wed, 1 Apr 2026 18:43:55 -0700 From: Jakub Kicinski To: Tyllis Xu Cc: haren@linux.ibm.com, ricklind@linux.ibm.com, nnac123@linux.ibm.com, sukadev@linux.ibm.com, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, ychen@northwestern.edu, Yuhao Jiang Subject: Re: [PATCH v2] ibmvnic: fix OOB array access in ibmvnic_xmit on queue count reduction Message-ID: <20260401184355.2a063cb4@kernel.org> In-Reply-To: <20260401050845.1388145-1-LivelyCarpet87@gmail.com> References: <20260401050845.1388145-1-LivelyCarpet87@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 1 Apr 2026 00:08:45 -0500 Tyllis Xu wrote: > When the number of TX queues is reduced (e.g., via ethtool -L), the > Qdisc layer retains previously enqueued skbs with queue mappings from > before the reduction. After the reset completes and tx_queues_active is > set to true, netif_tx_start_all_queues() drains these stale skbs through > ibmvnic_xmit(). The queue index from skb_get_queue_mapping() may exceed > the newly allocated array bounds, causing out-of-bounds reads on > tx_scrq[] and tx_pool[]/tso_pool[]. This should not happen if the interface configures itself correctly, see https://lore.kernel.org/all/20260106182244.7188a8f6@kernel.org/ Please share are a repro if you have one.