From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281F432ED24 for ; Thu, 2 Apr 2026 08:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117889; cv=none; b=L4lVLI0LrH6GINl+BZnoeG1i3DdacFZ69laViXSWGLxUkNPy+h4VkGq+mPZvgl18bGDJbSAV3VD7gYCFT1olWTQ8vq1D4FcmcgEFtwY8svmUN57UnhcNKwCEns9NYiOKtJ5ksoBdJISUOblkb6tES+yCsaQkv/6GCUTCiZTvRDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117889; c=relaxed/simple; bh=Gv4j5F5kmYPN2toSNOT0NUM+Ds/EorTosVmZDSuDh0M=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=AERaxQEeAXaPxOuBjt6Stj4F9DhYnaCjDyHbyjKyut1/WdM3MXNv1p/fRX7mqc8UQUzayIXnMJ36JBqannt2rrtUuZqm2xXTBVMv9iEGrqSSzvHZinsU4ixNq0+CtsUeRWeJUwO4L9GUaZOuKKMgb0zN7ScuBX4VlAJ/IyLNdoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dm7t+OgM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W6UBu7Yo; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dm7t+OgM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W6UBu7Yo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775117887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=Dm7t+OgMdQ4Wfg5ug4cdghgZ8DGPzHtltpKN0EhpcO12jf4pb4/nO08+P/4a3aIPDGsb9a 4pmkz2vTE1Qj4DO/AsorIs+sNbE0YFGts/duPvfbBUeMkF9stlRi0qPwzAJcVODw6CNW4n AZ27i2tw+aKj1E43UR4rX2/wWn4hY74= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-XBlXxOXtPPWGIsQOrshcuA-1; Thu, 02 Apr 2026 04:18:05 -0400 X-MC-Unique: XBlXxOXtPPWGIsQOrshcuA-1 X-Mimecast-MFC-AGG-ID: XBlXxOXtPPWGIsQOrshcuA_1775117884 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4836abfc742so7098635e9.0 for ; Thu, 02 Apr 2026 01:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775117884; x=1775722684; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=W6UBu7YoWWWnVoXkcpjZxrWDhOCU111Vcd1eLd+fAvnPiSoIUADdCdTneNlQsZ99bv CSA3FrdSG6GTVNk1pRNNp4lgpvP9f+sBl9leKwW9EkVCflqFkto2xPPDe+g7rN3l/Aug evn7y+tG6QN6bedZsCJ2r7znGrwR345Ci1UvxFnqFIRrDr1ycgY7EFTK1OhScKCAoz98 eRPjCHgrMp6q9z+CzBwNy082JHjxLeFQbkw25RZ3d9B1fLV3s9o9Z7FV6dfd1HpsLY0g +OZuI72Tqy1PVoRPGYQ6Xny1YCtIGJV78FsnZlL1MvK+xnSKhovAdli3n5W96Bt+Gm25 BcEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775117884; x=1775722684; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=sgI27wYefTm7jZqutPGxaC2PCVek8DuDlpL9RQt4TAblzYagAeBdf7oghUdGJtX5ql HIEpbTQESBFX6ggf9/xyo28Z3S8NI3t3z1JyM+FiSCjW1NgvcHlYo+xFxMVS1yrW1boW JNZ0XEXcytHZ0Qt0PWyy1qoFMCaXcRf1JVVAaNluO/pAtBoUbUatFbktyj/epCm8uP0Z Ib8ZKJWwl/rHReo/hPg9BUUj6dW0tyU7KJNND43koyP3o3eMD1MR8KfXpXGS24MueYtQ drvl6tWiDsYX39cqfeXeXsJRCDcpx+ViiymUrVryNieQGuDLpQDkEhXxTo60vybFWOTv +d3g== X-Forwarded-Encrypted: i=1; AJvYcCWvr7y15XwLN5vNALCC19s6OmaQKZxqETqcJEY0IpForzdy8ixWv3e0MAHmPlr9k87l1XDGPDc=@vger.kernel.org X-Gm-Message-State: AOJu0YwlabQdiRe1Rv/RK2InUZlJgW0VN5CC3xDxErip2bcq9be7FTHw YIONFttPqNaBIJjU3c1fXVCpMhRS4okjd88zqi1v41Z4nnbyFw3HoZkJHAEYdjpunNUj8wP+QWs 4vgk16esV+W2TuKD92xL09DoWylgJ22rvyW843yVgZrTMKp0ro5SmO94SYQ== X-Gm-Gg: ATEYQzwhRxRMA3rt8IgtxZ3Iefc2JkFojUkru3Z2RH1iruZeWG+gLFyhH2fsVSPcQ3Z ILz2LZ9cgtqT/534uqroNUgWcextGmarChzTdSG4OqSWo7qgVumnxg2I0qsX9bjg5FPNGICg+HO NcJZbi93MPVIkGwGbsFy8G43doqsJDi5M3x9FDq0L+LClHpWBF10Q+XvNWFdMvQfppGPAFVJH1U nVGUxyE/thhQLt2nyXNgDG41wrRhs6yprvFK2+5ZEpEiiTlPRX8TwPdfPi5G8AceY0MDyn5HhRd uHqzDcGsEeELPu9mmUYFbGGMh88t8Nr8q7ntV2cnHvA6ALUh0XunjPD0DVnHSjMSlJnfRnoglo1 wOUeM3G89v3Rc1CX/92Y5tcA5R37FPAl8dvPpUlcpwYKdyXuT9o9+C6LjpzHa X-Received: by 2002:a05:600c:45c5:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-4888356a036mr110318905e9.3.1775117884403; Thu, 02 Apr 2026 01:18:04 -0700 (PDT) X-Received: by 2002:a05:600c:45c5:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-4888356a036mr110318555e9.3.1775117883944; Thu, 02 Apr 2026 01:18:03 -0700 (PDT) Received: from lleonard-thinkpadx1carbongen13.rmtit.csb ([176.206.19.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e735532sm214476005e9.0.2026.04.02.01.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:18:03 -0700 (PDT) From: Luigi Leonardi Subject: [PATCH net 0/2] vsock/virtio: fix MSG_PEEK calculation on bytes to copy Date: Thu, 02 Apr 2026 10:18:00 +0200 Message-Id: <20260402-fix_peek-v1-0-ad274fcef77b@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDEwND3bTMiviC1NRsXTMLY/MkC2MTM8tUYyWg8oKiVKAc2KhopbzUEqX Y2loAioNizF8AAAA= X-Change-ID: 20260401-fix_peek-6837b83469e3 To: Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arseniy Krasnov Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luigi Leonardi X-Mailer: b4 0.14.2 `virtio_transport_stream_do_peek`, when calculating the number of bytes to copy, didn't consider the `offset`, caused by partial reads that happend before. This might cause out-of-bounds read that lead to an EFAULT. More details in the commit. Commit 1 introduces the fix Commit 2 introduces a test that checks for this bug to avoid future regressions. Signed-off-by: Luigi Leonardi --- Luigi Leonardi (2): vsock/virtio: fix MSG_PEEK ignoring skb offset when calculating bytes to copy vsock/test: add MSG_PEEK after partial recv test net/vmw_vsock/virtio_transport_common.c | 5 ++- tools/testing/vsock/vsock_test.c | 64 +++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 3 deletions(-) --- base-commit: 9147566d801602c9e7fc7f85e989735735bf38ba change-id: 20260401-fix_peek-6837b83469e3 Best regards, -- Luigi Leonardi