From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA9C37FF7A for ; Thu, 2 Apr 2026 06:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775111081; cv=none; b=VZ5WcjdbrPtEmfhlQVMmWafyvXUhpon+/NhOmT2r42NIfidzDzi/knSOPbuecnCnAiQfJYxst/qWSmU8neEH9g9VHBxCpjOQe8/CMrbFdvfOIOhfHtjkbVaRP9pWdAj2av2DjmfcpzrIGqseG7Kl4EmvgC2o3+H/oCbjo9IvOAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775111081; c=relaxed/simple; bh=ssH/9/hjYB+fBqiWIN6t+y1AHb7DVBmvSY7H4JUUf5c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ITJIDjpvTRnnCZscWpFQXxApoA4YvHs+ASmDoYbSRMAtqNwtVV6UxgFmvVcYe1PpySSrmebJu+HuadLOojJ90Dnm6bKtkzP+u8m+i10zJTO5ze7Q03FYvHQ8XeTpUm6/OfSMUKuhIJOPOYCYTlp8ilXZitPIyinIobpsdO4VSCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--marcharvey.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XRYvNIFq; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--marcharvey.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XRYvNIFq" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-128edc72e5bso4616647c88.1 for ; Wed, 01 Apr 2026 23:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775111079; x=1775715879; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=v9oFgXGgQZPRqw6RYXyTCh6MIwqTVydlJPeU6ec/jKU=; b=XRYvNIFqwEtXzx39W7H65Jy55M3Y0qycnzWkMg5YukW/H7Qus6AyruRoivy4h79N06 YJafiTaWFeUnLJUuDRsZJZlk9RKfFjyGDD55BAjpjeYevlmrUpEj/P+f805F5yJbHDvo e/bGu+1CBuYv7cz9cuhUu4DBQ8bUGQ7nTfwLVtOUvUykFVXq4UaW6+Dk0A41feuWVN2c Mgqtpc0Qtwg5Gp/3cADKp5/uqdXJ/X5ByEf/wSEHetms+5RiVkQAnYGHUmLVQfDR0/Ny lV55xPkPAwOsscb4I6Q27g5uZlRphlsKIs4reSNZQ5F1c420BqL9rLdKwDH62+lNzuC/ c6Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775111079; x=1775715879; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v9oFgXGgQZPRqw6RYXyTCh6MIwqTVydlJPeU6ec/jKU=; b=ZyAPSn89yOxQKrfyOrgubWsXpMc/Qx/RK5EZHugV5Xp3wKB7k43kAWRRo3ux5YmwcR tZkz03OnQnsW1Tk1rPTOqHXWD4Xgy+YJqT7vUlWKXRmfpANoD6vXvKcBRrc7JjDnKwBa GHgbqx5f8VTB/+Ikinys6Escy10UcE4sEEuxIXPiMift/GXpnvOMi0jaZsvX9xfQ1epx S/+gABAoZqgyQ+WQbheI3qlrz/jnzYohR8kvtjXD33gqXsXZW7TO1FZp9I7eKVaJcD4Q SsAkwBvQZTGuut19B1J8Xa54wZFeMqGmbnahajkYbe+VI30MVDZFoYqhxXjOQkaa6uUU RVuQ== X-Gm-Message-State: AOJu0YwwqHkW2dAih0PHFTkvpsJJOjcAMDh6iCabQTpympMcbq0P3RRF JnXl0izariAd6udbaek3QdlA+Gv31S2JnELzUxmp/iuEYYt4w8JA3Az1M4c48HkaPtSrA06QMpE FA85mP3qeycKZ6gJdz61oBA== X-Received: from dled9-n2.prod.google.com ([2002:a05:701b:42c9:20b0:12a:c265:1a7c]) (user=marcharvey job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:e1c:b0:123:2c98:f6af with SMTP id a92af1059eb24-12be644a2bemr3876893c88.14.1775111079188; Wed, 01 Apr 2026 23:24:39 -0700 (PDT) Date: Thu, 02 Apr 2026 06:24:18 +0000 In-Reply-To: <20260402-teaming-driver-internal-v3-0-e8cfdec3b5c2@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260402-teaming-driver-internal-v3-0-e8cfdec3b5c2@google.com> X-Developer-Key: i=marcharvey@google.com; a=ed25519; pk=OzOeciadbfF5Bug/4/hyEAwfrruSY4tn0Q0LocyYUL0= X-Developer-Signature: v=1; a=ed25519-sha256; t=1775111069; l=8354; i=marcharvey@google.com; s=20260401; h=from:subject:message-id; bh=ssH/9/hjYB+fBqiWIN6t+y1AHb7DVBmvSY7H4JUUf5c=; b=J5ri/HEBXKzoQqu3xsVVVdBzpo+VHRSCCxE7WezYbk0rpAikZC4AG7yY62JwTeuhLAD+X4cDx sL3YUKTN0w4CXgbQnho5NJMETO0575L5OadaOwubctGrJggJFe8YDY7 X-Mailer: b4 0.14.3 Message-ID: <20260402-teaming-driver-internal-v3-5-e8cfdec3b5c2@google.com> Subject: [PATCH net-next v3 5/7] selftests: net: Add test for enablement of ports with teamd From: Marc Harvey To: Jiri Pirko , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Marc Harvey Content-Type: text/plain; charset="utf-8" There are no tests that verify enablement and disablement of team driver ports with teamd. This should work even with changes to the enablement option, so it is important to test. This test sets up an active-backup network configuration across two network namespaces, and tries to send traffic while changing which link is the active one. Signed-off-by: Marc Harvey --- Changed in v3: - Make test cleanup kill teamd instead of terminate. - Link to v2: https://lore.kernel.org/netdev/20260401-teaming-driver-internal-v2-5-f80c1291727b@google.com/ Changes in v2: - Fix shellcheck failures. - Remove dependency on net forwarding lib and pipe viewer tools. - Use iperf3 for tcp instead of netcat. - Link to v1: https://lore.kernel.org/all/20260331053353.2504254-6-marcharvey@google.com/ --- tools/testing/selftests/drivers/net/team/Makefile | 1 + .../drivers/net/team/teamd_activebackup.sh | 217 +++++++++++++++++++++ tools/testing/selftests/net/lib.sh | 13 ++ 3 files changed, 231 insertions(+) diff --git a/tools/testing/selftests/drivers/net/team/Makefile b/tools/testing/selftests/drivers/net/team/Makefile index 777da2e0429e..dab922d7f83d 100644 --- a/tools/testing/selftests/drivers/net/team/Makefile +++ b/tools/testing/selftests/drivers/net/team/Makefile @@ -7,6 +7,7 @@ TEST_PROGS := \ options.sh \ propagation.sh \ refleak.sh \ + teamd_activebackup.sh \ transmit_failover.sh \ # end of TEST_PROGS diff --git a/tools/testing/selftests/drivers/net/team/teamd_activebackup.sh b/tools/testing/selftests/drivers/net/team/teamd_activebackup.sh new file mode 100755 index 000000000000..aa882e1ee3d8 --- /dev/null +++ b/tools/testing/selftests/drivers/net/team/teamd_activebackup.sh @@ -0,0 +1,217 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +# These tests verify that teamd is able to enable and disable ports via the +# active backup runner. +# +# Topology: +# +# +-------------------------+ NS1 +# | test_team1 | +# | + | +# | eth0 | eth1 | +# | +---+---+ | +# | | | | +# +-------------------------+ +# | | +# +-------------------------+ NS2 +# | | | | +# | +-------+ | +# | eth0 | eth1 | +# | + | +# | test_team2 | +# +-------------------------+ + +export ALL_TESTS="teamd_test_active_backup" + +test_dir="$(dirname "$0")" +# shellcheck disable=SC1091 +source "${test_dir}/../../../net/lib.sh" +# shellcheck disable=SC1091 +source "${test_dir}/team_lib.sh" + +NS1="" +NS2="" +export NODAD="nodad" +PREFIX_LENGTH="64" +NS1_IP="fd00::1" +NS2_IP="fd00::2" +NS1_IP4="192.168.0.1" +NS2_IP4="192.168.0.2" +NS1_TEAMD_CONF="" +NS2_TEAMD_CONF="" +NS1_TEAMD_PID="" +NS2_TEAMD_PID="" + +while getopts "4" opt; do + case $opt in + 4) + echo "IPv4 mode selected." + export NODAD= + PREFIX_LENGTH="24" + NS1_IP="${NS1_IP4}" + NS2_IP="${NS2_IP4}" + ;; + \?) + echo "Invalid option: -${OPTARG}" >&2 + exit 1 + ;; + esac +done + +teamd_config_create() +{ + local runner=$1 + local dev=$2 + local conf + + conf=$(mktemp) + + cat > "${conf}" <<-EOF + { + "device": "${dev}", + "runner": {"name": "${runner}"}, + "ports": { + "eth0": {}, + "eth1": {} + } + } + EOF + echo "${conf}" +} + +# Create the network namespaces, veth pair, and team devices in the specified +# runner. +# Globals: +# RET - Used by test infra, set by `check_err` functions. +# Arguments: +# runner - The Teamd runner to use for the Team devices. +environment_create() +{ + local runner=$1 + + echo "Setting up two-link aggregation for runner ${runner}" + trap environment_destroy EXIT + + setup_ns ns1 ns2 + NS1="${NS_LIST[0]}" + NS2="${NS_LIST[1]}" + + for link in $(seq 0 1); do + ip -n "${NS1}" link add "eth${link}" type veth peer name \ + "eth${link}" netns "${NS2}" + check_err $? "Failed to create veth pair" + done + + NS1_TEAMD_CONF=$(teamd_config_create "${runner}" "test_team1") + NS2_TEAMD_CONF=$(teamd_config_create "${runner}" "test_team2") + echo "Conf files are ${NS1_TEAMD_CONF} and ${NS2_TEAMD_CONF}" + + ip netns exec "${NS1}" teamd -d -f "${NS1_TEAMD_CONF}" + check_err $? "Failed to create team device in ${NS1}" + NS1_TEAMD_PID=$(pgrep -f "teamd -d -f ${NS1_TEAMD_CONF}") + + ip netns exec "${NS2}" teamd -d -f "${NS2_TEAMD_CONF}" + check_err $? "Failed to create team device in ${NS2}" + NS2_TEAMD_PID=$(pgrep -f "teamd -d -f ${NS2_TEAMD_CONF}") + + echo "Created team devices" + + rm "${NS1_TEAMD_CONF}" + rm "${NS2_TEAMD_CONF}" + NS1_TEAMD_CONF="" + NS2_TEAMD_CONF="" + + for link in $(seq 0 1); do + in_all_ns "ip link set eth${link} up" + check_err $? "Failed to set eth${link} up" + done + + ip -n "${NS1}" link set test_team1 up + check_err $? "Failed to set test_team1 up in ${NS1}" + ip -n "${NS2}" link set test_team2 up + check_err $? "Failed to set test_team2 up in ${NS2}" + + ip -n "${NS1}" addr add "${NS1_IP}/${PREFIX_LENGTH}" "${NODAD}" dev \ + test_team1 + check_err $? "Failed to add address to team device in ${NS1}" + ip -n "${NS2}" addr add "${NS2_IP}/${PREFIX_LENGTH}" "${NODAD}" dev \ + test_team2 + check_err $? "Failed to add address to team device in ${NS2}" + + slowwait 2 timeout 0.5 ip netns exec "${NS1}" ping -W 1 -c 1 "${NS2_IP}" +} + +# Tear down the environment: kill teamd and delete network namespaces. +environment_destroy() +{ + echo "Tearing down two-link aggregation" + if [ -n "${NS1_TEAMD_PID}" ]; then + kill -9 "${NS1_TEAMD_PID}" 2>/dev/null + fi + if [ -n "${NS2_TEAMD_PID}" ]; then + kill -9 "${NS2_TEAMD_PID}" 2>/dev/null + fi + cleanup_all_ns +} + +# Change the active port for an active-backup mode team. +# Arguments: +# namespace - The network namespace that the team is in. +# team - The name of the team. +# active_port - The port to make active. +set_active_port() +{ + local namespace=$1 + local team=$2 + local active_port=$3 + + ip netns exec "${namespace}" teamdctl "${team}" state item set \ + runner.active_port "${active_port}" + slowwait 2 bash -c "ip netns exec ${namespace} teamdctl ${team} state \ + item get runner.active_port | grep -q ${active_port}" +} + +# Test that active backup runner can change active ports. +# Globals: +# RET - Used by test infra, set by `check_err` functions. +teamd_test_active_backup() +{ + export RET=0 + + start_listening_and_sending + + ### Scenario 1: Don't manually set active port, just make sure team + # works. + did_interface_receive test_team2 "${NS2}" + check_err $? "Traffic did not reach team interface in NS2." + + ### Scenario 2: Choose active port. + set_active_port "${NS1}" test_team1 eth1 + set_active_port "${NS2}" test_team2 eth1 + + did_interface_receive eth0 "${NS2}" + check_fail $? "eth0 IS transmitting when disabled" + did_interface_receive eth1 "${NS2}" + check_err $? "eth1 not transmitting when enabled" + + ### Scenario 3: Change active port. + set_active_port "${NS1}" test_team1 eth0 + set_active_port "${NS2}" test_team2 eth0 + + did_interface_receive eth0 "${NS2}" + check_err $? "eth0 not transmitting when enabled" + did_interface_receive eth1 "${NS2}" + check_fail $? "eth1 IS transmitting when disabled" + + log_test "teamd active backup runner test" + + stop_sending_and_listening +} + +require_command teamd +require_command teamdctl +require_command iperf3 +environment_create activebackup +tests_run +exit "${EXIT_STATUS}" diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh index b40694573f4c..992342b1dd7c 100644 --- a/tools/testing/selftests/net/lib.sh +++ b/tools/testing/selftests/net/lib.sh @@ -224,6 +224,19 @@ setup_ns() NS_LIST+=("${ns_list[@]}") } +in_all_ns() +{ + local ret=0 + local ns_list=("${NS_LIST[@]}") + + for ns in "${ns_list[@]}"; do + ip netns exec "${ns}" bash -c "$@" + (( ret = ret || $? )) + done + + return "${ret}" +} + # Create netdevsim with given id and net namespace. create_netdevsim() { local id="$1" -- 2.53.0.1185.g05d4b7b318-goog