From: Jakub Kicinski <kuba@kernel.org>
To: Marc Harvey <marcharvey@google.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver
Date: Thu, 2 Apr 2026 07:45:38 -0700 [thread overview]
Message-ID: <20260402074538.205e307c@kernel.org> (raw)
In-Reply-To: <20260402-teaming-driver-internal-v3-0-e8cfdec3b5c2@google.com>
On Thu, 02 Apr 2026 06:24:13 +0000 Marc Harvey wrote:
> Allow independent control over receive and transmit enablement states
> for aggregated ports in the team driver.
>
> The motivation is that IEE 802.3ad LACP "independent control" can't
> be implemented for the team driver currently. This was added to the
> bonding driver in commit 240fd405528b ("bonding: Add independent
> control state machine").
>
> This series also has a few patches that add tests to show that the old
> coupled enablement still works and that the new decoupled enablement
> works as intended (4, 5, and 7).
>
> There are three patches with small fixes as well, with the goal of
> making the final decouplement patch clearer (1, 2, and 3).
Sounds like Jiri asked for changes, when you respin could you run
shellcheck and clean up the warnings? We ignore SC2317 SC2329 FWIW
selftests confuse the checker.
next prev parent reply other threads:[~2026-04-02 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 6:24 [PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 1/7] net: team: Annotate reads and writes for mixed lock accessed values Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 2/7] net: team: Remove unused team_mode_op, port_enabled Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 3/7] net: team: Rename port_disabled team mode op to port_tx_disabled Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 4/7] selftests: net: Add tests for failover of team-aggregated ports Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 5/7] selftests: net: Add test for enablement of ports with teamd Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 6/7] net: team: Decouple rx and tx enablement in the team driver Marc Harvey
2026-04-02 12:54 ` Jiri Pirko
2026-04-02 21:16 ` Marc Harvey
2026-04-02 6:24 ` [PATCH net-next v3 7/7] selftests: net: Add tests for team driver decoupled tx and rx control Marc Harvey
2026-04-02 14:45 ` Jakub Kicinski [this message]
2026-04-03 3:41 ` [PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver Marc Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402074538.205e307c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcharvey@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox