From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net v3 0/7] net/sched: Fix packet loops in mirred and netem
Date: Thu, 2 Apr 2026 13:16:18 -0700 [thread overview]
Message-ID: <20260402131618.21624737@phoenix.local> (raw)
In-Reply-To: <20260326181701.308275-1-stephen@networkplumber.org>
On Thu, 26 Mar 2026 11:00:59 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> This a minor revision of Jamal's series that
> fixes packet loops caused by mirred ingress redirects
> and netem duplication in stacked qdisc trees.
>
> The core idea is a 2-bit per-skb tc_depth counter that travels with
> the packet. The existing per-CPU mirred nest tracking loses state
> when a packet is deferred through the backlog or moves between CPUs
> via XPS/RPS. A per-skb field covers both cases.
>
> Patch 1 adds the tc_depth field in a padding hole in sk_buff.
> Patches 2-3 revert the check_netem_in_tree() fix and its tests,
> which broke legitimate multi-netem configurations.
> Patch 4 uses tc_depth to stop netem duplicate recursion.
> Patch 5 uses tc_depth to catch mirred ingress redirect loops.
> Patches 6-7 add mirred and netem test cases.
>
> Thanks to Jamal and Victor for fixing this.
>
> There are additional netem bug fixes in the pipeline but those
> are held back until this series lands.
Why is this marked Changes Requested.
The only yellow in patchwork is AI review warning that the patch
didn't address my comments. Which is a clear case of AI confusion.
I updated comments and commit methods to my satisfaction.
Sorry if that didn't satisfy it.
next prev parent reply other threads:[~2026-04-02 20:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 18:00 [PATCH net v3 0/7] net/sched: Fix packet loops in mirred and netem Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 1/7] net: Introduce skb tc depth field to track packet loops Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 2/7] net/sched: Revert "net/sched: Restrict conditions for adding duplicating netems to qdisc tree" Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 3/7] Revert "selftests/tc-testing: Add tests for restrictions on netem duplication" Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 4/7] net/sched: fix packet loop on netem when duplicate is on Stephen Hemminger
2026-03-27 7:00 ` William Liu
2026-03-26 18:01 ` [PATCH v3 5/7] net/sched: Fix ethx:ingress -> ethy:egress -> ethx:ingress mirred loop Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 6/7] selftests/tc-testing: Add mirred test cases exercising loops Stephen Hemminger
2026-03-26 18:01 ` [PATCH v3 7/7] selftests/tc-testing: Add netem test case " Stephen Hemminger
2026-03-30 8:06 ` Paolo Abeni
2026-03-30 16:01 ` Jamal Hadi Salim
2026-04-02 20:16 ` Stephen Hemminger [this message]
2026-04-03 0:49 ` [PATCH net v3 0/7] net/sched: Fix packet loops in mirred and netem Jakub Kicinski
2026-04-03 19:03 ` Stephen Hemminger
2026-04-03 21:00 ` Jakub Kicinski
2026-04-03 22:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402131618.21624737@phoenix.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox