From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07EC63F54BE for ; Thu, 2 Apr 2026 16:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775147562; cv=none; b=uJSZ85s1EGnMlD7xfuZXDGTv+AvcwASB2XWm3LmVKEVg6PpUcbLX7RdGCAyaP3sIGOwpA8K6E/ASOAXAkPtRD96KCkGl9LL3uV1ogxUZfmB9Xod5VHvTT0BxTKF+968jGQyBALEQidiiQRTUMGEKWvDsqaEx9oNTjk3Q2Doa8ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775147562; c=relaxed/simple; bh=JR2o/Dc9KQQqFMs2hnW304fAynwgXnuFy/EOByn52Nw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TXnpKf72zDkvXtdTbPeEsT6txYtLUwCcpe0GUJUj3YeXo4oBPb9H/J5BnUZE5x60VJC8pQTO3Kv8lre7tO2xU+bQNx1JSWpO3zO9xdOFVvcHmPJwlBeoqhFLMrnb6kZfOMHHLcMCtOxLhWH+ZwdJPBWnVmp23qAyLdP26mRcC8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=eMOhEyPT; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=6AqVCuFc; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="eMOhEyPT"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="6AqVCuFc" Date: Thu, 2 Apr 2026 18:32:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1775147559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JR2o/Dc9KQQqFMs2hnW304fAynwgXnuFy/EOByn52Nw=; b=eMOhEyPTU45GkNf/h1IYQsQon69FNInXZ4/egJiqsaby0sSkT0r9cUIx8DmMVQu4icudbG 71Vl7qMm7zXTtLXkKpEo1wlUEpDkZnmOxmebPUrfpXnupboSeDZQEjH3LP1MpHjfQRN2iC oo66MXpiAqq6Q+WVN49mowhgQsL3IOkd3cLmYYzDqMDYFq1tUj6x7dJ7ABmI2rF8VD3bU7 d1Vagd7r099xSMJNkrFA6rnyEkYf013CPmWyPNMQTqhnYJtOE/3HXHAsyqtKA2CvnfRDEA qgKV86mG2h649kHXOmWPqcAnA/3Akf9JWF5eCeriKJCucGX6s8L+XMGdhPwMXg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1775147559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JR2o/Dc9KQQqFMs2hnW304fAynwgXnuFy/EOByn52Nw=; b=6AqVCuFcgm8NfkvkcuFzT+6kOyfZDv460at6EMrCJkrv7U4omptslPzMFsro2W2Y4zBCvx UkDaiYTCIzaLE/BQ== From: Sebastian Andrzej Siewior To: Willem de Bruijn Cc: netdev@vger.kernel.org, "(JC), Jayachandran" , "David S. Miller" , Andrew Lunn , Chintan Vankar , Danish Anwar , Daolin Qiu , Eric Dumazet , Felix Maurer , Jakub Kicinski , Paolo Abeni , Richard Cochran , Simon Horman , "Raghavendra, Vignesh" , "Bajjuri, Praneeth" , "TK, Pratheesh Gangadhar" , "Muralidharan, Neelima" Subject: Re: [PATCH RFC net-next v2 2/2] af_packet: Add port specific handling for HSR Message-ID: <20260402163237.EIE16Pj_@linutronix.de> References: <20260312154253.UC-QUPvD@linutronix.de> <20260313092226.SscHp2zQ@linutronix.de> <20260313160410.LEhav8Xz@linutronix.de> <20260317172906.eG2LxlZ7@linutronix.de> <20260319142613.KHz32I-V@linutronix.de> <20260324163820.p9M2z27W@linutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260324163820.p9M2z27W@linutronix.de> Hi Willem, On 2026-03-24 17:38:21 [+0100], To Willem de Bruijn wrote: > On 2026-03-19 12:27:57 [-0400], Willem de Bruijn wrote: > >=20 > > Right, so this is simple without hardware offload. Does this HW > > offload exist, or is this aspirational. At least for infrequent PTP > > it does not sound important. >=20 > The snippet below was for the icssg driver as-is and it works with > updated firmware to ignore PTP packets while HW offloading is enabled. =E2=80=A6 > With the skb_ext I had, the mechanism was mostly the same but it relied > only on the skb_ext data. Now it has to look at skb->mark. Had you so time think about it? The proposed skb->mark solution kind of works but feels hacky. The version with skb_ext does touch packet's code but it is self contained and does not slowdown the !HSR+PTP case since the compare conditions are NOPed. How do we move forward here? =20 Sebastian