From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA814373BEB; Thu, 2 Apr 2026 18:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775154430; cv=none; b=d4uurLMw8qNEbIlV+jMsZ+X++BUXUq8qcxzaeG9CVvorudcqKHqxzm8AOxiLdvx/XDFuo/Qa1HPxyL7aRm8EekphCa6TnNV3950S+zPS2UTP30mlsVVlrIILWK8dUbreM8nxNcXm0HExA2W0Tq3RQEwsaAEAMsN6cPHg1p2IvC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775154430; c=relaxed/simple; bh=fSsf6YcB7e6GhxRhhUZLjb1tw7iGg3byv5rSHDsUr8c=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DZt2VS4q8TUTM03noDNhwafmw4w0DfMUyNY8zfAU4O8oPVyrevz9N0QIQKC6oKX0WIJsbdb9HOfM2hKz9TpfFunNR6HkARB6mH0T8taXtlBp2DjcYvtDH+jG73Tf9Eqx+Ud6kdKhStBkJl9Q4CVCrkAIrxWIriGBHOMoymOYfpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=ihQCsPjT; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="ihQCsPjT" Received: by linux.microsoft.com (Postfix, from userid 1173) id B828920B7136; Thu, 2 Apr 2026 11:27:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B828920B7136 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775154428; bh=0AvdIAIcrnuYLaP5WWfHLp/4nBpChaHQuE+QzTbHK+E=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ihQCsPjT0SRJSv0kUVo1BImmOQKKitXPk30s32k5j/6lH0+M5uh+4iVaEUKxN8LMb wITt1knjMFHTSHhq/DiR+XVq9KLXJ+iDUv+LkzY9rhLSC59BT7Uyef3Nxury8xjY7k KagWrrKHuRpSHiO9DHXTrISHtBmmJSR9wqH8g1r4= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kotaranov@microsoft.com, horms@kernel.org, shradhagupta@linux.microsoft.com, shirazsaleem@microsoft.com, yury.norov@gmail.com, kees@kernel.org, ssengar@linux.microsoft.com, ernis@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH net-next v5 1/3] net: mana: Use pci_name() for debugfs directory naming Date: Thu, 2 Apr 2026 11:26:55 -0700 Message-ID: <20260402182704.2474739-2-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260402182704.2474739-1-ernis@linux.microsoft.com> References: <20260402182704.2474739-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use pci_name(pdev) for the per-device debugfs directory instead of hardcoded "0" for PFs and pci_slot_name(pdev->slot) for VFs. The previous approach had two issues: 1. pci_slot_name() dereferences pdev->slot, which can be NULL for VFs in environments like generic VFIO passthrough or nested KVM, causing a NULL pointer dereference. 2. Multiple PFs would all use "0", and VFs across different PCI domains or buses could share the same slot name, leading to -EEXIST errors from debugfs_create_dir(). pci_name(pdev) returns the unique BDF address, is always valid, and is unique across the system. Fixes: 6607c17c6c5e ("net: mana: Enable debugfs files for MANA device") Signed-off-by: Erni Sri Satya Vennela --- Changes in v5: * New to patchset. Changes in v4, v3, v2: * Not created --- drivers/net/ethernet/microsoft/mana/gdma_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c index 43741cd35af8..098fbda0d128 100644 --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c @@ -2065,11 +2065,8 @@ static int mana_gd_probe(struct pci_dev *pdev, const struct pci_device_id *ent) gc->dev = &pdev->dev; xa_init(&gc->irq_contexts); - if (gc->is_pf) - gc->mana_pci_debugfs = debugfs_create_dir("0", mana_debugfs_root); - else - gc->mana_pci_debugfs = debugfs_create_dir(pci_slot_name(pdev->slot), - mana_debugfs_root); + gc->mana_pci_debugfs = debugfs_create_dir(pci_name(pdev), + mana_debugfs_root); err = mana_gd_setup(pdev); if (err) -- 2.34.1