public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH net v3 0/7] net/sched: netem: bug fixes
Date: Thu,  2 Apr 2026 13:19:28 -0700	[thread overview]
Message-ID: <20260402202037.176299-1-stephen@networkplumber.org> (raw)

These bugs were identified while using AI-assisted code review of
sch_netem.c to analyze the packet duplication re-entrancy problem
(CVE-2025-37890, CVE-2025-38001), which are addressed in a separate
series.

The review uncovered several additional issues:

- probability gaps in the 4-state Markov loss model where
  boundary values produce no state transition
- queue limit check not accounting for reordered packets
- PRNG reseeded on every tc change, breaking reproducibility
- the core dequeue re-entrancy issue with child qdiscs
  causing HFSC eltree corruption and DRR class stalls
- missing NULL termination on the tfifo linear list tail
- slot delay configuration not validated for inverted ranges
- slot delay arithmetic overflow for ranges above ~2.1 seconds

v3 - fix blank line after Fixes:

v2 - pickup the slot related bug fixes

Stephen Hemminger (7):
  net/sched: netem: fix probability gaps in 4-state loss model
  net/sched: netem: fix queue limit check to include reordered packets
  net/sched: netem: only reseed PRNG when seed is explicitly provided
  net/sched: netem: restructure dequeue to avoid re-entrancy with child
    qdisc
  net/sched: netem: null-terminate tfifo linear queue tail
  net/sched: netem: check for invalid slot range
  net/sched: netem: fix slot delay calculation overflow

 net/sched/sch_netem.c | 245 +++++++++++++++++++++++++++---------------
 1 file changed, 160 insertions(+), 85 deletions(-)

-- 
2.53.0


             reply	other threads:[~2026-04-02 20:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 20:19 Stephen Hemminger [this message]
2026-04-02 20:19 ` [PATCH net v3 1/7] net/sched: netem: fix probability gaps in 4-state loss model Stephen Hemminger
2026-04-04  9:50   ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 2/7] net/sched: netem: fix queue limit check to include reordered packets Stephen Hemminger
2026-04-04  9:50   ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 3/7] net/sched: netem: only reseed PRNG when seed is explicitly provided Stephen Hemminger
2026-04-04  9:50   ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 4/7] net/sched: netem: restructure dequeue to avoid re-entrancy with child qdisc Stephen Hemminger
2026-04-04  9:49   ` Simon Horman
2026-04-06 15:41     ` Jakub Kicinski
2026-04-06 17:12       ` Stephen Hemminger
2026-04-02 20:19 ` [PATCH net v3 5/7] net/sched: netem: null-terminate tfifo linear queue tail Stephen Hemminger
2026-04-04  9:50   ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 6/7] net/sched: netem: check for invalid slot range Stephen Hemminger
2026-04-04  9:51   ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 7/7] net/sched: netem: fix slot delay calculation overflow Stephen Hemminger
2026-04-04  9:51   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402202037.176299-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox