From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179DA3D47C1 for ; Thu, 2 Apr 2026 22:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775170546; cv=none; b=tFpNUqSfd4y3jdFPAzO/jrTPvBv+IOA18qSxmAV772ZqunOsyqR9rdlmHeC8rJnvrhob194oRA0Z3buMdAaNaar2kbSMJ2XsdMFrhTU62lp03mcQXxkOLBy1iGUrBJFfMFcpSwunwFqStnM0LUpyLcoVtlhdO879I2hELoIfpRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775170546; c=relaxed/simple; bh=zJbC+A4/QcCaZAvJAW447Q2AMW5b/YkYtsY9TGpfZ/0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qJNjnjFZjnHz7vkoy19PGx4ZP+czCpajbLO3tqkILwMy+B8bh7Wtsa6w748suCfYC4Dj8ONZyjqk815ilpfw5yEweWGawqKGo3chDMrClAYardAFAAWai1shjfQvRg943p2dsLQ0YqHdHuLBiL3+lIsqnGSKdTOHZYRHgJQRKhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2cb3cb2fc7bso539976eec.1 for ; Thu, 02 Apr 2026 15:55:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775170544; x=1775775344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gV1gd8eqR5trFawrue+Fwjx0Nv4SVD+as/Eza1/G79Q=; b=Uf5ZdSaHaLEhY19U/Btx47KaG62a+9FCU1hoHlyWRKmmGyiVPwitCIDw7hDwiEmRXa UWBNOxjr+MO2blFtf2HTcvNc7381kGzchJkp2ec+CbkrL4qt3NX1hUwWNfQ+MxuTmzOo H0/SbLp9TNWr1p6xGRrbCbxYbEN962I3H9nrzYsrp0B0Rx9KLuNVnuE1VvAE+apbF+Oo 1KCV1JqdgwfLOL2QnHILlGO+JUic3edqXyNwb14qh+vl6Aef+weJX4ycVRh2gZMAz55V V/SfRUG8pF+Xtw/pMwirrBMoz12TxUc1zj9/fSyQ58zsiOQAZAmpWFfjC4Ud054VTc4B +xpA== X-Gm-Message-State: AOJu0YwZ3SrQA/0OwlCdiaNDnKCoFQNJPsa/mA9lPWRp4/BtZCznl7Ch hxwQB6ySmmcUoJV4vMnK1sw6O0+rXNY05Mm82MXAm0Sln4+sBfr2uHyioWOD X-Gm-Gg: AeBDievpV1oZtGr7mS6hmXnpyjQAAWvlaUdLvvVhSzI7FLfzKbWcm+Otipfzykf8dn3 HteZOD/Bfr8UhKW1crvMpSchuCd6gA51HUc+6BfqAHylVq3iv6qDATWm4po3ih/JI9rD97NkF68 aYqh6B9sRzyJ8eamJyo1YDvql+IWpmt6kNQ1EPki0XTj/QnFJ00fMt2YpZNntaw3KIBq0BMcVEJ cMJV6u9mPywCKKZQteJQuVkG0gm7DgQj2yQpo/m62J9fuzCMyfywwegiPP/OXGThY012fe54sKp BuYQ+58p8fMj7GOA+sutRRb58GgM1YdepqRRxV8OLPL2PNDMJPzwN/8m69x2w22oY5UnoCqSMJK iR4u6uXgVGcDYT8cUxk2mJs4U4XXoLvU0JfyIQ5Kkorn5pVds0LFcW9ksQysc/gk/y7BNfVYMo/ Pq1bYpvEvh+T5EJrq2QxTtodAAu7LM2AvaL0eWuF2lHXPbfRFkrc2+aE9X2B82RK2bAOd9UiEJs y4Lyiq9QXlld+6guLnfui7/P+oM X-Received: by 2002:a05:7301:1288:b0:2be:ca4:e114 with SMTP id 5a478bee46e88-2cbfb1a769fmr421193eec.9.1775170543938; Thu, 02 Apr 2026 15:55:43 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca79e1d93bsm3662952eec.12.2026.04.02.15.55.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 15:55:43 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Michael Chan , Pavan Chebbi , Aleksandr Loktionov Subject: [PATCH net-next v5 07/14] bnxt: convert to ndo_set_rx_mode_async Date: Thu, 2 Apr 2026 15:55:28 -0700 Message-ID: <20260402225535.4124525-8-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402225535.4124525-1-sdf@fomichev.me> References: <20260402225535.4124525-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert bnxt from ndo_set_rx_mode to ndo_set_rx_mode_async. bnxt_set_rx_mode, bnxt_mc_list_updated and bnxt_uc_list_updated now take explicit uc/mc list parameters and iterate with netdev_hw_addr_list_for_each instead of netdev_for_each_{uc,mc}_addr. The bnxt_cfg_rx_mode internal caller passes the real lists under netif_addr_lock_bh. BNXT_RX_MASK_SP_EVENT is still used here, next patch converts to the direct call. Cc: Michael Chan Cc: Pavan Chebbi Reviewed-by: Michael Chan Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++++++++++++---------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 8ec611bc01ee..11956c7dde23 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11033,7 +11033,8 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp) } static int bnxt_cfg_rx_mode(struct bnxt *); -static bool bnxt_mc_list_updated(struct bnxt *, u32 *); +static bool bnxt_mc_list_updated(struct bnxt *, u32 *, + const struct netdev_hw_addr_list *); static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) { @@ -11123,7 +11124,7 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) } else if (bp->dev->flags & IFF_MULTICAST) { u32 mask = 0; - bnxt_mc_list_updated(bp, &mask); + bnxt_mc_list_updated(bp, &mask, &bp->dev->mc); vnic->rx_mask |= mask; } @@ -13512,17 +13513,17 @@ void bnxt_get_ring_drv_stats(struct bnxt *bp, bnxt_get_one_ring_drv_stats(bp, stats, &bp->bnapi[i]->cp_ring); } -static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) +static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; - struct net_device *dev = bp->dev; struct netdev_hw_addr *ha; u8 *haddr; int mc_count = 0; bool update = false; int off = 0; - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >= BNXT_MAX_MC_ADDRS) { *rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; @@ -13546,17 +13547,17 @@ static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) return update; } -static bool bnxt_uc_list_updated(struct bnxt *bp) +static bool bnxt_uc_list_updated(struct bnxt *bp, + const struct netdev_hw_addr_list *uc) { - struct net_device *dev = bp->dev; struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; struct netdev_hw_addr *ha; int off = 0; - if (netdev_uc_count(dev) != (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) != (vnic->uc_filter_count - 1)) return true; - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; @@ -13565,7 +13566,9 @@ static bool bnxt_uc_list_updated(struct bnxt *bp) return false; } -static void bnxt_set_rx_mode(struct net_device *dev) +static void bnxt_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct bnxt *bp = netdev_priv(dev); struct bnxt_vnic_info *vnic; @@ -13586,7 +13589,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) if (dev->flags & IFF_PROMISC) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, uc); if (dev->flags & IFF_BROADCAST) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; @@ -13594,7 +13597,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; } else if (dev->flags & IFF_MULTICAST) { - mc_update = bnxt_mc_list_updated(bp, &mask); + mc_update = bnxt_mc_list_updated(bp, &mask, mc); } if (mask != vnic->rx_mask || uc_update || mc_update) { @@ -13613,7 +13616,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) bool uc_update; netif_addr_lock_bh(dev); - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, &dev->uc); netif_addr_unlock_bh(dev); if (!uc_update) @@ -15864,7 +15867,7 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_start_xmit = bnxt_start_xmit, .ndo_stop = bnxt_close, .ndo_get_stats64 = bnxt_get_stats64, - .ndo_set_rx_mode = bnxt_set_rx_mode, + .ndo_set_rx_mode_async = bnxt_set_rx_mode, .ndo_eth_ioctl = bnxt_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = bnxt_change_mac_addr, -- 2.53.0