From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E890C37881C for ; Thu, 2 Apr 2026 23:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174188; cv=none; b=pX5Rd4pkqKdp7yr2RIQjc9R8BU1V42BJGIo10xyz1kZ0A5Zyu+oym09/ry179VlFmopgXBrbdYOD4neHZFS3mmKoeykxH+zSO0J5BGw2jhF7XYU2x5m3NnqHe/iluTCm+ATTeGewmmGybfHudgb4kG3w3L5moBRQCmyBUsWhbNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174188; c=relaxed/simple; bh=t2q54dSmGg/P9XU/0IB+SlhWx+nOeGh1AY4CpjdTCuY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kqqObk7UIVdm7/hcJUKWsXdEqtY0cKgxxkF5SFRHumxxVuGboCjZ5sMzNS2ITKvwlqpTlgNLnmIsLtPvCmb96PD6R+dWfRKKswqUkbTbGa31s2x2cgyp7JqZYEDY3KL4CBEIJYEbDK84UCusaU/paVPPdcenqj4eppo0eLFTzlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Ou6x05oZ; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Ou6x05oZ" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-46ceca1e0bbso918299b6e.3 for ; Thu, 02 Apr 2026 16:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1775174186; x=1775778986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JUYswyn48cyLyzm2NTizcwnGHwsK5SZG4hQrEOA7tkU=; b=Ou6x05oZre5yTL2vwlHlruQKbUCalEVp3sMj22tUkKRoNTBO0AFP39yp7Y16bFYMI+ P2tgXdPxPWL8J/DyZgloJ+b5bpRK2RKXME4SwPReY1+bSnrFFX6dJAihfFntchZbikUP 7pKQPUtJMyIHUO8r4VR3/h9sT1LAwpUWuahEUGeNs24b7RxItFzG6FCYnuO+hYN5gERJ MalhUkIlAVNoX0f5N1WXwqat7rKUsOQzq9j3OacuuUhCClhYFdEu8xMpOnT5NuRe79n1 OQIN/4NHQPCN9BCEjmicaiZyTgeA8aC+ptMyqB6dC40vbRnFbdzTATDI+IdymdGpZj0N QXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775174186; x=1775778986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JUYswyn48cyLyzm2NTizcwnGHwsK5SZG4hQrEOA7tkU=; b=OCNH9F+nBdaqNW5Tib0JKK3Ol3HXottwlzTQz+5Z1vQYnR25+AMpBBsA2ZB0aXTlLI avEZzvlfrfJV7mVAxd1v05iwGW1C5Rybd+Fy59AOGaaMNXXXmd8JJDduY4qC7WHSQt8p CCqr2ooSFJHPhco7mghoW7iaarg61DXe93YQ0SUenCA8FNF4vfiByWZE6ccn+Y8xnS97 MB+xI+5bIPZVYn9BaXgGacTh0pm6ZYlluVuMsyCU2MVKaUg9QHBgZb11BwK5xuzlmQlm NYJt8Bk17vt70v7HMSDp2QLYDmJIfE7elpgxkZtdNGJzA4p3Jxy3+k3DT823ENYsQxBA m12g== X-Gm-Message-State: AOJu0YzhePNSrPmItmTiQwe1IY4s7fPxvdF5MHT1QnN4BI1SD3JBZZ7b tvMV4ODbanGIyd+mEtSThFKxAqEdMNi/nZCp+P/19fbEOYu7NN5rVMBA3GytS+Dxyf9Kv4J10bH Ywma1VPdRW8i7nXHVEG5vXRMBIIh7UXIl9qsdHg58JuRImrF5RgFWbOGDvLyw/Y8oaCLoy3V9Gw qUYx4IHCC79PnL0Z6mHxIvd7fsiJ24FS367FmGOkGaIP4PVUM= X-Gm-Gg: ATEYQzznkbRD5VXrCsZDjUXNXTR+9tEw4avKPN/EyhLCCIPJFkBlXIe8sSf0c+UfwGJ ZIv+t8DQ/Yvmc7hzrsrqnTwuMEYzJXThJTKItz9eKu6kU8eCMLvxyIum5FoDzDskk3GM6psAPLk rIQqjY53lTa10Krk+7P15clvO3oLY67DmGnlQKw4ugWBxHoLpanmgpyGWhpPx2k5wf9qw8Ss1CE AmFNcrgM2/7jjsgHiN4PDg7MFuItjhn7NOVxd2jLo9/gHrAhWEt0T6FsKJGe4e+fAkclFr5KwrQ rduHzZCxroOPb1f3AOWqFjsnxqzBvS+Pt9WAkdU5wlZwN/7TGhffCr34KRIjINo3qacMUEfWYJv aJKAFwvJ2oUPDgudwnFHWUgmHyFil2qzVTWlfwe8g3nZmLv8kvhpxa1JF9C18UyzmLIpbmJ34wv vRiZH5eDlB6uB7Ujp62rOAs/6ZrE0cs17E7792uQCxoI8Chda2aWDG0OQfYGdn+hLC+PyQvZpPJ PE= X-Received: by 2002:a05:6808:5088:b0:466:f3a2:dc34 with SMTP id 5614622812f47-46ef7e16a8cmr670735b6e.36.1775174185595; Thu, 02 Apr 2026 16:56:25 -0700 (PDT) Received: from dev-rjethwani.tier4-kif-devvm.svc.slc-eng-prd2 ([208.88.159.129]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-46d8f9609bfsm2394775b6e.3.2026.04.02.16.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 16:56:25 -0700 (PDT) From: Rishikesh Jethwani To: netdev@vger.kernel.org Cc: saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, borisp@nvidia.com, john.fastabend@gmail.com, kuba@kernel.org, sd@queasysnail.net, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, leon@kernel.org, Rishikesh Jethwani Subject: [PATCH v12 2/6] net/mlx5e: add TLS 1.3 hardware offload support Date: Thu, 2 Apr 2026 17:55:07 -0600 Message-Id: <20260402235511.664801-3-rjethwani@purestorage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260402235511.664801-1-rjethwani@purestorage.com> References: <20260402235511.664801-1-rjethwani@purestorage.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable TLS 1.3 TX/RX hardware offload on ConnectX-6 Dx and newer crypto-enabled adapters. Key changes: - Add TLS 1.3 capability checking and version validation - Use MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_3 (0x3) for crypto context - Handle TLS 1.3 IV format: full 12-byte IV copied to gcm_iv + implicit_iv (vs TLS 1.2's 4-byte salt only) Tested with TLS 1.3 AES-GCM-128 and AES-GCM-256 cipher suites. Signed-off-by: Rishikesh Jethwani --- .../ethernet/mellanox/mlx5/core/en_accel/ktls.h | 8 +++++++- .../mellanox/mlx5/core/en_accel/ktls_txrx.c | 14 +++++++++++--- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h index 07a04a142a2e..0469ca6a0762 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h @@ -30,7 +30,9 @@ static inline bool mlx5e_is_ktls_device(struct mlx5_core_dev *mdev) return false; return (MLX5_CAP_TLS(mdev, tls_1_2_aes_gcm_128) || - MLX5_CAP_TLS(mdev, tls_1_2_aes_gcm_256)); + MLX5_CAP_TLS(mdev, tls_1_2_aes_gcm_256) || + MLX5_CAP_TLS(mdev, tls_1_3_aes_gcm_128) || + MLX5_CAP_TLS(mdev, tls_1_3_aes_gcm_256)); } static inline bool mlx5e_ktls_type_check(struct mlx5_core_dev *mdev, @@ -40,10 +42,14 @@ static inline bool mlx5e_ktls_type_check(struct mlx5_core_dev *mdev, case TLS_CIPHER_AES_GCM_128: if (crypto_info->version == TLS_1_2_VERSION) return MLX5_CAP_TLS(mdev, tls_1_2_aes_gcm_128); + else if (crypto_info->version == TLS_1_3_VERSION) + return MLX5_CAP_TLS(mdev, tls_1_3_aes_gcm_128); break; case TLS_CIPHER_AES_GCM_256: if (crypto_info->version == TLS_1_2_VERSION) return MLX5_CAP_TLS(mdev, tls_1_2_aes_gcm_256); + else if (crypto_info->version == TLS_1_3_VERSION) + return MLX5_CAP_TLS(mdev, tls_1_3_aes_gcm_256); break; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.c index 570a912dd6fa..f3f1be1d4034 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.c @@ -6,6 +6,7 @@ enum { MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_2 = 0x2, + MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_3 = 0x3, }; enum { @@ -15,8 +16,10 @@ enum { #define EXTRACT_INFO_FIELDS do { \ salt = info->salt; \ rec_seq = info->rec_seq; \ + iv = info->iv; \ salt_sz = sizeof(info->salt); \ rec_seq_sz = sizeof(info->rec_seq); \ + iv_sz = sizeof(info->iv); \ } while (0) static void @@ -24,9 +27,9 @@ fill_static_params(struct mlx5_wqe_tls_static_params_seg *params, union mlx5e_crypto_info *crypto_info, u32 key_id, u32 resync_tcp_sn) { + u16 salt_sz, rec_seq_sz, iv_sz; + char *salt, *rec_seq, *iv; char *initial_rn, *gcm_iv; - u16 salt_sz, rec_seq_sz; - char *salt, *rec_seq; u8 tls_version; u8 *ctx; @@ -59,7 +62,12 @@ fill_static_params(struct mlx5_wqe_tls_static_params_seg *params, memcpy(gcm_iv, salt, salt_sz); memcpy(initial_rn, rec_seq, rec_seq_sz); - tls_version = MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_2; + if (crypto_info->crypto_info.version == TLS_1_3_VERSION) { + memcpy(gcm_iv + salt_sz, iv, iv_sz); + tls_version = MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_3; + } else { + tls_version = MLX5E_STATIC_PARAMS_CONTEXT_TLS_1_2; + } MLX5_SET(tls_static_params, ctx, tls_version, tls_version); MLX5_SET(tls_static_params, ctx, const_1, 1); -- 2.25.1