Re: [PATCH net-next 1/9] net: tso: add tso_features_check()

Jakub Kicinski
2026-04-03T20:47:33Z

On Fri, 3 Apr 2026 00:20:13 -0700 Eric Dumazet wrote:
> > I forgot that netif_skb_features() uses:
> >
> > if (dev->netdev_ops->ndo_features_check)
> > features &= dev->netdev_ops->ndo_features_check(skb, dev,
> > features);
> > else
> > features &= dflt_features_check(skb, dev, features);
> >
> > So I need to call vlan_features_check() from tso_features_check()
>
> I could be wrong though, vlan_features_check() is about skbs with
> multiple vlan tags,
> and net/core/tso.c should support them just fine.

But we probably still need to clear NETIF_F_IP_CSUM for example?
Better safe than sorry. (I won't repeat the sashiko complaints
assuming you saw those ;))