From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f73.google.com (mail-qv1-f73.google.com [209.85.219.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19978355F36 for ; Fri, 3 Apr 2026 04:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775190775; cv=none; b=XsFej7GE5tbt8zvjsjPyCWQIQsqzmezJRSnQ4xBxeIYaMU9ebsfN68mQxNJDCUWMcoIipomlJI+puggKyk2FcTDXErNdXqFfyFilO0SmK3ICV++VS/AEzgngnlSgSIIiZmoHUEVd8t+NMG2MZM26JNY9kR1BuZym+ATAcngYw0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775190775; c=relaxed/simple; bh=mxHgQ/mC4zuMzQQwM9oEWP2Y+5peuHhCCYbO9OpBZlU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uFxuyg6aGgVU+NdPwXS2jHuc04WOZlqWr2y6O9S2tCZX8t+Qy+UnqQHBIFNLiPFXTPcpvLHWyKKodVxm68+DiB9/nf1fSH6LIQoDPl+B7gqZuaJ8eJD3NfveU/djoN8cYJpTKahkwHmLrKJE2pW8dobAlXoPj6S/NhDfKBU5J6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jFp3sQOD; arc=none smtp.client-ip=209.85.219.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jFp3sQOD" Received: by mail-qv1-f73.google.com with SMTP id 6a1803df08f44-8a0ef4a7021so25009666d6.2 for ; Thu, 02 Apr 2026 21:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775190773; x=1775795573; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=H1rhXDS3WrBPEeXWdLc810CtUcsfxLqQZ4w3SZY4Nfg=; b=jFp3sQOD8yEoodCmmmxaOe+x4zXDsKcIY6mEMGfFqJxpJHV6qHigdTHJj0Vlxw4l7V HRShFGFSoO6gWbpB9wvReu8w9pyQhI/ZbbhTQVmWL+2kx9nQgbu6kURF+gtdFC9OCjnU AbST7HGUdFcZgZAQPkyBlM+Q+IsqotY9YArTIblaYHc9JOVe+0AgVxEHCjbKzoYuJgiF 0/9JTDxZGXiWJUU1nI8PA3wulCBJ5wXonUyS/0c3LTeCJwFALvkCkTg770zu55p+u8B4 38dJvMA9083Yt9w2/sS/iK1eRRR6SrxtnmGi1WP87bh2u18v/sNdcIC+HjbqKcSlMUtR YfcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775190773; x=1775795573; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H1rhXDS3WrBPEeXWdLc810CtUcsfxLqQZ4w3SZY4Nfg=; b=gRomifMWwQ/lNH+qMFapYnHY7/rpQ3tp2weJlR8fjXJdbWqic5PtFcrNSvNFIGLHjq VI+G3OnSXAKktEyuMTF4ME2miYvFQ1juPvPqG9W3ntkt88cesG886UxO5x3c9hCRrHqX EgTpyqwO/ZNX0XKs0s+il9eopwcDNnc5m0bA1q7b28MLE3UIAAtAd5jdF1BW/am6EJ/j QLMrSLtdPIn/OoQkUlof3Zjq+OI8hBXDTTLnusiN7Xs/Cxuj7aIxCiFwd7RGhSNIkuPC e2xARx52Y4hFMZPMCHbnp43szlecb8YT6+EPHTVXy2fnuTKVntQsYm5X1T/Bcip1TZCX 60lw== X-Forwarded-Encrypted: i=1; AJvYcCWglsQO2n46y2jiretYozo3myRPKRKXZfvPLjGRBBROkmrH01aTQEFrNDZqiXQlylPfOTMRgMc=@vger.kernel.org X-Gm-Message-State: AOJu0YxN8R9vkMcTxXwGC2BKsZbzDIzrSQIt3i2IL1URwYwIEwsnDOK9 UH0bohdlxa/OUFPN45Kgnv8wWrkVBDwQf3exXjCcdlngBFSGnaSuJDB67fFiG+W6cGzGquEekcV h1tJP9dSl625vbg== X-Received: from qvab25.prod.google.com ([2002:a05:6214:6119:b0:89c:e38f:6b77]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6214:8081:b0:8a5:5a37:511 with SMTP id 6a1803df08f44-8a704fa05aemr23569586d6.42.1775190773028; Thu, 02 Apr 2026 21:32:53 -0700 (PDT) Date: Fri, 3 Apr 2026 04:32:36 +0000 In-Reply-To: <20260403043237.3909226-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260403043237.3909226-1-edumazet@google.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260403043237.3909226-9-edumazet@google.com> Subject: [PATCH net-next 8/9] net: mvpp2: use tso_features_check() From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Andrew Lunn , Joe Damato , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet , Antoine Tenart , Sebastian Hesselbarth Content-Type: text/plain; charset="UTF-8" We must fallback to GSO if a TSO packet has too big headers, or risk corruptions. Fixes: 186cd4d4e414 ("net: mvpp2: software tso support") Signed-off-by: Eric Dumazet Cc: Antoine Tenart Cc: Sebastian Hesselbarth --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index f442b874bb5933b298773bee7e6140e753bce013..6a065402f62605a9333c9050cdbb793ce547e74a 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -4318,6 +4318,7 @@ static int mvpp2_tx_tso(struct sk_buff *skb, struct net_device *dev, return 0; hdr_sz = tso_start(skb, &tso); + DEBUG_NET_WARN_ON_ONCE(hdr_sz > TSO_HEADER_SIZE); len = skb->len - hdr_sz; while (len > 0) { @@ -5795,6 +5796,7 @@ static int mvpp2_ethtool_set_eee(struct net_device *dev, static const struct net_device_ops mvpp2_netdev_ops = { .ndo_open = mvpp2_open, .ndo_stop = mvpp2_stop, + .ndo_features_check = tso_features_check, .ndo_start_xmit = mvpp2_tx, .ndo_set_rx_mode = mvpp2_set_rx_mode, .ndo_set_mac_address = mvpp2_set_mac_address, -- 2.53.0.1213.gd9a14994de-goog