From: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com,
Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Subject: [PATCH net-next v11 08/10] bng_en: implement ndo_get_stats64
Date: Fri, 3 Apr 2026 13:07:22 +0530 [thread overview]
Message-ID: <20260403073724.194360-9-bhargava.marreddy@broadcom.com> (raw)
In-Reply-To: <20260403073724.194360-1-bhargava.marreddy@broadcom.com>
Implement the ndo_get_stats64 callback to report aggregate network
statistics. The driver gathers these by accumulating the per-ring
counters into the provided rtnl_link_stats64 structure.
Signed-off-by: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>
---
.../net/ethernet/broadcom/bnge/bnge_netdev.c | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index 61bac71c7f74..9a5d667defea 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
@@ -2897,6 +2897,46 @@ static int bnge_shutdown_nic(struct bnge_net *bn)
return 0;
}
+static void bnge_get_port_stats64(struct bnge_net *bn,
+ struct rtnl_link_stats64 *stats)
+{
+ unsigned int start;
+ u64 *tx, *rx;
+
+ rx = bn->port_stats.sw_stats;
+ tx = bn->port_stats.sw_stats + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8;
+
+ do {
+ start = u64_stats_fetch_begin(&bn->port_stats.syncp);
+
+ stats->rx_crc_errors =
+ BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames);
+ stats->rx_frame_errors =
+ BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames);
+ stats->rx_length_errors =
+ BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) +
+ BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) +
+ BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames);
+ stats->rx_errors =
+ BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) +
+ BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames);
+ stats->collisions =
+ BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions);
+ stats->tx_fifo_errors =
+ BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns);
+ stats->tx_errors = BNGE_GET_TX_PORT_STATS64(tx, tx_err);
+ } while (u64_stats_fetch_retry(&bn->port_stats.syncp, start));
+}
+
+static void bnge_get_stats64(struct net_device *dev,
+ struct rtnl_link_stats64 *stats)
+{
+ struct bnge_net *bn = netdev_priv(dev);
+
+ if (bn->flags & BNGE_FLAG_PORT_STATS)
+ bnge_get_port_stats64(bn, stats);
+}
+
static void bnge_close_core(struct bnge_net *bn)
{
struct bnge_dev *bd = bn->bd;
@@ -2930,6 +2970,7 @@ static const struct net_device_ops bnge_netdev_ops = {
.ndo_open = bnge_open,
.ndo_stop = bnge_close,
.ndo_start_xmit = bnge_start_xmit,
+ .ndo_get_stats64 = bnge_get_stats64,
.ndo_features_check = bnge_features_check,
};
--
2.47.3
next prev parent reply other threads:[~2026-04-03 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 7:37 [PATCH net-next v11 00/10] bng_en: add link management and statistics support Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 02/10] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 03/10] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 04/10] bng_en: implement ethtool pauseparam operations Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 05/10] bng_en: add support for link async events Bhargava Marreddy
2026-04-08 12:51 ` Vadim Fedorenko
2026-04-03 7:37 ` [PATCH net-next v11 06/10] bng_en: add HW stats infra and structured ethtool ops Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 07/10] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-04-03 7:37 ` Bhargava Marreddy [this message]
2026-04-03 7:37 ` [PATCH net-next v11 09/10] bng_en: implement netdev_stat_ops Bhargava Marreddy
2026-04-03 7:37 ` [PATCH net-next v11 10/10] bng_en: add support for ethtool -S stats display Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403073724.194360-9-bhargava.marreddy@broadcom.com \
--to=bhargava.marreddy@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox