public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c
@ 2026-04-03 19:57 Juanlu Herrero
  2026-04-03 20:16 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Juanlu Herrero @ 2026-04-03 19:57 UTC (permalink / raw)
  To: kuba; +Cc: netdev, Juanlu Herrero

---
 tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
index 240d13dbc54e..df44b0eb46cc 100644
--- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
+++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
@@ -266,7 +266,7 @@ static void process_accept(struct io_uring *ring, struct io_uring_cqe *cqe)
 
 static void process_recvzc(struct io_uring *ring, struct io_uring_cqe *cqe)
 {
-	unsigned rq_mask = rq_ring.ring_entries - 1;
+	unsigned int rq_mask = rq_ring.ring_entries - 1;
 	struct io_uring_zcrx_cqe *rcqe;
 	struct io_uring_zcrx_rqe *rqe;
 	struct io_uring_sqe *sqe;
@@ -406,8 +406,7 @@ static void run_client(void)
 
 static void usage(const char *filepath)
 {
-	error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h<server_ip> -p<port> "
-		    "-l<payload_size> -i<ifname> -q<rxq_id>", filepath);
+	error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h<server_ip> -p<port> -l<payload_size> -i<ifname> -q<rxq_id>", filepath);
 }
 
 static void parse_opts(int argc, char **argv)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c
  2026-04-03 19:57 [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c Juanlu Herrero
@ 2026-04-03 20:16 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-04-03 20:16 UTC (permalink / raw)
  To: Juanlu Herrero; +Cc: netdev

On Fri,  3 Apr 2026 14:57:53 -0500 Juanlu Herrero wrote:
> Subject: [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-03 20:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-03 19:57 [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c Juanlu Herrero
2026-04-03 20:16 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox