From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34A3F1DED40 for ; Fri, 3 Apr 2026 20:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775248315; cv=none; b=ZUpvNmrjm3EuVxZlrPoDN+0uYdSqA2aaetcG7kxVffx8Q9yBeBkEjqOTsR8CJQZkx+wjHsiAl//0dMhv52Q8eONK7eGrq6LBgYAHqAXl0sXewb4rhGmA09HF65sjlk5wcc5J5Sg6C/l98p6zLzaX1Z7uqOTtzEJU1hkMkhYnSUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775248315; c=relaxed/simple; bh=kRSdpPftlPXpWSkQNV9eGxTo87saqeQej0kmzHourY0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WuRgDFu3FANYHjjkhrDgE9wiYWEvW3lfkaaAP3031EQtne2b4P5Y1IjilMa9e4o+P5iwyIwUtHCooxOZBjbVO1pSAs8jWjxM8ZqYZaQi3nndxhh/T/Y+KjLx4NDfdAn2/lvcykY/+ZEpyyXO5nPTs6rWml888nz4uCtU8h6TfYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VYBKuBIh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VYBKuBIh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CC25C4CEF7; Fri, 3 Apr 2026 20:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775248314; bh=kRSdpPftlPXpWSkQNV9eGxTo87saqeQej0kmzHourY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VYBKuBIhN3kQ0pjM3fXegX3m6QrjzZDZzi3A6/kELX5TAzD9YCG+NXcaC8/zA5tIE izBVq595Ttj8SClF9uJPQZuCzhRqnCrxYPasr5F0jbY8rPanhHBDsw3sqwQcPKrt0j A5GhWKLBzr2swG+X8eAyrQjiaH32aeNfmTThUr57Fx/XAegVkBxHN/GKYCb/Fj9lmh 2EeGEkiNh1qOeyX4q2wq/CLmH2XJHiyaB5yerLGnjRcZrsAyohJYLGOVzLHNgK6MKg bG2PRTi5sZmFbwY+HRgKZHv2QOG/RvcVNn0frYDLXiqDdOVkhVeSHZV4x8yRw02jJQ 4JuHs8fAAZx4A== Date: Fri, 3 Apr 2026 13:31:53 -0700 From: Jakub Kicinski To: Davide Caratti Cc: Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Xiang Mei , netdev@vger.kernel.org, Victor Nogueira Subject: Re: [PATCH net] net/sched: cls_fw: fix NULL dereference of "old" filters before change() Message-ID: <20260403133153.0fc66fe1@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 Apr 2026 16:13:11 +0200 Davide Caratti wrote: > Like pointed out by Sachiko [1], TC filters are added to a shared block > before their ->change() function is called. This is a problem for cls_fw: > an invalid filter created with the "old" method can still classify some > packets before it is destroyed by the validation logic added by Xiang. One version in a 24h window, please. -- pv-bot: 24h